[code coverage] collect for oss integration tests #83907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlemeshko
commented
Nov 20, 2020
packages/kbn-optimizer/src/integration_tests/basic_optimization.test.ts
Outdated
Show resolved
Hide resolved
dmlemeshko
added
release_note:skip
…rage-for-jest-integration-tests
Member
Author
|
@elasticmachine merge upstream |
…rage-for-jest-integration-tests
…thub.com:dmlemeshko/kibana into collect-code-coverage-for-jest-integration-tests
tylersmalley
approved these changes
Nov 24, 2020
spalger
reviewed
Nov 24, 2020
packages/kbn-optimizer/src/integration_tests/basic_optimization.test.ts
Outdated
Show resolved
Hide resolved
spalger
approved these changes
Nov 24, 2020
Contributor
spalger
left a comment
spalger
left a comment
There was a problem hiding this comment.
One suggestion, but LGTM
…n.test.ts Co-authored-by: Spencer <email@spalger.com>
wayneseymour
approved these changes
Nov 24, 2020
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
rylnd
added a commit
to rylnd/kibana
that referenced
this pull request
Nov 24, 2020
* master: (41 commits) [Maps] fix code-owners (elastic#84265) [@kbn/utils] Clean target before build (elastic#84253) [code coverage] collect for oss integration tests (elastic#83907) [APM] Use `asTransactionRate` consistently everywhere (elastic#84213) Attempt to fix incremental build error (elastic#84152) Unskip "Copy dashboards to space" (elastic#84115) Remove expressions.legacy from README (elastic#79681) Expression: Add render mode and use it for canvas interactivity (elastic#83559) [deb/rpm] Move systemd service to /usr/lib/systemd/system (elastic#83571) [Security Solution][Resolver] Allow a configurable entity_id field (elastic#81679) [ML] Space permision checks for job deletion (elastic#83871) [build] Provide ARM build of RE2 (elastic#84163) TSVB should use "histogram:maxBars" and "histogram:barTarget" settings for auto instead of a default 100 buckets (elastic#83628) [Workplace Search] Initial rendering of Org Sources (elastic#84164) update geckodriver to 0.28 (elastic#84085) Fix timelion vis escapes single quotes (elastic#84196) [Security Solution] Fix incorrect time for dns histogram (elastic#83532) [DX] Bump TS version to v4.1 (elastic#83397) [Security Solution] Add endpoint policy revision number (elastic#83982) [Fleet] Integration Policies List view (elastic#83634) ...
dmlemeshko
deleted the
collect-code-coverage-for-jest-integration-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Collect code coverage for jest integration tests and merge in jest-combined report
https://kibana-ci.elastic.co/job/elastic+kibana+qa-research/141
Jest combined report stats:
master
44.06% Statements 133066/302004
34.35% Branches 57508/167404
40.64% Functions 33540/82535
51.18% Lines 129181/252424
PR
43.21% Statements 134627/311539
34.63% Branches 58071/167671
39.86% Functions 34102/85555
49.96% Lines 130690/261565
Numbers slightly dropped, but we can see more lines/functions/etc. covered in total 😅