Skip to content

Conversation

@jbudz
Copy link
Member

@jbudz jbudz commented Nov 17, 2020

Generally packages should install service files to
/usr/lib/systemd/system. The current location is typically used for
services configured by the system maintainer.

Closes #16046
Closes #27768

I'm proposing this for 8.0+. Upgrade scenarios will end up with both files installed, and order of operations will cause the original to be used. It'll give a chance for the 7.x enhancements to be added to the old service file and a clean install on 8.x as a starting point to pick up new changes.

Generally packages should install service files to
/usr/lib/systemd/system.  The current location is typically used for
services configured by the system maintainer.

Closes elastic#16046
Closes elastic#27768
@jbudz
Copy link
Member Author

jbudz commented Nov 18, 2020

I'm still looking into this. This change does what we want but I'm checking behavior across upgrades.

edit: see the top comment for upgrade behavior

@jbudz jbudz marked this pull request as ready for review November 20, 2020 16:44
@jbudz jbudz requested a review from a team as a code owner November 20, 2020 16:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz
Copy link
Member Author

jbudz commented Nov 23, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbudz jbudz merged commit 5bc4d75 into elastic:master Nov 24, 2020
@jbudz jbudz deleted the os/mv-service branch November 24, 2020 17:26
rylnd added a commit to rylnd/kibana that referenced this pull request Nov 24, 2020
* master: (41 commits)
  [Maps] fix code-owners (elastic#84265)
  [@kbn/utils] Clean target before build (elastic#84253)
  [code coverage] collect for oss integration tests (elastic#83907)
  [APM] Use `asTransactionRate` consistently everywhere (elastic#84213)
  Attempt to fix incremental build error (elastic#84152)
  Unskip "Copy dashboards to space" (elastic#84115)
  Remove expressions.legacy from README (elastic#79681)
  Expression: Add render mode and use it for canvas interactivity (elastic#83559)
  [deb/rpm] Move systemd service to /usr/lib/systemd/system (elastic#83571)
  [Security Solution][Resolver] Allow a configurable entity_id field (elastic#81679)
  [ML] Space permision checks for job deletion (elastic#83871)
  [build] Provide ARM build of RE2 (elastic#84163)
  TSVB should use "histogram:maxBars" and "histogram:barTarget" settings for auto instead of a default 100 buckets (elastic#83628)
  [Workplace Search] Initial rendering of Org Sources (elastic#84164)
  update geckodriver to 0.28 (elastic#84085)
  Fix timelion vis escapes single quotes (elastic#84196)
  [Security Solution] Fix incorrect time for dns histogram (elastic#83532)
  [DX] Bump TS version to v4.1 (elastic#83397)
  [Security Solution] Add endpoint policy revision number (elastic#83982)
  [Fleet] Integration Policies List view (elastic#83634)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 26, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 83571 or prevent reminders by adding the backport:skip label.

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 83571 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 83571 or prevent reminders by adding the backport:skip label.

@jbudz jbudz added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:fix Team:Operations Kibana-Operations Team v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

service files belong in /lib/systemd/system not /etc/systemd/system SystemD unit is written to non-standard location

4 participants