Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Grokdebugger] Fix simulate error handling #83036

Merged
merged 3 commits into from
Nov 11, 2020
Merged

[Grokdebugger] Fix simulate error handling #83036

merged 3 commits into from
Nov 11, 2020

Commits on Nov 10, 2020

  1. Fix detection of 4xx errors in grokdebugger simulate endpoint 

    - removed code to call simulate endpoint from "KibanaFramework"
- fixed throwing of string value
- using new elasticsearch client instead of legacy
- handle error with shared error handling logic
    @jloleysens
    jloleysens committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    5d3ab9f View commit details
    Browse the repository at this point in the history

  2. added deprecation notice to register route on KibanaFramework

    @jloleysens
    jloleysens committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    c3e5efc View commit details
    Browse the repository at this point in the history

  3. remove deprecation notice

    @jloleysens
    jloleysens committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    57db9d7 View commit details
    Browse the repository at this point in the history