[Grokdebugger] Fix simulate error handling #83036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed code to call simulate endpoint from "KibanaFramework" - fixed throwing of string value - using new elasticsearch client instead of legacy - handle error with shared error handling logic
jloleysens
added
release_note:fix
v8.0.0
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
To update your PR or re-run it, just comment with: |
jloleysens
requested review from
yuliacech
and removed request for
cjcenizal
yuliacech
approved these changes
Nov 11, 2020
There was a problem hiding this comment.
Hi @jloleysens , changes LGTM, I tested locally and everything worked!
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 11, 2020
* Fix detection of 4xx errors in grokdebugger simulate endpoint - removed code to call simulate endpoint from "KibanaFramework" - fixed throwing of string value - using new elasticsearch client instead of legacy - handle error with shared error handling logic * added deprecation notice to register route on KibanaFramework * remove deprecation notice
jloleysens
added a commit
that referenced
this pull request
Nov 11, 2020
* Fix detection of 4xx errors in grokdebugger simulate endpoint - removed code to call simulate endpoint from "KibanaFramework" - fixed throwing of string value - using new elasticsearch client instead of legacy - handle error with shared error handling logic * added deprecation notice to register route on KibanaFramework * remove deprecation notice
This was referenced Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #82869
handleEsErrorshared logic to correctly handle errors originating from ESKibanaFrameworkHow to test
yarn startScreenshots
Release note
Grokdebugger correctly passes Elasticsearch errors to the Kibana UI.