Skip to content

[Metrics UI] Show callout for K8s jobs #79610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2020
Merged

[Metrics UI] Show callout for K8s jobs #79610

merged 1 commit into from
Oct 6, 2020

Conversation

@phillipb
Copy link
Contributor

@phillipb phillipb commented Oct 6, 2020 •
edited
Loading

Summary

Make sure to show "manage jobs" callout for hosts and k8s jobs. Fixes: #79576.

@phillipb phillipb added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Oct 6, 2020
@phillipb phillipb requested a review from a team as a code owner October 6, 2020 03:51
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 6, 2020

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 6, 2020

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
infra 3.8MB 3.8MB +28.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@phillipb phillipb changed the title Show callout for K8s jobs [Metrics UI] Show callout for K8s jobs Oct 6, 2020
@simianhacker simianhacker self-assigned this Oct 6, 2020
@simianhacker simianhacker self-requested a review October 6, 2020 20:39
simianhacker
simianhacker approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillipb phillipb merged commit bd153c4 into elastic:master Oct 6, 2020
@phillipb phillipb mentioned this pull request Oct 7, 2020
Merged
phillipb added a commit to phillipb/kibana that referenced this pull request Oct 7, 2020
@phillipb
Show callout for K8s jobs (elastic#79610)
3373ea4
phillipb added a commit that referenced this pull request Oct 7, 2020
@phillipb
Show callout for K8s jobs (#79610) (#79835)
6640145
@phillipb phillipb mentioned this pull request Oct 19, 2020
Merged
phillipb added a commit to phillipb/kibana that referenced this pull request Oct 19, 2020
@phillipb
Show callout for K8s jobs (elastic#79610)
3ede044
phillipb added a commit that referenced this pull request Oct 19, 2020
@phillipb
Show callout for K8s jobs (#79610) (#80977)
e0849e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simianhacker simianhacker simianhacker approved these changes

Assignees

@simianhacker simianhacker

Labels

bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Metrics UI] Manage jobs and View anomalies buttons not showing for Kubernetes Pods ML jobs

4 participants

@phillipb @elasticmachine @kibanamachine @simianhacker