Change plugin id for `triggers_actions_ui` to `triggersActionsUi` #78555

saravananselvamohan · 2020-09-26T14:46:46Z

Summary

Fix Change plugin id for triggers_actions_ui to triggersActionsUi #59191
Renamed triggers_actions_ui plugin id to triggersActionsUi to handle camelCase format warning
Link PR's Renamed id triggersActionsUi to handle warning #77284 Rename triggers_actions_ui plugin id to triggersActionsUi #77700
✔️Verified Signature Commits

kibanamachine · 2020-09-26T14:46:49Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elasticmachine · 2020-09-26T14:46:51Z

Pinging @elastic/uptime (Team:uptime)

elasticmachine · 2020-09-26T14:46:51Z

Pinging @elastic/apm-ui (Team:apm)

examples/alerting_example/public/components/create_alert.tsx

shahzad31 · 2020-09-28T11:56:46Z

Jenkins, test this

shahzad31

Uptime changes LGTM !!

YulNaumenko

LGTM

YulNaumenko · 2020-09-28T16:04:01Z

jenkins retest this please

flash1293 · 2020-09-28T16:48:04Z

@saravananselvamohan to make the build pass you have to run the docs generation script and commit the result:

ERROR: 'node scripts/build_plugin_list_docs' caused changes to the following files:

saravananselvamohan · 2020-09-29T03:15:49Z

@saravananselvamohan to make the build pass you have to run the docs generation script and commit the result:

ERROR: 'node scripts/build_plugin_list_docs' caused changes to the following files:

@flash1293. Thanks for the note. I checked for how to run the docs generation script in contributing guidelines. Could you brief the process, please

flash1293 · 2020-09-30T09:18:48Z

@saravananselvamohan You just have to run node scripts/build_plugin_list_docs in your terminal. This should edit some files which you have to commit. Also, it seems like in the meantime some conflicts came in, can you check them out?

simianhacker

LGTM

saravananselvamohan · 2020-10-03T14:05:28Z

@saravananselvamohan You just have to run node scripts/build_plugin_list_docs in your terminal. This should edit some files which you have to commit. Also, it seems like in the meantime some conflicts came in, can you check them out?

@flash1293. Added docs generation script

flash1293 · 2020-10-03T14:15:22Z

@saravananselvamohan thanks! There are also some conflicts with the current state of master branch in the elastic/kibana repository. You have to resolve them before the Pr becomes mergeable

YulNaumenko · 2020-10-05T16:47:26Z

@saravananselvamohan do you need a help with resolving conflicts? If you don't mind, I can resolve it and push to your branch.

saravananselvamohan · 2020-10-05T16:51:04Z

@saravananselvamohan do you need a help with resolving conflicts? If you don't mind, I can resolve it and push to your branch.

Yeah sure. Don't want to have changes pending for more time. Thanks for the help for the past few weeks

…ions_ui

YulNaumenko · 2020-10-05T17:31:18Z

jenkins retest this please

YulNaumenko · 2020-10-05T17:55:34Z

jenkins retest this please

YulNaumenko · 2020-10-05T19:41:11Z

jenkins retest this please

kibanamachine · 2020-10-05T21:16:02Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 9fd0d1c

Metrics [docs]

@kbn/optimizer bundle module count

id	before	after	diff
`triggers_actions_ui`	274	-	-274
`triggersActionsUi`	-	274	+274
total			-0

async chunks size

id	before	after	diff
`apm`	4.1MB	4.1MB	-16.0B
`infra`	3.8MB	3.8MB	-14.0B
`monitoring`	1.2MB	1.2MB	-6.0B
`securitySolution`	10.3MB	10.3MB	-22.0B
`triggers_actions_ui`	1.5MB	-	-1.5MB
`triggersActionsUi`	-	1.5MB	⚠️ +1.5MB
`uptime`	1.7MB	1.7MB	-24.0B
total			-220.0B

miscellaneous assets size

id	before	after	diff
`triggers_actions_ui`	27.7KB	-	-27.7KB
`triggersActionsUi`	-	27.7KB	+27.7KB
total			-0.0B

page load bundle size

id	before	after	diff
`apm`	46.3KB	46.3KB	-4.0B
`infra`	178.6KB	178.6KB	-12.0B
`monitoring`	247.7KB	247.7KB	-6.0B
`securitySolution`	587.1KB	587.1KB	-4.0B
`triggers_actions_ui`	148.0KB	-	-148.0KB
`triggersActionsUi`	-	148.0KB	+148.0KB
`uptime`	25.2KB	25.2KB	-8.0B
total			-54.0B

History

💔 Build #79773 failed da6c310
💔 Build #79757 failed 48ba40e
💔 Build #77535 failed a34f286
💔 Build #77515 failed a34f286
💔 Build #77349 failed a34f286

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…lastic#78555) * Rename triggers_actions_ui plugin id to triggersActionsUi * Rename triggers_actions_ui plugin id to triggersActionsUi * Removed disable linting line * ran docs generation script * Fixed type check issue * FIxed eslint error Co-authored-by: Yuliia Naumenko <yuliia.naumenko@elastic.com>

…78555) (#79575) * Rename triggers_actions_ui plugin id to triggersActionsUi * Rename triggers_actions_ui plugin id to triggersActionsUi * Removed disable linting line * ran docs generation script * Fixed type check issue * FIxed eslint error Co-authored-by: Yuliia Naumenko <yuliia.naumenko@elastic.com> Co-authored-by: Saravanan Selvamohan <43172875+saravananselvamohan@users.noreply.github.com>

saravananselvamohan added 2 commits September 26, 2020 17:24

Rename triggers_actions_ui plugin id to triggersActionsUi

f49ba92

Rename triggers_actions_ui plugin id to triggersActionsUi

65de99f

saravananselvamohan requested review from a team as code owners September 26, 2020 14:46

saravananselvamohan requested a review from a team September 26, 2020 14:46

saravananselvamohan requested a review from a team as a code owner September 26, 2020 14:46

botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Sep 26, 2020

kibanamachine added the 💝community label Sep 26, 2020

flash1293 reviewed Sep 26, 2020

View reviewed changes

examples/alerting_example/public/components/create_alert.tsx Outdated Show resolved Hide resolved

botelastic bot added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Sep 26, 2020

Removed disable linting line

a34f286

saravananselvamohan requested a review from flash1293 September 26, 2020 17:54

sorenlouv approved these changes Sep 26, 2020

View reviewed changes

shahzad31 added v7.10.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 28, 2020

shahzad31 approved these changes Sep 28, 2020

View reviewed changes

YulNaumenko approved these changes Sep 28, 2020

View reviewed changes

flash1293 self-assigned this Sep 30, 2020

simianhacker approved these changes Oct 1, 2020

View reviewed changes

ran docs generation script

3726d9c

Merge remote-tracking branch upstream/master into rename-triggers_act…

48ba40e

…ions_ui

YulNaumenko mentioned this pull request Oct 5, 2020

Rename triggers_actions_ui plugin id to triggersActionsUi #77700

Closed

7 tasks

Fixed type check issue

da6c310

FIxed eslint error

9fd0d1c

YulNaumenko merged commit 663175c into elastic:master Oct 5, 2020

YulNaumenko mentioned this pull request Oct 5, 2020

[7.x] Change plugin id for triggers_actions_ui to triggersActionsUi (#78555) #79575

Merged

Change plugin id for triggers_actions_ui to triggersActionsUi #78555

Change plugin id for triggers_actions_ui to triggersActionsUi #78555

Uh oh!

Conversation

saravananselvamohan commented Sep 26, 2020

Summary

Uh oh!

kibanamachine commented Sep 26, 2020

Uh oh!

elasticmachine commented Sep 26, 2020

Uh oh!

elasticmachine commented Sep 26, 2020

Uh oh!

Uh oh!

shahzad31 commented Sep 28, 2020

Uh oh!

shahzad31 left a comment

Choose a reason for hiding this comment

Uh oh!

YulNaumenko left a comment

Choose a reason for hiding this comment

Uh oh!

YulNaumenko commented Sep 28, 2020

Uh oh!

flash1293 commented Sep 28, 2020

Uh oh!

saravananselvamohan commented Sep 29, 2020

Uh oh!

flash1293 commented Sep 30, 2020

Uh oh!

simianhacker left a comment

Choose a reason for hiding this comment

Uh oh!

saravananselvamohan commented Oct 3, 2020

Uh oh!

flash1293 commented Oct 3, 2020

Uh oh!

YulNaumenko commented Oct 5, 2020

Uh oh!

saravananselvamohan commented Oct 5, 2020

Uh oh!

YulNaumenko commented Oct 5, 2020

Uh oh!

YulNaumenko commented Oct 5, 2020

Uh oh!

YulNaumenko commented Oct 5, 2020

Uh oh!

kibanamachine commented Oct 5, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

async chunks size

miscellaneous assets size

page load bundle size

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Change plugin id for `triggers_actions_ui` to `triggersActionsUi` #78555

Change plugin id for `triggers_actions_ui` to `triggersActionsUi` #78555