Change plugin id for triggers_actions_ui to triggersActionsUi (#78555) (#79575)

YulNaumenko · saravananselvamohan · web-flow · commit ac149aa0ed1f · 2020-10-05T16:34:19.000-07:00
* Rename triggers_actions_ui plugin id to triggersActionsUi

* Rename triggers_actions_ui plugin id to triggersActionsUi

* Removed disable linting line

* ran docs generation script

* Fixed type check issue

* FIxed eslint error

Co-authored-by: Yuliia Naumenko &lt;yuliia.naumenko@elastic.com&gt;

Co-authored-by: Saravanan Selvamohan &lt;43172875+saravananselvamohan@users.noreply.github.com&gt;
diff --git a/docs/developer/plugin-list.asciidoc b/docs/developer/plugin-list.asciidoc
@@ -478,7 +478,7 @@ using the CURL scripts in the scripts folder.
 |WARNING: Missing README.
 
 
-|{kib-repo}blob/{branch}/x-pack/plugins/triggers_actions_ui/README.md[triggers_actions_ui]
+|{kib-repo}blob/{branch}/x-pack/plugins/triggers_actions_ui/README.md[triggersActionsUi]
 |The Kibana alerts and actions UI plugin provides a user interface for managing alerts and actions.
 As a developer you can reuse and extend built-in alerts and actions UI functionality:
 
diff --git a/x-pack/examples/alerting_example/kibana.json b/x-pack/examples/alerting_example/kibana.json
@@ -4,6 +4,6 @@
   "kibanaVersion": "kibana",
   "server": true,
   "ui": true,
-  "requiredPlugins": ["triggers_actions_ui", "charts", "data", "alerts", "actions", "features", "developerExamples"],
+  "requiredPlugins": ["triggersActionsUi", "charts", "data", "alerts", "actions", "features", "developerExamples"],
   "optionalPlugins": []
 }
diff --git a/x-pack/examples/alerting_example/public/application.tsx b/x-pack/examples/alerting_example/public/application.tsx
@@ -30,7 +30,7 @@ export interface AlertingExampleComponentParams {
   application: CoreStart['application'];
   http: CoreStart['http'];
   basename: string;
-  triggers_actions_ui: TriggersAndActionsUIPublicPluginStart;
+  triggersActionsUi: TriggersAndActionsUIPublicPluginStart;
   data: DataPublicPluginStart;
   charts: ChartsPluginStart;
   uiSettings: IUiSettingsClient;
diff --git a/x-pack/examples/alerting_example/public/components/create_alert.tsx b/x-pack/examples/alerting_example/public/components/create_alert.tsx
@@ -14,8 +14,7 @@ import { ALERTING_EXAMPLE_APP_ID } from '../../common/constants';
 
 export const CreateAlert = ({
   http,
-  // eslint-disable-next-line @typescript-eslint/naming-convention
-  triggers_actions_ui,
+  triggersActionsUi,
   charts,
   uiSettings,
   docLinks,
@@ -39,8 +38,8 @@ export const CreateAlert = ({
         <AlertsContextProvider
           value={{
             http,
-            actionTypeRegistry: triggers_actions_ui.actionTypeRegistry,
-            alertTypeRegistry: triggers_actions_ui.alertTypeRegistry,
+            actionTypeRegistry: triggersActionsUi.actionTypeRegistry,
+            alertTypeRegistry: triggersActionsUi.alertTypeRegistry,
             toastNotifications,
             uiSettings,
             docLinks,
diff --git a/x-pack/examples/alerting_example/public/plugin.tsx b/x-pack/examples/alerting_example/public/plugin.tsx
@@ -24,22 +24,21 @@ export type Start = void;
 
 export interface AlertingExamplePublicSetupDeps {
   alerts: AlertingSetup;
-  triggers_actions_ui: TriggersAndActionsUIPublicPluginSetup;
+  triggersActionsUi: TriggersAndActionsUIPublicPluginSetup;
   developerExamples: DeveloperExamplesSetup;
 }
 
 export interface AlertingExamplePublicStartDeps {
   alerts: AlertingSetup;
-  triggers_actions_ui: TriggersAndActionsUIPublicPluginSetup;
+  triggersActionsUi: TriggersAndActionsUIPublicPluginSetup;
   charts: ChartsPluginStart;
   data: DataPublicPluginStart;
 }
 
 export class AlertingExamplePlugin implements Plugin<Setup, Start, AlertingExamplePublicSetupDeps> {
   public setup(
     core: CoreSetup<AlertingExamplePublicStartDeps, Start>,
-    // eslint-disable-next-line @typescript-eslint/naming-convention
-    { alerts, triggers_actions_ui, developerExamples }: AlertingExamplePublicSetupDeps
+    { alerts, triggersActionsUi, developerExamples }: AlertingExamplePublicSetupDeps
   ) {
     core.application.register({
       id: 'AlertingExample',
@@ -52,8 +51,8 @@ export class AlertingExamplePlugin implements Plugin<Setup, Start, AlertingExamp
       },
     });
 
-    triggers_actions_ui.alertTypeRegistry.register(getAlwaysFiringAlertType());
-    triggers_actions_ui.alertTypeRegistry.register(getPeopleInSpaceAlertType());
+    triggersActionsUi.alertTypeRegistry.register(getAlwaysFiringAlertType());
+    triggersActionsUi.alertTypeRegistry.register(getPeopleInSpaceAlertType());
 
     registerNavigation(alerts);
 
diff --git a/x-pack/plugins/apm/kibana.json b/x-pack/plugins/apm/kibana.json
@@ -7,7 +7,7 @@
     "apmOss",
     "data",
     "licensing",
-    "triggers_actions_ui",
+    "triggersActionsUi",
     "embeddable"
   ],
   "optionalPlugins": [
diff --git a/x-pack/plugins/apm/public/application/application.test.tsx b/x-pack/plugins/apm/public/application/application.test.tsx
@@ -40,7 +40,7 @@ describe('renderApp', () => {
     const { core, config } = mockApmPluginContextValue;
     const plugins = {
       licensing: { license$: new Observable() },
-      triggers_actions_ui: { actionTypeRegistry: {}, alertTypeRegistry: {} },
+      triggersActionsUi: { actionTypeRegistry: {}, alertTypeRegistry: {} },
       usageCollection: { reportUiStats: () => {} },
     };
     const params = {
diff --git a/x-pack/plugins/apm/public/application/index.tsx b/x-pack/plugins/apm/public/application/index.tsx
@@ -90,8 +90,8 @@ export function ApmAppRoot({
             docLinks: core.docLinks,
             capabilities: core.application.capabilities,
             toastNotifications: core.notifications.toasts,
-            actionTypeRegistry: plugins.triggers_actions_ui.actionTypeRegistry,
-            alertTypeRegistry: plugins.triggers_actions_ui.alertTypeRegistry,
+            actionTypeRegistry: plugins.triggersActionsUi.actionTypeRegistry,
+            alertTypeRegistry: plugins.triggersActionsUi.alertTypeRegistry,
           }}
         >
           <KibanaContextProvider services={{ ...core, ...plugins }}>
diff --git a/x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts b/x-pack/plugins/apm/public/components/alerting/register_apm_alerts.ts
@@ -10,7 +10,7 @@ import { AlertType } from '../../../common/alert_types';
 import { ApmPluginStartDeps } from '../../plugin';
 
 export function registerApmAlerts(
-  alertTypeRegistry: ApmPluginStartDeps['triggers_actions_ui']['alertTypeRegistry']
+  alertTypeRegistry: ApmPluginStartDeps['triggersActionsUi']['alertTypeRegistry']
 ) {
   alertTypeRegistry.register({
     id: AlertType.ErrorCount,
diff --git a/x-pack/plugins/apm/public/plugin.ts b/x-pack/plugins/apm/public/plugin.ts
@@ -48,7 +48,7 @@ export interface ApmPluginSetupDeps {
   features: FeaturesPluginSetup;
   home?: HomePublicPluginSetup;
   licensing: LicensingPluginSetup;
-  triggers_actions_ui: TriggersAndActionsUIPublicPluginSetup;
+  triggersActionsUi: TriggersAndActionsUIPublicPluginSetup;
   observability?: ObservabilityPluginSetup;
 }
 
@@ -58,7 +58,7 @@ export interface ApmPluginStartDeps {
   data: DataPublicPluginStart;
   home: void;
   licensing: void;
-  triggers_actions_ui: TriggersAndActionsUIPublicPluginStart;
+  triggersActionsUi: TriggersAndActionsUIPublicPluginStart;
   embeddable: EmbeddableStart;
 }
 
@@ -148,6 +148,6 @@ export class ApmPlugin implements Plugin<ApmPluginSetup, ApmPluginStart> {
   }
   public start(core: CoreStart, plugins: ApmPluginStartDeps) {
     toggleAppLinkInNav(core, this.initializerContext.config.get());
-    registerApmAlerts(plugins.triggers_actions_ui.alertTypeRegistry);
+    registerApmAlerts(plugins.triggersActionsUi.alertTypeRegistry);
   }
 }
diff --git a/x-pack/plugins/infra/kibana.json b/x-pack/plugins/infra/kibana.json
@@ -11,7 +11,7 @@
     "dataEnhanced",
     "visTypeTimeseries",
     "alerts",
-    "triggers_actions_ui"
+    "triggersActionsUi"
   ],
   "optionalPlugins": ["ml", "observability", "home"],
   "server": true,
diff --git a/x-pack/plugins/infra/public/apps/logs_app.tsx b/x-pack/plugins/infra/public/apps/logs_app.tsx
@@ -51,7 +51,7 @@ const LogsApp: React.FC<{
     <CoreProviders core={core} plugins={plugins}>
       <CommonInfraProviders
         apolloClient={apolloClient}
-        triggersActionsUI={plugins.triggers_actions_ui}
+        triggersActionsUI={plugins.triggersActionsUi}
       >
         <Router history={history}>
           <Switch>
diff --git a/x-pack/plugins/infra/public/apps/metrics_app.tsx b/x-pack/plugins/infra/public/apps/metrics_app.tsx
@@ -53,7 +53,7 @@ const MetricsApp: React.FC<{
     <CoreProviders core={core} plugins={plugins}>
       <CommonInfraProviders
         apolloClient={apolloClient}
-        triggersActionsUI={plugins.triggers_actions_ui}
+        triggersActionsUI={plugins.triggersActionsUi}
       >
         <Router history={history}>
           <Switch>
diff --git a/x-pack/plugins/infra/public/plugin.ts b/x-pack/plugins/infra/public/plugin.ts
@@ -28,9 +28,9 @@ export class Plugin implements InfraClientPluginClass {
       registerFeatures(pluginsSetup.home);
     }
 
-    pluginsSetup.triggers_actions_ui.alertTypeRegistry.register(createInventoryMetricAlertType());
-    pluginsSetup.triggers_actions_ui.alertTypeRegistry.register(getLogsAlertType());
-    pluginsSetup.triggers_actions_ui.alertTypeRegistry.register(createMetricThresholdAlertType());
+    pluginsSetup.triggersActionsUi.alertTypeRegistry.register(createInventoryMetricAlertType());
+    pluginsSetup.triggersActionsUi.alertTypeRegistry.register(getLogsAlertType());
+    pluginsSetup.triggersActionsUi.alertTypeRegistry.register(createMetricThresholdAlertType());
 
     if (pluginsSetup.observability) {
       pluginsSetup.observability.dashboard.register({
diff --git a/x-pack/plugins/infra/public/types.ts b/x-pack/plugins/infra/public/types.ts
@@ -27,7 +27,7 @@ export interface InfraClientSetupDeps {
   dataEnhanced: DataEnhancedSetup;
   home?: HomePublicPluginSetup;
   observability: ObservabilityPluginSetup;
-  triggers_actions_ui: TriggersAndActionsUIPublicPluginSetup;
+  triggersActionsUi: TriggersAndActionsUIPublicPluginSetup;
   usageCollection: UsageCollectionSetup;
 }
 
@@ -36,7 +36,7 @@ export interface InfraClientStartDeps {
   dataEnhanced: DataEnhancedStart;
   observability: ObservabilityPluginStart;
   spaces: SpacesPluginStart;
-  triggers_actions_ui: TriggersAndActionsUIPublicPluginSetup;
+  triggersActionsUi: TriggersAndActionsUIPublicPluginSetup;
   usageCollection: UsageCollectionStart;
 }
 
diff --git a/x-pack/plugins/monitoring/kibana.json b/x-pack/plugins/monitoring/kibana.json
@@ -9,7 +9,7 @@
     "data",
     "navigation",
     "kibanaLegacy",
-    "triggers_actions_ui",
+    "triggersActionsUi",
     "alerts",
     "actions",
     "encryptedSavedObjects",
diff --git a/x-pack/plugins/monitoring/public/plugin.ts b/x-pack/plugins/monitoring/public/plugin.ts
@@ -31,7 +31,7 @@ import { createMemoryUsageAlertType } from './alerts/memory_usage_alert';
 interface MonitoringSetupPluginDependencies {
   home?: HomePublicPluginSetup;
   cloud?: { isCloudEnabled: boolean };
-  triggers_actions_ui: TriggersAndActionsUIPublicPluginSetup;
+  triggersActionsUi: TriggersAndActionsUIPublicPluginSetup;
   usageCollection: UsageCollectionSetup;
 }
 
@@ -73,7 +73,7 @@ export class MonitoringPlugin
       });
     }
 
-    const { alertTypeRegistry } = plugins.triggers_actions_ui;
+    const { alertTypeRegistry } = plugins.triggersActionsUi;
     alertTypeRegistry.register(createCpuUsageAlertType());
     alertTypeRegistry.register(createDiskUsageAlertType());
     alertTypeRegistry.register(createMemoryUsageAlertType());
@@ -102,7 +102,7 @@ export class MonitoringPlugin
           isCloud: Boolean(plugins.cloud?.isCloudEnabled),
           pluginInitializerContext: this.initializerContext,
           externalConfig: this.getExternalConfig(),
-          triggersActionsUi: plugins.triggers_actions_ui,
+          triggersActionsUi: plugins.triggersActionsUi,
           usageCollection: plugins.usageCollection,
         };
 
diff --git a/x-pack/plugins/security_solution/kibana.json b/x-pack/plugins/security_solution/kibana.json
@@ -15,7 +15,7 @@
     "inspector",
     "licensing",
     "maps",
-    "triggers_actions_ui",
+    "triggersActionsUi",
     "uiActions"
   ],
   "optionalPlugins": [
diff --git a/x-pack/plugins/security_solution/public/cases/components/configure_cases/index.test.tsx b/x-pack/plugins/security_solution/public/cases/components/configure_cases/index.test.tsx
@@ -38,7 +38,7 @@ const useGetUrlSearchMock = useGetUrlSearch as jest.Mock;
 
 describe('ConfigureCases', () => {
   beforeEach(() => {
-    useKibanaMock().services.triggers_actions_ui = ({
+    useKibanaMock().services.triggersActionsUi = ({
       actionTypeRegistry: actionTypeRegistryMock.create(),
     } as unknown) as TriggersAndActionsUIPublicPluginStart;
   });
@@ -62,17 +62,17 @@ describe('ConfigureCases', () => {
     });
 
     test('it renders the ActionsConnectorsContextProvider', () => {
-      // Components from triggers_actions_ui do not have a data-test-subj
+      // Components from triggersActionsUi  do not have a data-test-subj
       expect(wrapper.find(ActionsConnectorsContextProvider).exists()).toBeTruthy();
     });
 
     test('it renders the ConnectorAddFlyout', () => {
-      // Components from triggers_actions_ui do not have a data-test-subj
+      // Components from triggersActionsUi  do not have a data-test-subj
       expect(wrapper.find(ConnectorAddFlyout).exists()).toBeTruthy();
     });
 
     test('it does NOT render the ConnectorEditFlyout', () => {
-      // Components from triggers_actions_ui do not have a data-test-subj
+      // Components from triggersActionsUi  do not have a data-test-subj
       expect(wrapper.find(ConnectorEditFlyout).exists()).toBeFalsy();
     });
 
diff --git a/x-pack/plugins/security_solution/public/cases/components/configure_cases/index.tsx b/x-pack/plugins/security_solution/public/cases/components/configure_cases/index.tsx
@@ -55,8 +55,7 @@ interface ConfigureCasesComponentProps {
 }
 
 const ConfigureCasesComponent: React.FC<ConfigureCasesComponentProps> = ({ userCanCrud }) => {
-  // eslint-disable-next-line @typescript-eslint/naming-convention
-  const { http, triggers_actions_ui, notifications, application, docLinks } = useKibana().services;
+  const { http, triggersActionsUi, notifications, application, docLinks } = useKibana().services;
 
   const [connectorIsValid, setConnectorIsValid] = useState(true);
   const [addFlyoutVisible, setAddFlyoutVisibility] = useState<boolean>(false);
@@ -197,7 +196,7 @@ const ConfigureCasesComponent: React.FC<ConfigureCasesComponentProps> = ({ userC
       <ActionsConnectorsContextProvider
         value={{
           http,
-          actionTypeRegistry: triggers_actions_ui.actionTypeRegistry,
+          actionTypeRegistry: triggersActionsUi.actionTypeRegistry,
           toastNotifications: notifications.toasts,
           capabilities: application.capabilities,
           reloadConnectors,
diff --git a/x-pack/plugins/security_solution/public/detections/components/rules/rule_actions_field/index.test.tsx b/x-pack/plugins/security_solution/public/detections/components/rules/rule_actions_field/index.test.tsx
@@ -17,7 +17,7 @@ describe('RuleActionsField', () => {
   it('should not render ActionForm if no actions are supported', () => {
     (useKibana as jest.Mock).mockReturnValue({
       services: {
-        triggers_actions_ui: {
+        triggersActionsUi: {
           actionTypeRegistry: {},
         },
         application: {
diff --git a/x-pack/plugins/security_solution/public/detections/components/rules/rule_actions_field/index.tsx b/x-pack/plugins/security_solution/public/detections/components/rules/rule_actions_field/index.tsx
@@ -41,7 +41,7 @@ export const RuleActionsField: ThrottleSelectField = ({ field, messageVariables
   const { isSubmitted, isSubmitting, isValid } = form;
   const {
     http,
-    triggers_actions_ui: { actionTypeRegistry },
+    triggersActionsUi: { actionTypeRegistry },
     notifications,
     docLinks,
     application: { capabilities },
diff --git a/x-pack/plugins/security_solution/public/detections/components/rules/step_rule_actions/index.test.tsx b/x-pack/plugins/security_solution/public/detections/components/rules/step_rule_actions/index.test.tsx
@@ -23,7 +23,7 @@ jest.mock('../../../../common/lib/kibana', () => ({
           },
         },
       },
-      triggers_actions_ui: {
+      triggersActionsUi: {
         actionTypeRegistry: jest.fn(),
       },
     },
diff --git a/x-pack/plugins/security_solution/public/detections/components/rules/step_rule_actions/index.tsx b/x-pack/plugins/security_solution/public/detections/components/rules/step_rule_actions/index.tsx
@@ -72,7 +72,7 @@ const StepRuleActionsComponent: FC<StepRuleActionsProps> = ({
   const {
     services: {
       application,
-      triggers_actions_ui: { actionTypeRegistry },
+      triggersActionsUi: { actionTypeRegistry },
     },
   } = useKibana();
   const kibanaAbsoluteUrl = useMemo(
diff --git a/x-pack/plugins/security_solution/public/types.ts b/x-pack/plugins/security_solution/public/types.ts
@@ -28,7 +28,7 @@ import { MlPluginSetup, MlPluginStart } from '../../ml/public';
 export interface SetupPlugins {
   home?: HomePublicPluginSetup;
   security: SecurityPluginSetup;
-  triggers_actions_ui: TriggersActionsSetup;
+  triggersActionsUi: TriggersActionsSetup;
   usageCollection?: UsageCollectionSetup;
   ml?: MlPluginSetup;
 }
@@ -40,7 +40,7 @@ export interface StartPlugins {
   ingestManager?: IngestManagerStart;
   lists?: ListsPluginStart;
   newsfeed?: NewsfeedStart;
-  triggers_actions_ui: TriggersActionsStart;
+  triggersActionsUi: TriggersActionsStart;
   uiActions: UiActionsStart;
   ml?: MlPluginStart;
 }
diff --git a/x-pack/plugins/triggers_actions_ui/README.md b/x-pack/plugins/triggers_actions_ui/README.md
diff --git a/x-pack/plugins/triggers_actions_ui/kibana.json b/x-pack/plugins/triggers_actions_ui/kibana.json
diff --git a/x-pack/plugins/triggers_actions_ui/public/application/constants/plugin.ts b/x-pack/plugins/triggers_actions_ui/public/application/constants/plugin.ts
diff --git a/x-pack/plugins/uptime/kibana.json b/x-pack/plugins/uptime/kibana.json
diff --git a/x-pack/plugins/uptime/public/apps/plugin.ts b/x-pack/plugins/uptime/public/apps/plugin.ts
diff --git a/x-pack/plugins/uptime/public/components/overview/alerts/uptime_alerts_context_provider.tsx b/x-pack/plugins/uptime/public/components/overview/alerts/uptime_alerts_context_provider.tsx
diff --git a/x-pack/plugins/uptime/public/components/settings/add_connector_flyout.tsx b/x-pack/plugins/uptime/public/components/settings/add_connector_flyout.tsx
diff --git a/x-pack/plugins/uptime/public/components/settings/alert_defaults_form.tsx b/x-pack/plugins/uptime/public/components/settings/alert_defaults_form.tsx
diff --git a/x-pack/test/functional_with_es_ssl/fixtures/plugins/alerts/kibana.json b/x-pack/test/functional_with_es_ssl/fixtures/plugins/alerts/kibana.json
diff --git a/x-pack/test/functional_with_es_ssl/fixtures/plugins/alerts/public/plugin.ts b/x-pack/test/functional_with_es_ssl/fixtures/plugins/alerts/public/plugin.ts

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,6 @@`
`4`	`4`	`"kibanaVersion": "kibana",`
`5`	`5`	`"server": true,`
`6`	`6`	`"ui": true,`
`7`		`- "requiredPlugins": ["triggers_actions_ui", "charts", "data", "alerts", "actions", "features", "developerExamples"],`
	`7`	`+ "requiredPlugins": ["triggersActionsUi", "charts", "data", "alerts", "actions", "features", "developerExamples"],`
`8`	`8`	`"optionalPlugins": []`
`9`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ export interface ApmPluginSetupDeps {`
`48`	`48`	`features: FeaturesPluginSetup;`
`49`	`49`	`home?: HomePublicPluginSetup;`
`50`	`50`	`licensing: LicensingPluginSetup;`
`51`		`- triggers_actions_ui: TriggersAndActionsUIPublicPluginSetup;`
	`51`	`+ triggersActionsUi: TriggersAndActionsUIPublicPluginSetup;`
`52`	`52`	`observability?: ObservabilityPluginSetup;`
`53`	`53`	`}`
`54`	`54`
`@@ -58,7 +58,7 @@ export interface ApmPluginStartDeps {`
`58`	`58`	`data: DataPublicPluginStart;`
`59`	`59`	`home: void;`
`60`	`60`	`licensing: void;`
`61`		`- triggers_actions_ui: TriggersAndActionsUIPublicPluginStart;`
	`61`	`+ triggersActionsUi: TriggersAndActionsUIPublicPluginStart;`
`62`	`62`	`embeddable: EmbeddableStart;`
`63`	`63`	`}`
`64`	`64`
`@@ -148,6 +148,6 @@ export class ApmPlugin implements Plugin<ApmPluginSetup, ApmPluginStart> {`
`148`	`148`	`}`
`149`	`149`	`public start(core: CoreStart, plugins: ApmPluginStartDeps) {`
`150`	`150`	`toggleAppLinkInNav(core, this.initializerContext.config.get());`
`151`		`- registerApmAlerts(plugins.triggers_actions_ui.alertTypeRegistry);`
	`151`	`+ registerApmAlerts(plugins.triggersActionsUi.alertTypeRegistry);`
`152`	`152`	`}`
`153`	`153`	`}`