Move StubIndexPattern to data plugin and convert to TS. #78518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeelmers
added
review
chore
Feature:Data Views
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Member
Author
|
@elasticmachine merge upstream |
mattkime
approved these changes
Sep 26, 2020
kertal
approved these changes
Sep 28, 2020
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, KibanaApp Codeowner review, just tests were adapted, didn't checkout
Member
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
lukeelmers
added a commit
to lukeelmers/kibana
that referenced
this pull request
Sep 28, 2020
# Conflicts: # src/test_utils/public/stub_index_pattern.js
lukeelmers
added a commit
that referenced
this pull request
Sep 28, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 28, 2020
* master: Fix APM lodash imports (elastic#78438) Add deprecated message to tile_map and region_map visualizations. (elastic#77683) Fix Lens smokescreen flaky tests (elastic#78566) updated discover with alt text (elastic#77660) Fix types (elastic#78619) Update tutorial-visualizing.asciidoc (elastic#76977) Update tutorial-discovering.asciidoc (elastic#76976) [Search] Error notification alignment (elastic#77788) Update tutorial-define-index.asciidoc (elastic#76975) [Lens] Fieldless operations (elastic#78080) [Usage Collection] [schema] Explicit "array" definition (elastic#78141) Update tutorial-define-index.asciidoc (elastic#76973) Fix --no-basepath references in doc (elastic#78570) Move StubIndexPattern to data plugin and convert to TS. (elastic#78518) Index pattern class - remove unused methods (elastic#78538) [Security Solution] [ALL] Eliminates all console.error and console.warn from Jest output (elastic#78523) [Actions] avoids setting a default dedupKey on PagerDuty (elastic#77773) First stab at developer-focussed saved objects docs (elastic#71430) remove unnecessary config validations (elastic#78527)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #76355
src/test_utilspreviously had a dependency on the data plugin (viaStubIndexPattern). This PR relocatesStubIndexPatternto the data plugin to remove this dependency.I've also converted it to TypeScript and created a
getStubIndexPatternfactory function to facilitate easier typing.Ideally we would get rid of
StubIndexPatternaltogether, but this would require some work on the data plugin's jest mocks to provide a more detailed mock index pattern. I've created an issue to address this here, but for the time being am simply moving the existing stub over to get rid of the dependency.cc @restrry