add cGroupOverrides to the legacy config #77180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
joshdover
approved these changes
Sep 10, 2020
pgayvallet
commented
Sep 10, 2020
Comment on lines
+21
to
24
| ops.cGroupOverrides.cpuPath | ||
| ops.cGroupOverrides.cpuAcctPath | ||
| cpu.cgroup.path.override | ||
| cpuacct.cgroup.path.override |
Contributor
Author
There was a problem hiding this comment.
I added the new ones, but also kept the deprecated name to avoid a breaking change
joshdover
reviewed
Sep 10, 2020
src/legacy/server/config/schema.js
Outdated
|
|
||
| ops: Joi.object({ | ||
| interval: Joi.number().default(5000), | ||
| cGroupOverrides: HANDLED_IN_NEW_PLATFORM, |
Contributor
There was a problem hiding this comment.
We can probably remove old the schema up on lines 52-66 now?
Contributor
Author
There was a problem hiding this comment.
Right. I had to add the explicit definition in ops though, as
kibana/src/legacy/server/status/lib/metrics.js
Lines 119 to 120 in c528f24
is throwing error when trying to access the property if the schema is undefined (which make sense, HANDLED_IN_NEW_PLATFORM is only meant to be used for config values that are ONLY used in KP)
tylersmalley
approved these changes
Sep 10, 2020
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Sep 11, 2020
* add cGroupOverrides to the legacy config * update missing usages * remove old cpu/cgroup schema
pgayvallet
added a commit
that referenced
this pull request
Sep 11, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 14, 2020
…s-for-710 * 'master' of github.com:elastic/kibana: (65 commits) Separate url forwarding logic and legacy services (elastic#76892) Bump yargs-parser to v13.1.2+ (elastic#77009) [Ingest Manager] Shared Fleet agent policy action (elastic#76013) [Search] Re-add support for aborting when a connection is closed (elastic#76470) [Search] Remove long-running query pop-up (elastic#75385) [Monitoring] Fix UI error when alerting is not available (elastic#77179) do not log plugin id format warning in dist mode (elastic#77134) [ML] Improving client side error handling (elastic#76743) [Alerting][Connectors] Refactor IBM Resilient: Generic Implementation (phase one) (elastic#74357) [Docs] some basic searchsource api docs (elastic#77038) add cGroupOverrides to the legacy config (elastic#77180) Change saved object bulkUpdate to work across multiple namespaces (elastic#75478) [Security Solution][Resolver] Replace Selectable popover with badges (elastic#76997) Removing ml-state index from archive (elastic#77143) [Security Solution] Add unit tests for histograms (elastic#77081) [Lens] Filters aggregation (elastic#75635) [Enterprise Search] Update WS Overview logic to use new config data (elastic#77122) Cleanup type output before building new types (elastic#77211) [Security Solution] Use safe type in resolver backend (elastic#76969) Use proper lodash syntax (elastic#77105) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/node_allocation.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up of #76730.
Add
cGroupOverridesto the legacy config to avoid config validation failures when using it, and updatekibana-dockerscript to use the new config keys