Skip to content

Unskip Lens OriginatingApp Breadcrumb test #75714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2020
Merged

Unskip Lens OriginatingApp Breadcrumb test #75714

merged 2 commits into from
Aug 24, 2020

Conversation

@ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Aug 22, 2020

Summary

Closes #75694

updates test added in #75470 to work properly with the new document format from #74523.

For maintainers

@ThomThomson ThomThomson added release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 v7.10.0 labels Aug 22, 2020
@ThomThomson ThomThomson requested a review from a team August 22, 2020 01:57
@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 22, 2020

Pinging @elastic/kibana-app (Team:KibanaApp)

@ThomThomson
Copy link
Contributor Author

ThomThomson commented Aug 24, 2020

@elasticmachine merge upstream

kertal
kertal approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DaaaaaaadauLGTM! Codeowner review since the mighty Jenkins already tested

wylieconlon
wylieconlon approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this was a recent change to the Lens state.

Please remove the release note- this isn't something that is being released

@ThomThomson ThomThomson added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Aug 24, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 24, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit f495b7d into elastic:master Aug 24, 2020
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Aug 24, 2020
@ThomThomson @elasticmachine
Updated and unskipped lens breadcrumb test after elastic#74523 (elast…
5e12a5c 
…ic#75714)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@ThomThomson ThomThomson mentioned this pull request Aug 24, 2020
Merged
ThomThomson added a commit that referenced this pull request Aug 24, 2020
@ThomThomson
Updated and unskipped lens breadcrumb test after #74523 (#75714) (#75792
f4b5c30 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kertal kertal kertal approved these changes

+1 more reviewer

@wylieconlon wylieconlon wylieconlon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failing test: X-Pack Jest Tests.x-pack/plugins/lens/public/app_plugin - Lens App sets originatingApp breadcrumb when the document title changes

5 participants

@ThomThomson @elasticmachine @kibanamachine @kertal @wylieconlon