Skip to content

[build/sysv] fix missing env variable rename #73977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2020
Merged

[build/sysv] fix missing env variable rename #73977

merged 1 commit into from
Jul 31, 2020

Conversation

@jbudz
Copy link
Member

@jbudz jbudz commented Jul 31, 2020 •
edited
Loading

Previously (unreleased/not documented) we had two sets of prefixes for environment variables - KBN and KIBANA. These were refactored to be consistent, and my find and replace missed this one because it matches a (default? or gitignore?) exclusion of /build/ in my text editor.

Testing - this only effects sysv. prior snapshots would fallback to a local config folder and it wouldn't exist. It should start now

/etc/init.d/kibana start

Closes #73743

@jbudz jbudz added Team:Operations Kibana-Operations Team v8.0.0 v7.9.0 labels Jul 31, 2020
@jbudz jbudz requested a review from a team as a code owner July 31, 2020 16:36
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 31, 2020

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz jbudz added the release_note:skip Skip the PR/issue when compiling release notes label Jul 31, 2020
@LeeDr
Copy link

LeeDr commented Jul 31, 2020

Testing - this only effects sysv.

I'm confused by this statement. I'm having this failure on CentOS 7 which has systemd.
I'd have to start up the Oracle Linux system again to check it.

@tylersmalley
Copy link
Contributor

tylersmalley commented Jul 31, 2020

@LeeDr are you using the init script?

@tylersmalley
Copy link
Contributor

tylersmalley commented Jul 31, 2020

@LeeDr here are the builds for testing: https://drive.google.com/drive/folders/1e7QNx1zkKL5j-gG3MGzEday8t83I0XsN?usp=sharing

@jbudz
Copy link
Member Author

jbudz commented Jul 31, 2020

Some linux distributions (e.g. fedora) have both but don't have systemd symlinked to 'service' yet.

LeeDr
LeeDr approved these changes Jul 31, 2020
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I only tested the rpm artifact on CentOS7 and it was able to start successfully

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 31, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit d9efd26 into elastic:master Jul 31, 2020
jbudz added a commit that referenced this pull request Jul 31, 2020
@jbudz
[build/sysv] fix missing env variable rename (#73977)
c5a5840
jbudz added a commit that referenced this pull request Jul 31, 2020
@jbudz
[build/sysv] fix missing env variable rename (#73977)
892bde3
@jbudz
Copy link
Member Author

jbudz commented Jul 31, 2020

7.x: c5a5840
7.9.0: 892bde3

@jbudz jbudz added the v7.10.0 label Jul 31, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 2, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
dffcdf9 
* master: (39 commits)
  [Canvas][tech-debt] Rename __examples__ to __stories__ (elastic#73853)
  [Canvas] Storybook Redux Addon (elastic#73227)
  Use "Apply_filter_trigger" in "explore underlying data" action (elastic#71445)
  [maps] convert top nav config to TS (elastic#73851)
  [maps] fix fit to bounds for ES document layers with joins (elastic#73985)
  [Canvas][tech-debt] Refactor Toolbar (completes Kill Recompose.pure) (elastic#73309)
  [CI] In-progress Slack notifications (elastic#74012)
  [SIEM][Detection Engine] Fixes tags to accept characters such as AND, OR, (, ), ", * (elastic#74003)
  [SECURITY_SOLUTION][ENDPOINT] Fix host list Configuration Status cell link loosing list page/size state (elastic#73989)
  Tweak injected metadata (elastic#73990)
  Closes elastic#73998 by using `canAccessML` in the ML capabilities API to (elastic#73999)
  [SIEM] Fixes toaster errors when siemDefault index is an empty or empty spaces (elastic#73991)
  [Security Solution] Fix timeline pin event callback (elastic#73981)
  [Security Solution] Fix unexpected redirect (elastic#73969)
  [Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern (elastic#73986)
  [APM] docs: Update machine learning integration (elastic#73597)
  [Ingest Manager] Fix limited concurrency helper (elastic#73976)
  [build/sysv] fix missing env variable rename (elastic#73977)
  Fix a typo. (elastic#73948)
  [Ingest Manager] Revert fleet config concurrency rollout to rate limit (elastic#73940)
  ...
@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 3, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 73977 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 3, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@LeeDr LeeDr LeeDr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.9.0 v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't start kibana from rpm package install on oraclelinux-7

5 participants

@jbudz @elasticmachine @LeeDr @tylersmalley @kibanamachine