Skip to content

[Canvas][tech-debt] Rename __examples__ to __stories__ #73853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 1, 2020
Merged

[Canvas][tech-debt] Rename __examples__ to __stories__ #73853

merged 12 commits into from
Aug 1, 2020

Conversation

@clintandrewhall
Copy link
Contributor

@clintandrewhall clintandrewhall commented Jul 30, 2020

Summary

As titled. Low-hanging fruit for tech-debt summit.

@clintandrewhall clintandrewhall added review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// loe:small Small Level of Effort technical debt Improvement of the software architecture and operational architecture v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. v7.10.0 labels Jul 30, 2020
@clintandrewhall clintandrewhall requested a review from a team as a code owner July 30, 2020 18:00
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 30, 2020

Pinging @elastic/kibana-canvas (Team:Canvas)

@clintandrewhall
Copy link
Contributor Author

clintandrewhall commented Jul 30, 2020

@elasticmachine merge upstream

@clintandrewhall
Copy link
Contributor Author

clintandrewhall commented Jul 30, 2020

@elasticmachine merge upstream

@clintandrewhall
Copy link
Contributor Author

clintandrewhall commented Jul 31, 2020

@elasticmachine merge upstream

@clintandrewhall
Copy link
Contributor Author

clintandrewhall commented Jul 31, 2020

@elasticmachine merge upstream

poffdeluxe
poffdeluxe approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 1, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@clintandrewhall clintandrewhall merged commit 2d2e959 into elastic:master Aug 1, 2020
@clintandrewhall clintandrewhall deleted the tech-debt/rename_examples branch August 1, 2020 16:04
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 2, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
dffcdf9 
* master: (39 commits)
  [Canvas][tech-debt] Rename __examples__ to __stories__ (elastic#73853)
  [Canvas] Storybook Redux Addon (elastic#73227)
  Use "Apply_filter_trigger" in "explore underlying data" action (elastic#71445)
  [maps] convert top nav config to TS (elastic#73851)
  [maps] fix fit to bounds for ES document layers with joins (elastic#73985)
  [Canvas][tech-debt] Refactor Toolbar (completes Kill Recompose.pure) (elastic#73309)
  [CI] In-progress Slack notifications (elastic#74012)
  [SIEM][Detection Engine] Fixes tags to accept characters such as AND, OR, (, ), ", * (elastic#74003)
  [SECURITY_SOLUTION][ENDPOINT] Fix host list Configuration Status cell link loosing list page/size state (elastic#73989)
  Tweak injected metadata (elastic#73990)
  Closes elastic#73998 by using `canAccessML` in the ML capabilities API to (elastic#73999)
  [SIEM] Fixes toaster errors when siemDefault index is an empty or empty spaces (elastic#73991)
  [Security Solution] Fix timeline pin event callback (elastic#73981)
  [Security Solution] Fix unexpected redirect (elastic#73969)
  [Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern (elastic#73986)
  [APM] docs: Update machine learning integration (elastic#73597)
  [Ingest Manager] Fix limited concurrency helper (elastic#73976)
  [build/sysv] fix missing env variable rename (elastic#73977)
  Fix a typo. (elastic#73948)
  [Ingest Manager] Revert fleet config concurrency rollout to rate limit (elastic#73940)
  ...
clintandrewhall added a commit to clintandrewhall/kibana that referenced this pull request Aug 3, 2020
@clintandrewhall @elasticmachine
[Canvas][tech-debt] Rename __examples__ to __stories__ (elastic#73853)
403316a 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@clintandrewhall clintandrewhall mentioned this pull request Aug 3, 2020
Merged
clintandrewhall added a commit that referenced this pull request Aug 3, 2020
@clintandrewhall @elasticmachine
[7.x] [Canvas][tech-debt] Rename __examples__ to __stories__ (#73853) (…
f6fbad2 
…#74058)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@poffdeluxe poffdeluxe poffdeluxe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// technical debt Improvement of the software architecture and operational architecture v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@clintandrewhall @elasticmachine @kibanamachine @poffdeluxe