[Security Solution] Disable bulk actions for immutable timeline templates #73687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angorayc
added
7.9.0
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
angorayc
added
the
bug
Contributor
Author
|
@elasticmachine merge upstream |
cnasikas
approved these changes
Jul 31, 2020
Member
cnasikas
left a comment
cnasikas
left a comment
There was a problem hiding this comment.
Code review looks good. I did the requested manual tests and they behave as expected. LGTM! Great job!
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Aug 3, 2020
…ates (elastic#73687) * disablebulk actions for immutable timeline templates * make immutable timelines not selectable * hide selected count if timeline status is immutable Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Aug 3, 2020
…ates (elastic#73687) * disablebulk actions for immutable timeline templates * make immutable timelines not selectable * hide selected count if timeline status is immutable Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
angorayc
added a commit
that referenced
this pull request
Aug 3, 2020
…ates (#73687) (#74067) * disablebulk actions for immutable timeline templates * make immutable timelines not selectable * hide selected count if timeline status is immutable Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
angorayc
added a commit
that referenced
this pull request
Aug 3, 2020
…ates (#73687) (#74066) * disablebulk actions for immutable timeline templates * make immutable timelines not selectable * hide selected count if timeline status is immutable Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
MindyRS
added
the
Team: SecuritySolution
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to fix:
https://github.com/elastic/siem-team/issues/799
After: I disabled the bulk actions for Elastic timeline templates. Here are the different behaviour under different tabs:
normal timelines:custom templates:Elastic templates(The table is not selectable, and bulk actions are hidden. Onlyopen fromandduplicateare available in rightest action):No filters apply: (Elastic prebuilt templates are not selectable)How To verify:
Bulk actions are hidden under elastic templates' tabs
Delete and export are hidden under elastic templates' tab
Rest of the tabs or even when no filters apply, bulk actions are showed
When no filters apply, elastic templates are not selectable, export and delete actions are disabled too.
Checklist
Delete any items that are not applicable to this PR.
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityThis renders correctly on smaller devices using a responsive layout. (You can test this in your browserThis was checked for cross-browser compatibilityFor maintainers
This was checked for breaking API changes and was labeled appropriately