disablebulk actions for immutable timeline templates

Author: angorayc

x-pack/plugins/security_solution/public/timelines/components/open_timeline/index.tsx

@@ -329,6 +329,7 @@ export const StatefulOpenTimelineComponent = React.memo<OpenTimelineOwnProps>(
         sortField={sortField}
         templateTimelineFilter={templateTimelineFilter}
         timelineType={timelineType}
+        timelineStatus={timelineStatus}
         timelineFilter={timelineTabs}
         title={title}
         totalSearchResultsCount={totalCount}
@@ -359,6 +360,7 @@ export const StatefulOpenTimelineComponent = React.memo<OpenTimelineOwnProps>(
         sortField={sortField}
         templateTimelineFilter={templateTimelineFilter}
         timelineType={timelineType}
+        timelineStatus={timelineStatus}
         timelineFilter={timelineFilters}
         title={title}
         totalSearchResultsCount={totalCount}

x-pack/plugins/security_solution/public/timelines/components/open_timeline/open_timeline.test.tsx

@@ -17,7 +17,7 @@ import { TimelinesTableProps } from './timelines_table';
 import { mockTimelineResults } from '../../../common/mock/timeline_results';
 import { OpenTimeline } from './open_timeline';
 import { DEFAULT_SORT_DIRECTION, DEFAULT_SORT_FIELD } from './constants';
-import { TimelineType } from '../../../../common/types/timeline';
+import { TimelineType, TimelineStatus } from '../../../../common/types/timeline';
 
 jest.mock('../../../common/lib/kibana');
 
@@ -50,6 +50,7 @@ describe('OpenTimeline', () => {
     sortField: DEFAULT_SORT_FIELD,
     title,
     timelineType: TimelineType.default,
+    timelineStatus: TimelineStatus.active,
     templateTimelineFilter: [<div />],
     totalSearchResultsCount: mockSearchResults.length,
   });
@@ -263,4 +264,48 @@ describe('OpenTimeline', () => {
       `Showing: ${mockResults.length} timelines with "How was your day?"`
     );
   });
+
+  test('it should render bulk actions if timelineStatus is not immutable', () => {
+    const defaultProps = {
+      ...getDefaultTestProps(mockResults),
+      timelineStatus: null,
+    };
+    const wrapper = mountWithIntl(
+      <ThemeProvider theme={theme}>
+        <OpenTimeline {...defaultProps} />
+      </ThemeProvider>
+    );
+
+    expect(wrapper.find('[data-test-subj="utility-bar-action"]').exists()).toEqual(true);
+  });
+
+  test('it should not render bulk actions if timelineStatus is immutable', () => {
+    const defaultProps = {
+      ...getDefaultTestProps(mockResults),
+      timelineStatus: TimelineStatus.immutable,
+    };
+    const wrapper = mountWithIntl(
+      <ThemeProvider theme={theme}>
+        <OpenTimeline {...defaultProps} />
+      </ThemeProvider>
+    );
+
+    expect(wrapper.find('[data-test-subj="utility-bar-action"]').exists()).toEqual(false);
+  });
+
+  test('it should not render a selectable timeline table if timelineStatus is immutable', () => {
+    const defaultProps = {
+      ...getDefaultTestProps(mockResults),
+      timelineStatus: TimelineStatus.immutable,
+    };
+    const wrapper = mountWithIntl(
+      <ThemeProvider theme={theme}>
+        <OpenTimeline {...defaultProps} />
+      </ThemeProvider>
+    );
+
+    expect(
+      wrapper.find('[data-test-subj="timelines-table"]').first().prop('actionTimelineToShow')
+    ).toEqual(['createFrom', 'duplicate']);
+  });
 });

x-pack/plugins/security_solution/public/timelines/components/open_timeline/open_timeline.tsx

@@ -8,7 +8,7 @@ import { EuiPanel, EuiBasicTable } from '@elastic/eui';
 import React, { useCallback, useMemo, useRef } from 'react';
 import { FormattedMessage } from '@kbn/i18n/react';
 
-import { TimelineType } from '../../../../common/types/timeline';
+import { TimelineType, TimelineStatus } from '../../../../common/types/timeline';
 import { ImportDataModal } from '../../../common/components/import_data_modal';
 import {
   UtilityBarGroup,
@@ -55,6 +55,7 @@ export const OpenTimeline = React.memo<OpenTimelineProps>(
     setImportDataModalToggle,
     sortField,
     timelineType = TimelineType.default,
+    timelineStatus,
     timelineFilter,
     templateTimelineFilter,
     totalSearchResultsCount,
@@ -140,19 +141,23 @@ export const OpenTimeline = React.memo<OpenTimelineProps>(
     }, [setImportDataModalToggle, refetch, searchResults, totalSearchResultsCount]);
 
     const actionTimelineToShow = useMemo<ActionTimelineToShow[]>(() => {
-      const timelineActions: ActionTimelineToShow[] = [
-        'createFrom',
-        'duplicate',
-        'export',
-        'selectable',
-      ];
+      const timelineActions: ActionTimelineToShow[] = ['createFrom', 'duplicate'];
 
-      if (onDeleteSelected != null && deleteTimelines != null) {
+      if (timelineStatus !== TimelineStatus.immutable) {
+        timelineActions.push('export');
+        timelineActions.push('selectable');
+      }
+
+      if (
+        onDeleteSelected != null &&
+        deleteTimelines != null &&
+        timelineStatus !== TimelineStatus.immutable
+      ) {
         timelineActions.push('delete');
       }
 
       return timelineActions;
-    }, [onDeleteSelected, deleteTimelines]);
+    }, [onDeleteSelected, deleteTimelines, timelineStatus]);
 
     const SearchRowContent = useMemo(() => <>{templateTimelineFilter}</>, [templateTimelineFilter]);
 
@@ -213,13 +218,16 @@ export const OpenTimeline = React.memo<OpenTimelineProps>(
                     ? i18n.SELECTED_TEMPLATES(selectedItems.length)
                     : i18n.SELECTED_TIMELINES(selectedItems.length)}
                 </UtilityBarText>
-                <UtilityBarAction
-                  iconSide="right"
-                  iconType="arrowDown"
-                  popoverContent={getBatchItemsPopoverContent}
-                >
-                  {i18n.BATCH_ACTIONS}
-                </UtilityBarAction>
+                {timelineStatus !== TimelineStatus.immutable && (
+                  <UtilityBarAction
+                    iconSide="right"
+                    iconType="arrowDown"
+                    popoverContent={getBatchItemsPopoverContent}
+                    data-test-subj="utility-bar-action"
+                  >
+                    {i18n.BATCH_ACTIONS}
+                  </UtilityBarAction>
+                )}
                 <UtilityBarAction iconSide="right" iconType="refresh" onClick={onRefreshBtnClick}>
                   {i18n.REFRESH}
                 </UtilityBarAction>

x-pack/plugins/security_solution/public/timelines/components/open_timeline/open_timeline_modal/open_timeline_modal_body.test.tsx

@@ -17,7 +17,7 @@ import { TimelinesTableProps } from '../timelines_table';
 import { mockTimelineResults } from '../../../../common/mock/timeline_results';
 import { OpenTimelineModalBody } from './open_timeline_modal_body';
 import { DEFAULT_SORT_DIRECTION, DEFAULT_SORT_FIELD } from '../constants';
-import { TimelineType } from '../../../../../common/types/timeline';
+import { TimelineType, TimelineStatus } from '../../../../../common/types/timeline';
 
 jest.mock('../../../../common/lib/kibana');
 
@@ -48,6 +48,7 @@ describe('OpenTimelineModal', () => {
     sortDirection: DEFAULT_SORT_DIRECTION,
     sortField: DEFAULT_SORT_FIELD,
     timelineType: TimelineType.default,
+    timelineStatus: TimelineStatus.active,
     templateTimelineFilter: [<div />],
     title,
     totalSearchResultsCount: mockSearchResults.length,

x-pack/plugins/security_solution/public/timelines/components/open_timeline/timelines_table/actions_columns.test.tsx

@@ -12,6 +12,7 @@ import React from 'react';
 import { ThemeProvider } from 'styled-components';
 
 import '../../../../common/mock/match_media';
+
 import { mockTimelineResults } from '../../../../common/mock/timeline_results';
 import { OpenTimelineResult } from '../types';
 import { TimelinesTableProps } from '.';
@@ -233,4 +234,32 @@ describe('#getActionsColumns', () => {
 
     expect(enableExportTimelineDownloader).toBeCalledWith(mockResults[0]);
   });
+
+  test('it should not render "export timeline" if it is not included', () => {
+    const testProps: TimelinesTableProps = {
+      ...getMockTimelinesTableProps(mockResults),
+      actionTimelineToShow: ['createFrom', 'duplicate'],
+    };
+    const wrapper = mountWithIntl(
+      <ThemeProvider theme={theme}>
+        <TimelinesTable {...testProps} />
+      </ThemeProvider>
+    );
+
+    expect(wrapper.find('[data-test-subj="export-timeline"]').exists()).toEqual(false);
+  });
+
+  test('it should not render "delete timeline" if it is not included', () => {
+    const testProps: TimelinesTableProps = {
+      ...getMockTimelinesTableProps(mockResults),
+      actionTimelineToShow: ['createFrom', 'duplicate'],
+    };
+    const wrapper = mountWithIntl(
+      <ThemeProvider theme={theme}>
+        <TimelinesTable {...testProps} />
+      </ThemeProvider>
+    );
+
+    expect(wrapper.find('[data-test-subj="delete-timeline"]').exists()).toEqual(false);
+  });
 });

x-pack/plugins/security_solution/public/timelines/components/open_timeline/types.ts

@@ -14,6 +14,7 @@ import {
   TimelineStatus,
   TemplateTimelineTypeLiteral,
   RowRendererId,
+  TimelineStatusLiteralWithNull,
 } from '../../../../common/types/timeline';
 
 /** The users who added a timeline to favorites */
@@ -174,6 +175,8 @@ export interface OpenTimelineProps {
   sortField: string;
   /** this affects timeline's behaviour like editable / duplicatible */
   timelineType: TimelineTypeLiteralWithNull;
+  /* active or immutable */
+  timelineStatus: TimelineStatusLiteralWithNull;
   /** when timelineType === template, templatetimelineFilter is a JSX.Element */
   templateTimelineFilter: JSX.Element[] | null;
   /** timeline / timeline template */