[Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id #73349

yctercero · 2020-07-27T20:28:15Z

Summary

This PR addresses the following:

Adds list_id to rule.exceptions_list - this is needed in a number of features
Updated getExceptions in x-pack/plugins/security_solution/server/lib/detection_engine/signals/utils.ts to use the latest exception item find endpoint that accepts an array of lists (previously was looping through lists and conducting a find for each)
Updated prepackaged rule that makes reference to global endpoint list to include list_id
Updates formatAboutStepData in x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/create/helpers.ts to include exception list list_id

Checklist

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately
- This is a breaking change, however, it is breaking for functionality not yet in prod

elasticmachine · 2020-07-27T20:28:18Z

Pinging @elastic/siem (Team:SIEM)

…rule

peluja1012

LGTM

…rule

yctercero · 2020-07-28T16:04:56Z

@elasticmachine merge upstream

yctercero · 2020-07-28T17:37:45Z

@elasticmachine merge upstream

yctercero · 2020-07-28T19:19:36Z

@elasticmachine merge upstream

yctercero · 2020-07-28T20:24:01Z

@elasticmachine merge upstream

yctercero · 2020-07-28T22:11:20Z

@elasticmachine merge upstream

yctercero · 2020-07-28T23:39:28Z

@elasticmachine merge upstream

yctercero · 2020-07-29T01:34:30Z

@elasticmachine merge upstream

elasticmachine · 2020-07-29T01:34:32Z

merge conflict between base and head

yctercero · 2020-07-29T02:03:29Z

Ran the failing cypress test locally and it's passing. Just hoping that this next one goes green 🤞

kibanamachine · 2020-07-29T03:26:49Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ff1ab84

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	7.3MB	+113.0B	7.3MB

page load bundle size

id	value	diff	baseline
securitySolution	870.0KB	+111.0B	869.9KB

History

💔 Build #65018 failed 397b04a
💔 Build #64979 failed 6828e9b
💔 Build #64908 failed 3fdb90b
💔 Build #64877 failed fd23f03
💔 Build #64812 failed 69a46e7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ude exception list list_id (elastic#73349) ## Summary This PR addresses the following: - Adds `list_id` to `rule.exceptions_list` - this is needed in a number of features - Updated `getExceptions` in `x-pack/plugins/security_solution/server/lib/detection_engine/signals/utils.ts` to use the latest exception item find endpoint that accepts an array of lists (previously was looping through lists and conducting a `find` for each) - Updated prepackaged rule that makes reference to global endpoint list to include `list_id` - Updates `formatAboutStepData` in `x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/create/helpers.ts` to include exception list `list_id`

…ude exception list list_id (#73349) (#73617) ## Summary This PR addresses the following: - Adds `list_id` to `rule.exceptions_list` - this is needed in a number of features - Updated `getExceptions` in `x-pack/plugins/security_solution/server/lib/detection_engine/signals/utils.ts` to use the latest exception item find endpoint that accepts an array of lists (previously was looping through lists and conducting a `find` for each) - Updated prepackaged rule that makes reference to global endpoint list to include `list_id` - Updates `formatAboutStepData` in `x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/create/helpers.ts` to include exception list `list_id`

…ude exception list list_id (#73349) (#73616) ## Summary This PR addresses the following: - Adds `list_id` to `rule.exceptions_list` - this is needed in a number of features - Updated `getExceptions` in `x-pack/plugins/security_solution/server/lib/detection_engine/signals/utils.ts` to use the latest exception item find endpoint that accepts an array of lists (previously was looping through lists and conducting a `find` for each) - Updated prepackaged rule that makes reference to global endpoint list to include `list_id` - Updates `formatAboutStepData` in `x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/create/helpers.ts` to include exception list `list_id`

* master: (126 commits) [ML] Disabling ML if license feature is disabled (elastic#73187) [ML] Fixing old _xpack style es endpoint paths (elastic#73667) [DOCS] [Lens] 7.9 docs refresh (elastic#72301) [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539) Set timeRange to default to trigger the error message (elastic#73629) [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660) [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473) [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320) [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969) [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618) allow others to update `URL.revokeObjectURL` property if needed (elastic#73639) regen docs (elastic#73650) [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605) [Data] Query Input String manager (elastic#72093) [Security Solutions] Add tooltips (elastic#73436) Do not render descriptionless actions within an EuiCard (elastic#73611) [Security Solution][Detections] Value Lists Modal supports multiple exports (elastic#73532) [Security Solution][Resolver] Handle disabled process collection (elastic#73592) [Security_Solution][Bug] Fix user name/domain to ECS structure (elastic#73530) [Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id (elastic#73349) ...

elasticmachine · 2021-09-23T14:28:37Z

Pinging @elastic/security-solution (Team: SecuritySolution)

updated exceptions_list on rules to include the exception list list_id

bfbf030

yctercero added release_note:enhancement release_note:breaking Team:SIEM v8.0.0 v7.10.0 v7.9.0 labels Jul 27, 2020

yctercero requested review from a team as code owners July 27, 2020 20:28

yctercero self-assigned this Jul 27, 2020

yctercero added 3 commits July 27, 2020 16:30

Merge branch 'master' of github.com:yctercero/kibana into exceptions_…

d4e8341

…rule

Merge branch 'master' of github.com:yctercero/kibana into exceptions_…

7add86a

…rule

update test

b6c45f8

yctercero removed the release_note:breaking label Jul 27, 2020

peluja1012 approved these changes Jul 27, 2020

View reviewed changes

madirey approved these changes Jul 28, 2020

View reviewed changes

yctercero added 2 commits July 28, 2020 11:05

update external_alerts rule to remove endgame index

ae73839

Merge branch 'master' of github.com:yctercero/kibana into exceptions_…

db6f33b

…rule

rw-access approved these changes Jul 28, 2020

View reviewed changes

Merge branch 'master' into exceptions_rule

651fbbf

Merge branch 'master' into exceptions_rule

69a46e7

Merge branch 'master' into exceptions_rule

fd23f03

Merge branch 'master' into exceptions_rule

3fdb90b

Merge branch 'master' into exceptions_rule

6828e9b

Merge branch 'master' into exceptions_rule

397b04a

Merge branch 'master' into exceptions_rule

ff1ab84

yctercero merged commit e645732 into elastic:master Jul 29, 2020

yctercero mentioned this pull request Jul 29, 2020

[7.x] [Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id (#73349) #73616

Merged

yctercero mentioned this pull request Jul 29, 2020

[7.9] [Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id (#73349) #73617

Merged

yctercero deleted the exceptions_rule branch October 14, 2020 12:00

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

[Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id #73349

[Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id #73349

Uh oh!

Conversation

yctercero commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Jul 27, 2020

Uh oh!

peluja1012 left a comment

Choose a reason for hiding this comment

Uh oh!

yctercero commented Jul 28, 2020

Uh oh!

yctercero commented Jul 28, 2020

Uh oh!

yctercero commented Jul 28, 2020

Uh oh!

yctercero commented Jul 28, 2020

Uh oh!

yctercero commented Jul 28, 2020

Uh oh!

yctercero commented Jul 28, 2020

Uh oh!

yctercero commented Jul 29, 2020

Uh oh!

elasticmachine commented Jul 29, 2020

Uh oh!

yctercero commented Jul 29, 2020

Uh oh!

kibanamachine commented Jul 29, 2020

💚 Build Succeeded

Build metrics

async chunks size

page load bundle size

History

Uh oh!

elasticmachine commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

yctercero commented Jul 27, 2020 •

edited

Loading