Skip to content

[Security_Solution][Bug] Fix user name/domain to ECS structure #73530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 29, 2020
Merged

[Security_Solution][Bug] Fix user name/domain to ECS structure #73530

merged 8 commits into from
Jul 29, 2020

Conversation

@bkimmel
Copy link
Contributor

@bkimmel bkimmel commented Jul 28, 2020 •
edited
Loading

closes https://github.com/elastic/endpoint-app-team/issues/645

Summary

Fixing bug in 7.9 noted here: #73310 (comment)

@bkimmel bkimmel requested review from a team as code owners July 28, 2020 18:47
@bkimmel bkimmel added the Feature:Resolver Security Solution Resolver feature label Jul 28, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 28, 2020

Pinging @elastic/endpoint-app-team (Feature:Resolver)

@bkimmel bkimmel added the Team:Endpoint Data Visibility Team managing the endpoint resolver label Jul 28, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 28, 2020

Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility)

@bkimmel bkimmel added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jul 28, 2020
@bkimmel
Copy link
Contributor Author

bkimmel commented Jul 28, 2020

#73310 (comment)

@bkimmel
Copy link
Contributor Author

bkimmel commented Jul 28, 2020

@elasticmachine merge upstream

@bkimmel
Copy link
Contributor Author

bkimmel commented Jul 28, 2020

@elasticmachine merge upstream

@james-elastic
Copy link

james-elastic commented Jul 28, 2020

@bkimmel Are there any tests we can update or add?

@bkimmel
Copy link
Contributor Author

bkimmel commented Jul 28, 2020

@bkimmel Are there any tests we can update or add?

e5a1b9a

@bkimmel
Copy link
Contributor Author

bkimmel commented Jul 28, 2020

@elasticmachine merge upstream

@bkimmel
Copy link
Contributor Author

bkimmel commented Jul 28, 2020

@elasticmachine merge upstream

@bkimmel bkimmel changed the title Fix user name/domain to ECS structure [Security_Solution][Bug] Fix user name/domain to ECS structure Jul 29, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 29, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bkimmel bkimmel added the v8.0.0 label Jul 29, 2020
@bkimmel bkimmel removed the v7.9.0 label Jul 29, 2020
@bkimmel bkimmel merged commit 0b708e0 into elastic:master Jul 29, 2020
@bkimmel bkimmel deleted the resolver/ecs-username-fix branch July 29, 2020 03:33
@bkimmel bkimmel mentioned this pull request Jul 29, 2020
Merged
bkimmel added a commit that referenced this pull request Jul 29, 2020
@bkimmel
[Security_Solution][Bug] Fix user name/domain to ECS structure (#73530)…
2c84e41 
… (#73623)

* The changes this tests are being ported separately to 7.9
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 29, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
8764243 
* master: (126 commits)
  [ML] Disabling ML if license feature is disabled (elastic#73187)
  [ML] Fixing old _xpack style es endpoint paths (elastic#73667)
  [DOCS] [Lens] 7.9 docs refresh (elastic#72301)
  [ML] DF Analytics results: ensure `View` link is only enabled when job has successfully completed (elastic#73539)
  Set timeRange to default to trigger the error message (elastic#73629)
  [ML] Functional tests - stabilize DFA navigation and index pattern handling (elastic#73660)
  [ILM] Add links to "Snapshot and Restore" from ILM "wait for snapshot policy" (elastic#72473)
  [kbn-storybook] Update Storybook to 5.3.19 (elastic#73320)
  [Metrics UI] Fix hasData call to ensure it has data not just indices (elastic#72969)
  [Uptime] Use `service.name` to link from Uptime -> APM where available (elastic#73618)
  allow others to update `URL.revokeObjectURL` property if needed (elastic#73639)
  regen docs (elastic#73650)
  [Visualize] Fix inspector download filename issue when saving in-place (elastic#72605)
  [Data] Query Input String manager (elastic#72093)
  [Security Solutions] Add tooltips (elastic#73436)
  Do not render descriptionless actions within an EuiCard (elastic#73611)
  [Security Solution][Detections] Value Lists Modal supports multiple exports (elastic#73532)
  [Security Solution][Resolver] Handle disabled process collection (elastic#73592)
  [Security_Solution][Bug] Fix user name/domain to ECS structure (elastic#73530)
  [Security Solution][Exceptions] - Update rule.exceptions_list to include exception list list_id (elastic#73349)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@james-elastic james-elastic james-elastic approved these changes

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

+1 more reviewer

@oatkiller oatkiller oatkiller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Resolver Security Solution Resolver feature release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Data Visibility Team managing the endpoint resolver v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bkimmel @elasticmachine @james-elastic @kibanamachine @oatkiller @michaelolo24 @jonathan-buttner