Skip to content

Fix TSVB table trend slope value #71087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 13, 2020
Merged

Fix TSVB table trend slope value #71087

merged 4 commits into from
Jul 13, 2020

Conversation

@dej611
Copy link
Contributor

@dej611 dej611 commented Jul 8, 2020

Summary

This PR replaces the current regression library dependency with a simpler computation of the slope value based on the last 2 values.

  • 🐛 Fix the 0-value result for the slope prop
  • ✅ Add some testing for the function

Checklist

Delete any items that are not applicable to this PR.

@dej611 dej611 added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 v7.9.0 labels Jul 8, 2020
@dej611 dej611 requested a review from flash1293 July 8, 2020 13:27
@dej611 dej611 self-assigned this Jul 8, 2020
@dej611 dej611 linked an issue Jul 8, 2020 that may be closed by this pull request
TSVB table trend arrows always show slope of 0 #59656
Closed
@dej611
Copy link
Contributor Author

dej611 commented Jul 8, 2020

@elasticmachine merge upstream

@dej611
Copy link
Contributor Author

dej611 commented Jul 13, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 13, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 marked this pull request as ready for review July 13, 2020 12:14
@dej611 dej611 requested a review from a team July 13, 2020 12:14
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 13, 2020

Pinging @elastic/kibana-app (Team:KibanaApp)

flash1293
flash1293 approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in Firefox and trend arrows are shown in the table as expected. Thanks for adding this!

@dej611 dej611 merged commit 4e9d981 into elastic:master Jul 13, 2020
@dej611 dej611 deleted the tsvb/trend-arrows-fix branch July 13, 2020 12:27
@dej611 dej611 mentioned this pull request Jul 13, 2020
Merged
dej611 added a commit to dej611/kibana that referenced this pull request Jul 13, 2020
@dej611 @elasticmachine
Fix TSVB table trend slope value (elastic#71087)
a7397fe 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
dej611 added a commit that referenced this pull request Jul 13, 2020
@dej611 @elasticmachine
[7.x] Fix TSVB table trend slope value (#71087) (#71433)
9c402ba 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees

@dej611 dej611

Labels

Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TSVB table trend arrows always show slope of 0

4 participants

@dej611 @kibanamachine @elasticmachine @flash1293