[Endpoint] Support redirect from Policy Details to Ingest when user initiates Edit Policy from Datasource Edit page #70874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-tavares
added
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
Contributor
|
Pinging @elastic/endpoint-management (Team:Endpoint Management) |
…d-trip-to-ingest-for-ds
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
aisantos
approved these changes
Jul 7, 2020
parkiino
approved these changes
Jul 7, 2020
paul-tavares
added a commit
to paul-tavares/kibana
that referenced
this pull request
Jul 7, 2020
…nitiates Edit Policy from Datasource Edit page (elastic#70874) * allow Policy Details to support route state * Functional Tests cases that cover ingest navigation
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 8, 2020
* master: (36 commits) fixed api url in example plugin (elastic#70934) [data.search.aggs]: Remove remaining client dependencies (elastic#70251) [Security Solution][Endpoint] Fix base64 download bug and adopt new user artifact/manifest format (elastic#70998) [Security Solution][Exceptions] - Exception Modal Part I (elastic#70639) [SIEM][Detection Engine][Lists] Adds additional data types to value based lists [SIEM][Detection Engine][Lists] Removes feature flag for lists [APM] Show license callout in ML settings (elastic#70959) Migrate service settings test to jest (elastic#70992) [APM] Add cloud attributes to data telemetry (elastic#71008) Fix breadcrumb on panels for visibility / round corners (elastic#71010) Improve search typescript (elastic#69333) [savedObjects field count] run in baseline job (elastic#70999) [Security Solution] [Timeline] Timeline manager tweaks (elastic#69988) [Endpoint] Support redirect from Policy Details to Ingest when user initiates Edit Policy from Datasource Edit page (elastic#70874) [APM] Add API tests (elastic#70740) [Security Solution][Exceptions] - Tie server and client code together (elastic#70918) [Audit Logging] Add AuditTrail service (elastic#69278) [Usage Collection] Ensure no type duplicates (elastic#70946) [Security Solution] [Timeline] Bugfix for timeline row actions disappear sometimes (elastic#70958) [CI] Add pipeline task queue framework and merge workers into one (elastic#64011) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a user is looking at a Package Configuration (previously known as
Datasource) in Ingest Management for Endpoint, and clicks theEdit Policybutton, they will now be redirected back to the Ingest page from where they originated when either theCancelbutton is clicked in the Endpoint Policy Details page, or a successfulSaveis done.In addition:
dispatchaction to the unmounting of the sub-plugins in order to ensure that proper state handling (ex. resetting) is handled when navigating to another Kibana App (ex. vianavigateToApp()). This is necessary because the redux Store is persisted across pluginunmountlifecycles.Checklist
Delete any items that are not applicable to this PR.