Skip to content

[data.search.aggs]: Remove remaining client dependencies #70251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 8, 2020
Merged

[data.search.aggs]: Remove remaining client dependencies #70251

merged 18 commits into from
Jul 8, 2020

Conversation

@lukeelmers
Copy link
Member

@lukeelmers lukeelmers commented Jun 29, 2020 •
edited
Loading

Part of #65793

This makes the following changes to aggs in preparation for exposing on the server & client:

  • remove usages of notifications.toasts, which allows us to clean up a lot of extra calls to getInternalStartServices
    • this touches a bunch of files but the changes are all very repetitive; I recommend reviewing this PR commit-by-commit
  • kibana_utils/public/savedObjectNotFound -> change to import from common instead
  • kibana_utils/public/ipv4address -> move to data plugin
  • filters agg uses getQueryLog which requires window.localStorage -> move to default editor

@lukeelmers lukeelmers mentioned this pull request Jun 29, 2020
Closed
7 tasks
@lukeelmers lukeelmers changed the title Fix/aggs remove deps [data.search.aggs]: Remove remaining client dependencies Jun 30, 2020
@lukeelmers lukeelmers requested a review from ppisljar June 30, 2020 03:12
@lukeelmers lukeelmers self-assigned this Jun 30, 2020
@lukeelmers lukeelmers added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) release_note:skip Skip the PR/issue when compiling release notes Team:AppArch v7.9.0 v8.0.0 WIP Work in progress labels Jun 30, 2020
@lukeelmers lukeelmers force-pushed the fix/aggs-remove-deps branch from ac468eb to 33f0e41 Compare June 30, 2020 22:27
@lukeelmers lukeelmers removed the WIP Work in progress label Jun 30, 2020
@lukeelmers lukeelmers marked this pull request as ready for review June 30, 2020 22:32
@lukeelmers lukeelmers requested a review from a team June 30, 2020 22:32
@lukeelmers lukeelmers requested a review from a team as a code owner June 30, 2020 22:32
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 30, 2020

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers
Copy link
Member Author

lukeelmers commented Jul 1, 2020

@elasticmachine merge upstream

ppisljar
ppisljar approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@lukeelmers
Copy link
Member Author

lukeelmers commented Jul 1, 2020

@elasticmachine merge upstream

Remaining CI failure is from a massive snapshot test in the uptime plugin, which seems fishy as it isn't related to the changes being made here. Looking into it further.

@lukeelmers
Copy link
Member Author

lukeelmers commented Jul 2, 2020

@elasticmachine merge upstream

1 similar comment
@lukeelmers
Copy link
Member Author

lukeelmers commented Jul 2, 2020

@elasticmachine merge upstream

@elasticmachine elasticmachine requested review from a team as code owners July 2, 2020 18:59
@lukeelmers lukeelmers force-pushed the fix/aggs-remove-deps branch from 13342da to f33d14a Compare July 6, 2020 14:56
@lukeelmers
Copy link
Member Author

lukeelmers commented Jul 6, 2020

This should be ready to go. @sulemanof or @timroes if either of you could give a final LGTM from the kibana app side, that'd be great!

@lukeelmers
Copy link
Member Author

lukeelmers commented Jul 7, 2020

@elasticmachine merge upstream

timroes
timroes approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the Kibana App relevant changes on Firefox linux. seems to work. Code LGTM

@lukeelmers
Copy link
Member Author

lukeelmers commented Jul 7, 2020

@elasticmachine merge upstream

@lukeelmers
Copy link
Member Author

lukeelmers commented Jul 7, 2020

@elasticmachine merge upstream

lukeelmers added 18 commits July 7, 2020 16:57
@lukeelmers lukeelmers force-pushed the fix/aggs-remove-deps branch from fb2bcbd to f6dc791 Compare July 7, 2020 23:04
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 8, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
data 203 +1 202

History

  • 💛 Build #59512 was flaky fb2bcbdf971827871e68837a8bddf2bc4fd95ca0
  • 💛 Build #59429 was flaky 4f11c1a084c855ac94c242ac115b260e9a448633
  • 💔 Build #59248 failed f0720d617ec11dc951689a25fe0c1cf9fc991a54
  • 💚 Build #58993 succeeded f33d14a124c7b05334b59c3a6a4c70e2eef1efc2
  • 💚 Build #58431 succeeded 13342da97ef3f64b1d3a66e0937355a1ea696b5b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lukeelmers lukeelmers merged commit d43c460 into elastic:master Jul 8, 2020
@lukeelmers lukeelmers deleted the fix/aggs-remove-deps branch July 8, 2020 03:54
@lukeelmers lukeelmers mentioned this pull request Jul 8, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 8, 2020
@gmmorris
Merge branch 'master' into actions/feature-and-rbac
a84a263 
* master: (36 commits)
  fixed api url in example plugin (elastic#70934)
  [data.search.aggs]: Remove remaining client dependencies (elastic#70251)
  [Security Solution][Endpoint] Fix base64 download bug and adopt new user artifact/manifest format (elastic#70998)
  [Security Solution][Exceptions] - Exception Modal Part I (elastic#70639)
  [SIEM][Detection Engine][Lists] Adds additional data types to value based lists
  [SIEM][Detection Engine][Lists] Removes feature flag for lists
  [APM] Show license callout in ML settings (elastic#70959)
  Migrate service settings test to jest (elastic#70992)
  [APM] Add cloud attributes to data telemetry (elastic#71008)
  Fix breadcrumb on panels for visibility / round corners (elastic#71010)
  Improve search typescript (elastic#69333)
  [savedObjects field count] run in baseline job (elastic#70999)
  [Security Solution] [Timeline] Timeline manager tweaks (elastic#69988)
  [Endpoint] Support redirect from Policy Details to Ingest when user initiates Edit Policy from Datasource Edit page (elastic#70874)
  [APM] Add API tests (elastic#70740)
  [Security Solution][Exceptions] - Tie server and client code together (elastic#70918)
  [Audit Logging] Add AuditTrail service (elastic#69278)
  [Usage Collection] Ensure no type duplicates (elastic#70946)
  [Security Solution] [Timeline] Bugfix for timeline row actions disappear sometimes (elastic#70958)
  [CI] Add pipeline task queue framework and merge workers into one (elastic#64011)
  ...
lukeelmers added a commit to lukeelmers/kibana that referenced this pull request Jul 8, 2020
@lukeelmers
[data.search.aggs]: Remove remaining client dependencies (elastic#70251)
b96a8a2 
# Conflicts:
#	src/plugins/data/public/public.api.md
lukeelmers added a commit that referenced this pull request Jul 8, 2020
@lukeelmers
[7.x] [data.search.aggs]: Remove remaining client dependencies (#70251)…
d281ec0 
… (#71041)
@lukeelmers lukeelmers mentioned this pull request Aug 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@ppisljar ppisljar ppisljar approved these changes

+2 more reviewers

@sulemanof sulemanof sulemanof left review comments

@timroes timroes timroes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukeelmers lukeelmers

Labels

Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lukeelmers @elasticmachine @kibanamachine @timroes @patrykkopycinski @ppisljar @sulemanof