Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Core UI] Add missing alt attributes to add data tutorial logos (#62393) #62643

Closed
wants to merge 1 commit into from
Closed

[7.x] [Core UI] Add missing alt attributes to add data tutorial logos (#62393) #62643

wants to merge 1 commit into from

Conversation

MichaelMarcialis
Copy link
Contributor

Backports the following commits to 7.x:

@MichaelMarcialis
[Core UI] Add missing alt attributes to add data tutorial logos (elas…
c7dacf5 
…tic#62393)

* add empty title prop for data tutorial page icons

* switch alt attribute to title prop

* update snapshots

* enabling skipped a11y tests
@MichaelMarcialis
Copy link
Contributor Author

@bhavyarm: Based on your original PR's labels (#62342), I assumed your changes would be backported to 7.x. It appears that backport has not currently happened yet. Is that something that is forthcoming? Or was your change only for 8.0?

If forthcoming, I'll wait for your backport.

@kibanamachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MichaelMarcialis MichaelMarcialis deleted the backport/7.x/pr-62393 branch April 6, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelMarcialis @kibanamachine