a11y for xpack home #62342
Merged
a11y for xpack home #62342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhavyarm
added
Project:Accessibility
Feature:Add Data
|
will change the status to ready once I get a pass through CI. |
kertal
reviewed
Apr 3, 2020
src/plugins/home/public/application/components/feature_directory.js
Outdated
Show resolved
Hide resolved
myasonik
approved these changes
Apr 3, 2020
rashmivkulkarni
approved these changes
Apr 3, 2020
kertal
approved these changes
Apr 3, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
bhavyarm
added a commit
to bhavyarm/kibana
that referenced
this pull request
Apr 3, 2020
a11y test xpack home
MichaelMarcialis
pushed a commit
that referenced
this pull request
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta:
#51456
The pr goes into xpack home, checks out all the plugins in all, visualize & explore, admin category, opens a kibana app, navigates back to home, opens an add data tutorial, checks out the instructions on self managed and then opens instructions for tutorial on cloud
Skipped tests are because of these two issues:
#62239
#38980
There was no data-test-subj infrastructure. Will talk to @LeeDr to see what we want to do about missing functional tests.