[ML] Re-enabling file upload telemetry #60418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
requested review from
alvarezmelissa87,
darnautov,
peteharverson and
walterra
jgowdyelastic
added
:ml
Feature:File and Index Data Viz
Contributor
|
Pinging @elastic/ml-ui (:ml) |
alvarezmelissa87
approved these changes
Mar 17, 2020
Contributor
alvarezmelissa87
left a comment
alvarezmelissa87
left a comment
There was a problem hiding this comment.
Code LGTM ⚡️ - just added a couple of comments about removing commented code.
Contributor
|
Latest edits LGTM ⚡️ |
Member
Author
|
@elasticmachine merge upstream |
Contributor
|
merge conflict between base and head |
jgowdyelastic
force-pushed
the
re-enabling-ml-file-upload-telemetry
branch
from
40e2386 to
83405d5
Compare
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 18, 2020
* master: [ML] Re-enabling file upload telemetry (elastic#60418) [NP] Use local helper shortenDottedString for discover (elastic#60271) [Console] Fix for `_settings` and x-pack autocomplete (elastic#60246) Task/host enhancements (elastic#59671) [Search service] Asynchronous ES search strategy (elastic#53538) Index Action - Moved index params fields to connector config (elastic#60349) Edits UI text for ML nodes and job button (elastic#60184) Publish getIsNavDrawerLocked$ method on core chrome service. (elastic#60191) Disabled edit alert button on management ui for non registered UI alert types (elastic#60439) Revert "[Console] Fix bool filter autocompletions and refactor (elastic#60361)" [Console] Fix bool filter autocompletions and refactor (elastic#60361) Update ingest management team handle (elastic#60457) [IM] Use EuiCodeBlock to render index mapping (elastic#60420) Add additional safeguards for data source wizard step 2 (elastic#60426) [kbn/pm] don't fail when plugins are outside repo (elastic#60164) upgrade react-use (elastic#60427) Remove link to old settings (elastic#60326) Update app arch CODEOWNERS items. (elastic#60396) [ML] Fixing custom urls to dashboards (elastic#60355) Update the ems-client dependency to 7.7.0 (elastic#59936)
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Mar 18, 2020
* [ML] Re-enabling file upload telemetry * small refactor * removing exported function * removing commented out code * removing commented out include * cleaning up types
jgowdyelastic
added a commit
that referenced
this pull request
Mar 18, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 19, 2020
…alerting/tls-warning * 'alerting/tls-warning' of github.com:gmmorris/kibana: (33 commits) [ML] Disable functional transform tests Fixes to service map single node banner (elastic#60072) [Uptime] replace fetch with kibana http (elastic#59881) Upgrade @types/node to match Node.js runtime (elastic#60368) [License Management] NP migration (elastic#60250) Fix create alert button from not showing in alerts list (elastic#60444) [SIEM][Case] Update connector through flyout (elastic#60307) add data-test-subj where possible on SO management table (elastic#60226) Enforce `required` presence for value/key validation of `recordOf` and `mapOf`. (elastic#60406) [ML] Re-enabling file upload telemetry (elastic#60418) [NP] Use local helper shortenDottedString for discover (elastic#60271) [Console] Fix for `_settings` and x-pack autocomplete (elastic#60246) Task/host enhancements (elastic#59671) [Search service] Asynchronous ES search strategy (elastic#53538) Index Action - Moved index params fields to connector config (elastic#60349) Edits UI text for ML nodes and job button (elastic#60184) Publish getIsNavDrawerLocked$ method on core chrome service. (elastic#60191) Disabled edit alert button on management ui for non registered UI alert types (elastic#60439) Revert "[Console] Fix bool filter autocompletions and refactor (elastic#60361)" [Console] Fix bool filter autocompletions and refactor (elastic#60361) ...
darnautov
added a commit
that referenced
this pull request
May 17, 2023
## Summary Fixes the usage collector for the file upload plugin. According to the git history it hasn't been working since #60418. The saved objects repository required for retrieving telemetry data wasn't provided, causing telemetry to fall back to `index_creation_count: 0` after each check. ### How to test Execute the following request in the Dev Console. ``` POST kbn:/api/telemetry/v2/clusters/_stats { "unencrypted": true } ``` [`mlUsage`](https://github.com/elastic/kibana/blob/9047d69d574225212996ea9dbcd15dddc607d11e/x-pack/plugins/file_upload/server/telemetry/usage_collector.ts#L36) shouldn't be `null`.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 17, 2023
## Summary Fixes the usage collector for the file upload plugin. According to the git history it hasn't been working since elastic#60418. The saved objects repository required for retrieving telemetry data wasn't provided, causing telemetry to fall back to `index_creation_count: 0` after each check. ### How to test Execute the following request in the Dev Console. ``` POST kbn:/api/telemetry/v2/clusters/_stats { "unencrypted": true } ``` [`mlUsage`](https://github.com/elastic/kibana/blob/9047d69d574225212996ea9dbcd15dddc607d11e/x-pack/plugins/file_upload/server/telemetry/usage_collector.ts#L36) shouldn't be `null`. (cherry picked from commit 57af98f)
kibanamachine
added a commit
that referenced
this pull request
May 17, 2023
# Backport This will backport the following commits from `main` to `8.8`: - [[ML] Fix the file upload telemetry (#157888)](#157888) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"dmitrii.arnautov@elastic.co"},"sourceCommit":{"committedDate":"2023-05-17T09:36:58Z","message":"[ML] Fix the file upload telemetry (#157888)\n\n## Summary\r\n\r\nFixes the usage collector for the file upload plugin. According to the\r\ngit history it hasn't been working since\r\nhttps://github.com//pull/60418.\r\n\r\nThe saved objects repository required for retrieving telemetry data\r\nwasn't provided, causing telemetry to fall back to\r\n`index_creation_count: 0` after each check.\r\n\r\n\r\n### How to test \r\n\r\nExecute the following request in the Dev Console.\r\n\r\n```\r\nPOST kbn:/api/telemetry/v2/clusters/_stats\r\n{ \"unencrypted\": true }\r\n```\r\n\r\n\r\n[`mlUsage`](https://github.com/elastic/kibana/blob/9047d69d574225212996ea9dbcd15dddc607d11e/x-pack/plugins/file_upload/server/telemetry/usage_collector.ts#L36)\r\nshouldn't be `null`.","sha":"57af98f38a535432f7f085abaa3c9e7e4f67a53a","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:File Upload","telemetry","v8.9.0","v8.8.1"],"number":157888,"url":"https://github.com/elastic/kibana/pull/157888","mergeCommit":{"message":"[ML] Fix the file upload telemetry (#157888)\n\n## Summary\r\n\r\nFixes the usage collector for the file upload plugin. According to the\r\ngit history it hasn't been working since\r\nhttps://github.com//pull/60418.\r\n\r\nThe saved objects repository required for retrieving telemetry data\r\nwasn't provided, causing telemetry to fall back to\r\n`index_creation_count: 0` after each check.\r\n\r\n\r\n### How to test \r\n\r\nExecute the following request in the Dev Console.\r\n\r\n```\r\nPOST kbn:/api/telemetry/v2/clusters/_stats\r\n{ \"unencrypted\": true }\r\n```\r\n\r\n\r\n[`mlUsage`](https://github.com/elastic/kibana/blob/9047d69d574225212996ea9dbcd15dddc607d11e/x-pack/plugins/file_upload/server/telemetry/usage_collector.ts#L36)\r\nshouldn't be `null`.","sha":"57af98f38a535432f7f085abaa3c9e7e4f67a53a"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/157888","number":157888,"mergeCommit":{"message":"[ML] Fix the file upload telemetry (#157888)\n\n## Summary\r\n\r\nFixes the usage collector for the file upload plugin. According to the\r\ngit history it hasn't been working since\r\nhttps://github.com//pull/60418.\r\n\r\nThe saved objects repository required for retrieving telemetry data\r\nwasn't provided, causing telemetry to fall back to\r\n`index_creation_count: 0` after each check.\r\n\r\n\r\n### How to test \r\n\r\nExecute the following request in the Dev Console.\r\n\r\n```\r\nPOST kbn:/api/telemetry/v2/clusters/_stats\r\n{ \"unencrypted\": true }\r\n```\r\n\r\n\r\n[`mlUsage`](https://github.com/elastic/kibana/blob/9047d69d574225212996ea9dbcd15dddc607d11e/x-pack/plugins/file_upload/server/telemetry/usage_collector.ts#L36)\r\nshouldn't be `null`.","sha":"57af98f38a535432f7f085abaa3c9e7e4f67a53a"}},{"branch":"8.8","label":"v8.8.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
jasonrhodes
pushed a commit
that referenced
this pull request
May 17, 2023
## Summary Fixes the usage collector for the file upload plugin. According to the git history it hasn't been working since #60418. The saved objects repository required for retrieving telemetry data wasn't provided, causing telemetry to fall back to `index_creation_count: 0` after each check. ### How to test Execute the following request in the Dev Console. ``` POST kbn:/api/telemetry/v2/clusters/_stats { "unencrypted": true } ``` [`mlUsage`](https://github.com/elastic/kibana/blob/9047d69d574225212996ea9dbcd15dddc607d11e/x-pack/plugins/file_upload/server/telemetry/usage_collector.ts#L36) shouldn't be `null`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes file datavisualizer upload telemetry which was broken by #60100