Skip to content

Commit 38c5e1e

Browse files
committed
rge branch 'alerting/tls-warning' of github.com:gmmorris/kibana into alerting/tls-warning
* 'alerting/tls-warning' of github.com:gmmorris/kibana: (33 commits) [ML] Disable functional transform tests Fixes to service map single node banner (elastic#60072) [Uptime] replace fetch with kibana http (elastic#59881) Upgrade @types/node to match Node.js runtime (elastic#60368) [License Management] NP migration (elastic#60250) Fix create alert button from not showing in alerts list (elastic#60444) [SIEM][Case] Update connector through flyout (elastic#60307) add data-test-subj where possible on SO management table (elastic#60226) Enforce `required` presence for value/key validation of `recordOf` and `mapOf`. (elastic#60406) [ML] Re-enabling file upload telemetry (elastic#60418) [NP] Use local helper shortenDottedString for discover (elastic#60271) [Console] Fix for `_settings` and x-pack autocomplete (elastic#60246) Task/host enhancements (elastic#59671) [Search service] Asynchronous ES search strategy (elastic#53538) Index Action - Moved index params fields to connector config (elastic#60349) Edits UI text for ML nodes and job button (elastic#60184) Publish getIsNavDrawerLocked$ method on core chrome service. (elastic#60191) Disabled edit alert button on management ui for non registered UI alert types (elastic#60439) Revert "[Console] Fix bool filter autocompletions and refactor (elastic#60361)" [Console] Fix bool filter autocompletions and refactor (elastic#60361) ...
2 parents 3dce19f + 74fc2eb commit 38c5e1e

File tree

589 files changed

+8389
-7776
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

589 files changed

+8389
-7776
lines changed

.github/CODEOWNERS

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,33 +29,32 @@
2929
/src/plugins/dashboard/ @elastic/kibana-app
3030

3131
# App Architecture
32+
/examples/url_generators_examples/ @elastic/kibana-app-arch
33+
/examples/url_generators_explorer/ @elastic/kibana-app-arch
3234
/packages/kbn-interpreter/ @elastic/kibana-app-arch
33-
/src/legacy/core_plugins/data/ @elastic/kibana-app-arch
34-
/src/legacy/core_plugins/elasticsearch/lib/create_proxy.js @elastic/kibana-app-arch
3535
/src/legacy/core_plugins/embeddable_api/ @elastic/kibana-app-arch
3636
/src/legacy/core_plugins/interpreter/ @elastic/kibana-app-arch
3737
/src/legacy/core_plugins/kibana_react/ @elastic/kibana-app-arch
3838
/src/legacy/core_plugins/kibana/public/management/ @elastic/kibana-app-arch
39-
/src/legacy/core_plugins/kibana/server/field_formats/ @elastic/kibana-app-arch
4039
/src/legacy/core_plugins/kibana/server/routes/api/management/ @elastic/kibana-app-arch
41-
/src/legacy/core_plugins/kibana/server/routes/api/suggestions/ @elastic/kibana-app-arch
4240
/src/legacy/core_plugins/visualizations/ @elastic/kibana-app-arch
4341
/src/legacy/server/index_patterns/ @elastic/kibana-app-arch
42+
/src/plugins/advanced_settings/ @elastic/kibana-app-arch
4443
/src/plugins/bfetch/ @elastic/kibana-app-arch
4544
/src/plugins/data/ @elastic/kibana-app-arch
4645
/src/plugins/embeddable/ @elastic/kibana-app-arch
4746
/src/plugins/expressions/ @elastic/kibana-app-arch
4847
/src/plugins/inspector/ @elastic/kibana-app-arch
4948
/src/plugins/kibana_react/ @elastic/kibana-app-arch
49+
/src/plugins/kibana_react/public/code_editor @elastic/kibana-canvas
5050
/src/plugins/kibana_utils/ @elastic/kibana-app-arch
5151
/src/plugins/management/ @elastic/kibana-app-arch
5252
/src/plugins/navigation/ @elastic/kibana-app-arch
53+
/src/plugins/share/ @elastic/kibana-app-arch
5354
/src/plugins/ui_actions/ @elastic/kibana-app-arch
5455
/src/plugins/visualizations/ @elastic/kibana-app-arch
55-
/src/plugins/share/ @elastic/kibana-app-arch
56-
/examples/url_generators_examples/ @elastic/kibana-app-arch
57-
/examples/url_generators_explorer/ @elastic/kibana-app-arch
5856
/x-pack/plugins/advanced_ui_actions/ @elastic/kibana-app-arch
57+
/x-pack/plugins/data_enhanced/ @elastic/kibana-app-arch
5958
/x-pack/plugins/drilldowns/ @elastic/kibana-app-arch
6059

6160
# APM
@@ -75,9 +74,9 @@
7574
# Observability UIs
7675
/x-pack/legacy/plugins/infra/ @elastic/logs-metrics-ui
7776
/x-pack/plugins/infra/ @elastic/logs-metrics-ui
78-
/x-pack/plugins/ingest_manager/ @elastic/ingest
79-
/x-pack/legacy/plugins/ingest_manager/ @elastic/ingest
80-
/x-pack/plugins/observability/ @elastic/logs-metrics-ui @elastic/apm-ui @elastic/uptime @elastic/ingest
77+
/x-pack/plugins/ingest_manager/ @elastic/ingest-management
78+
/x-pack/legacy/plugins/ingest_manager/ @elastic/ingest-management
79+
/x-pack/plugins/observability/ @elastic/logs-metrics-ui @elastic/apm-ui @elastic/uptime @elastic/ingest-management
8180
/x-pack/legacy/plugins/monitoring/ @elastic/stack-monitoring-ui
8281

8382
# Machine Learning

docs/developer/core/development-functional-tests.asciidoc

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,25 @@ To run tests on Firefox locally, use `config.firefox.js`:
178178
node scripts/functional_test_runner --config test/functional/config.firefox.js
179179
-----------
180180

181+
[float]
182+
===== Using the test_user service
183+
184+
Tests should run at the positive security boundry condition, meaning that they should be run with the mimimum privileges required (and documented) and not as the superuser.
185+
This prevents the type of regression where additional privleges accidentally become required to perform the same action.
186+
187+
The functional UI tests now default to logging in with a user named `test_user` and the roles of this user can be changed dynamically without logging in and out.
188+
189+
In order to achieve this a new service was introduced called `createTestUserService` (see `test/common/services/security/test_user.ts`). The purpose of this test user service is to create roles defined in the test config files and setRoles() or restoreDefaults().
190+
191+
An example of how to set the role like how its defined below:
192+
193+
`await security.testUser.setRoles(['kibana_user', 'kibana_date_nanos']);`
194+
195+
Here we are setting the `test_user` to have the `kibana_user` role and also role access to a specific data index (`kibana_date_nanos`).
196+
197+
Tests should normally setRoles() in the before() and restoreDefaults() in the after().
198+
199+
181200
[float]
182201
===== Anatomy of a test file
183202

docs/development/core/public/kibana-plugin-core-public.chromestart.getiscollapsed_.md renamed to docs/development/core/public/kibana-plugin-core-public.chromestart.getisnavdrawerlocked_.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
<!-- Do not edit this file. It is automatically generated by API Documenter. -->
22

3-
[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [ChromeStart](./kibana-plugin-core-public.chromestart.md) &gt; [getIsCollapsed$](./kibana-plugin-core-public.chromestart.getiscollapsed_.md)
3+
[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [ChromeStart](./kibana-plugin-core-public.chromestart.md) &gt; [getIsNavDrawerLocked$](./kibana-plugin-core-public.chromestart.getisnavdrawerlocked_.md)
44

5-
## ChromeStart.getIsCollapsed$() method
5+
## ChromeStart.getIsNavDrawerLocked$() method
66

7-
Get an observable of the current collapsed state of the chrome.
7+
Get an observable of the current locked state of the nav drawer.
88

99
<b>Signature:</b>
1010

1111
```typescript
12-
getIsCollapsed$(): Observable<boolean>;
12+
getIsNavDrawerLocked$(): Observable<boolean>;
1313
```
1414
<b>Returns:</b>
1515

docs/development/core/public/kibana-plugin-core-public.chromestart.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ core.chrome.setHelpExtension(elem => {
5656
| [getBrand$()](./kibana-plugin-core-public.chromestart.getbrand_.md) | Get an observable of the current brand information. |
5757
| [getBreadcrumbs$()](./kibana-plugin-core-public.chromestart.getbreadcrumbs_.md) | Get an observable of the current list of breadcrumbs |
5858
| [getHelpExtension$()](./kibana-plugin-core-public.chromestart.gethelpextension_.md) | Get an observable of the current custom help conttent |
59-
| [getIsCollapsed$()](./kibana-plugin-core-public.chromestart.getiscollapsed_.md) | Get an observable of the current collapsed state of the chrome. |
59+
| [getIsNavDrawerLocked$()](./kibana-plugin-core-public.chromestart.getisnavdrawerlocked_.md) | Get an observable of the current locked state of the nav drawer. |
6060
| [getIsVisible$()](./kibana-plugin-core-public.chromestart.getisvisible_.md) | Get an observable of the current visibility state of the chrome. |
6161
| [removeApplicationClass(className)](./kibana-plugin-core-public.chromestart.removeapplicationclass.md) | Remove a className added with <code>addApplicationClass()</code>. If className is unknown it is ignored. |
6262
| [setAppTitle(appTitle)](./kibana-plugin-core-public.chromestart.setapptitle.md) | Sets the current app's title |
@@ -65,6 +65,5 @@ core.chrome.setHelpExtension(elem => {
6565
| [setBreadcrumbs(newBreadcrumbs)](./kibana-plugin-core-public.chromestart.setbreadcrumbs.md) | Override the current set of breadcrumbs |
6666
| [setHelpExtension(helpExtension)](./kibana-plugin-core-public.chromestart.sethelpextension.md) | Override the current set of custom help content |
6767
| [setHelpSupportUrl(url)](./kibana-plugin-core-public.chromestart.sethelpsupporturl.md) | Override the default support URL shown in the help menu |
68-
| [setIsCollapsed(isCollapsed)](./kibana-plugin-core-public.chromestart.setiscollapsed.md) | Set the collapsed state of the chrome navigation. |
6968
| [setIsVisible(isVisible)](./kibana-plugin-core-public.chromestart.setisvisible.md) | Set the temporary visibility for the chrome. This does nothing if the chrome is hidden by default and should be used to hide the chrome for things like full-screen modes with an exit button. |
7069

docs/development/core/public/kibana-plugin-core-public.chromestart.setiscollapsed.md

Lines changed: 0 additions & 24 deletions
This file was deleted.

docs/development/plugins/data/server/kibana-plugin-plugins-data-server.icancel.md

Lines changed: 0 additions & 11 deletions
This file was deleted.
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<!-- Do not edit this file. It is automatically generated by API Documenter. -->
2+
3+
[Home](./index.md) &gt; [kibana-plugin-plugins-data-server](./kibana-plugin-plugins-data-server.md) &gt; [ISearchCancel](./kibana-plugin-plugins-data-server.isearchcancel.md)
4+
5+
## ISearchCancel type
6+
7+
<b>Signature:</b>
8+
9+
```typescript
10+
export declare type ISearchCancel<T extends TStrategyTypes> = (id: string) => Promise<void>;
11+
```

docs/development/plugins/data/server/kibana-plugin-plugins-data-server.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@
6767
| Type Alias | Description |
6868
| --- | --- |
6969
| [FieldFormatsGetConfigFn](./kibana-plugin-plugins-data-server.fieldformatsgetconfigfn.md) | |
70-
| [ICancel](./kibana-plugin-plugins-data-server.icancel.md) | |
7170
| [IFieldFormatsRegistry](./kibana-plugin-plugins-data-server.ifieldformatsregistry.md) | |
7271
| [ISearch](./kibana-plugin-plugins-data-server.isearch.md) | |
72+
| [ISearchCancel](./kibana-plugin-plugins-data-server.isearchcancel.md) | |
7373
| [ParsedInterval](./kibana-plugin-plugins-data-server.parsedinterval.md) | |
7474
| [TSearchStrategyProvider](./kibana-plugin-plugins-data-server.tsearchstrategyprovider.md) | Search strategy provider creates an instance of a search strategy with the request handler context bound to it. This way every search strategy can use whatever information they require from the request context. |
7575

docs/settings/monitoring-settings.asciidoc

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@ which support the same values as <<settings,{kib} configuration settings>>.
2020
To control how data is collected from your {es} nodes, you configure
2121
{ref}/monitoring-settings.html[`xpack.monitoring.collection`
2222
settings] in `elasticsearch.yml`. To control how monitoring data is collected
23-
from Logstash, you configure
24-
{logstash-ref}/monitoring-internal-collection.html#monitoring-settings[`xpack.monitoring` settings]
25-
in `logstash.yml`.
23+
from Logstash, configure monitoring settings in `logstash.yml`.
2624

2725
For more information, see
2826
{ref}/monitor-elasticsearch-cluster.html[Monitor a cluster].

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
"url": "https://github.com/elastic/kibana.git"
7878
},
7979
"resolutions": {
80-
"**/@types/node": "10.12.27",
80+
"**/@types/node": ">=10.17.17 <10.20.0",
8181
"**/@types/react": "^16.9.19",
8282
"**/@types/react-router": "^5.1.3",
8383
"**/@types/hapi": "^17.0.18",
@@ -119,7 +119,7 @@
119119
"@elastic/apm-rum": "^4.6.0",
120120
"@elastic/charts": "^17.1.1",
121121
"@elastic/datemath": "5.0.2",
122-
"@elastic/ems-client": "7.6.0",
122+
"@elastic/ems-client": "7.7.0",
123123
"@elastic/eui": "20.0.2",
124124
"@elastic/filesaver": "1.1.2",
125125
"@elastic/good": "8.1.1-kibana2",
@@ -239,7 +239,7 @@
239239
"react-resize-detector": "^4.2.0",
240240
"react-router-dom": "^5.1.2",
241241
"react-sizeme": "^2.3.6",
242-
"react-use": "^13.13.0",
242+
"react-use": "^13.27.0",
243243
"reactcss": "1.2.3",
244244
"redux": "^4.0.5",
245245
"redux-actions": "^2.6.5",
@@ -350,7 +350,7 @@
350350
"@types/mocha": "^5.2.7",
351351
"@types/moment-timezone": "^0.5.12",
352352
"@types/mustache": "^0.8.31",
353-
"@types/node": "^10.12.27",
353+
"@types/node": ">=10.17.17 <10.20.0",
354354
"@types/node-forge": "^0.9.0",
355355
"@types/normalize-path": "^3.0.0",
356356
"@types/numeral": "^0.0.26",

0 commit comments

Comments
 (0)