Skip to content

Preserve the original error name instead of returning raw AbortError #57550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 14, 2020
Merged

Preserve the original error name instead of returning raw AbortError #57550

merged 4 commits into from
Feb 14, 2020

Conversation

@pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Feb 13, 2020

Summary

Fix #56244

  • Add name attribute to HttpFetchError and initialize it with the underlying error
  • Stop handling AbortError as a special case in fetchResponse

Checklist

For maintainers

@pgayvallet pgayvallet added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Feature:New Platform v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Feb 13, 2020
@pgayvallet pgayvallet requested a review from a team as a code owner February 13, 2020 11:25
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 13, 2020

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet pgayvallet requested a review from a team February 13, 2020 11:26
@pgayvallet
Copy link
Contributor Author

pgayvallet commented Feb 13, 2020 •
edited
Loading

@lukasolson @kobelb does this need to be backported to 7.6.1 ?

@pgayvallet
Copy link
Contributor Author

pgayvallet commented Feb 13, 2020

retest

@lukasolson
Copy link
Contributor

lukasolson commented Feb 13, 2020

@pgayvallet No, 7.7 should be fine.

kobelb
kobelb approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this fixes the error that the Security plugins response error interceptor was previously throwing. Thanks @pgayvallet!

@kibanamachine
Copy link
Contributor

kibanamachine commented Feb 14, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 302c598 into elastic:master Feb 14, 2020
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Feb 14, 2020
@pgayvallet
Preserve the original error name instead of returning raw AbortError (e…
efce6bb 
…lastic#57550)

* Preserve the original error name instead of returning raw AbortError

* use Error as the default error name
@pgayvallet pgayvallet mentioned this pull request Feb 14, 2020
Merged
pgayvallet added a commit that referenced this pull request Feb 14, 2020
@pgayvallet
Preserve the original error name instead of returning raw AbortError (#…
6f6cc35 
…57550) (#57653)

* Preserve the original error name instead of returning raw AbortError

* use Error as the default error name
@lukasolson
Copy link
Contributor

lukasolson commented Feb 27, 2020 •
edited
Loading

Actually, it would be nice if we could get this in 7.6.1, how difficult would it be to backport this and #55061? (See #58749)

@pgayvallet
Copy link
Contributor Author

pgayvallet commented Feb 28, 2020

@lukasolson This one should be trivial to backport to 7.6.1. Not sure about #55061 though. @restrry ?

pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Feb 28, 2020
@pgayvallet
Preserve the original error name instead of returning raw AbortError (e…
08d8ee1 
…lastic#57550)

* Preserve the original error name instead of returning raw AbortError

* use Error as the default error name
@pgayvallet pgayvallet mentioned this pull request Feb 28, 2020
Merged
pgayvallet added a commit that referenced this pull request Feb 28, 2020
@pgayvallet
Preserve the original error name instead of returning raw AbortError (#…
1e6977f 
…57550) (#58842)

* Preserve the original error name instead of returning raw AbortError

* use Error as the default error name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kobelb kobelb kobelb approved these changes

+1 more reviewer

@mshustov mshustov mshustov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.6.1 v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Core HTTP fetch returns incorrect error when a request is aborted

6 participants

@pgayvallet @elasticmachine @lukasolson @kibanamachine @kobelb @mshustov