Skip to content

Deprecate chrome.navlinks.update and add documentation #54893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 17, 2020
Merged

Deprecate chrome.navlinks.update and add documentation #54893

merged 7 commits into from
Jan 17, 2020

Conversation

@pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Jan 15, 2020 •
edited
Loading

Follow up of #45291

  • deprecates chrome.navlinks.update in favor of using updater$ when registering an application
  • updates documentation and add migration example

@pgayvallet pgayvallet added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Feature:New Platform v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Jan 15, 2020
@pgayvallet pgayvallet requested a review from a team as a code owner January 15, 2020 10:37
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 15, 2020

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet
Copy link
Contributor Author

pgayvallet commented Jan 15, 2020

@elasticmachine merge upstream

@elasticmachine

This comment has been minimized.

Sign in to view
mshustov
mshustov approved these changes Jan 15, 2020
View reviewed changes
src/core/MIGRATION_EXAMPLES.md Outdated
```ts
// inside your plugin's setup function
export class MyPlugin implements Plugin {
private appUpdater = new BehaviorSubject<AppUpdater>(() => ({}));
Copy link
Contributor

@mshustov mshustov Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: appUpdater$

src/core/MIGRATION_EXAMPLES.md Outdated
start() {
// later, when the navlink needs to be updated
if(!isAvailable) {
appUpdater.next(() => {
Copy link
Contributor

@mshustov mshustov Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: probably we should provide updated version of the legacy code from https://github.com/elastic/kibana/pull/54893/files#diff-ca730ff688cc29f7cfb77853005355a1R478-R487 ?

const updater$ = license$.pipe(
  map(license => {
    const { hidden, disabled } = calcStatusFor(license);
    if (hidden) return { navLinkStatus: AppNavLinkStatus.hidden };
    if (disabled) return { navLinkStatus: AppNavLinkStatus.disabled };
    return { navLinkStatus: AppNavLinkStatus.default };
  })
);

Copy link
Contributor Author

@pgayvallet pgayvallet Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, was looking for that.

@pgayvallet pgayvallet changed the title Deprecate chrome.navlinks.update and add documentation [skip-ci] Deprecate chrome.navlinks.update and add documentation Jan 17, 2020
@pgayvallet
Copy link
Contributor Author

pgayvallet commented Jan 17, 2020

@elasticmachine merge upstream

@elasticmachine

This comment has been minimized.

Sign in to view
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 17, 2020

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 856c85b into elastic:master Jan 17, 2020
@pgayvallet pgayvallet mentioned this pull request Jan 17, 2020
Merged
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Jan 17, 2020
@pgayvallet
Deprecate chrome.navlinks.update and add documentation (elastic#54893)
61d6e91 
* add migration example on application status updater

* update example with proper licensing plugin usage

* fix line width
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 17, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into np/watcher/ou…
19ddfb8 
…t-of-legacy

* 'master' of github.com:elastic/kibana: (142 commits)
  [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069)
  Deprecate `chrome.navlinks.update` and add documentation (elastic#54893)
  [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045)
  [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864)
  [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015)
  [SIEM] Adds support for apm-* to the network map (elastic#54876)
  [Reporting] Define shims of legacy dependencies (elastic#54082)
  Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076)
  Upgraded EUI to 18.2.1 (elastic#55090)
  [Maps] Support styles on agg fields with _of_ in name (elastic#54965)
  Remove xpack_main requirement, it's no longer in use (elastic#55060)
  Fix Snapshots Policies Alignment Issue in IE11 (elastic#54866)
  first rule cuts (elastic#54990)
  [DOCS] Adds geocentroid note to coordinate map (elastic#54389)
  [Canvas] Fixes the Copy Post Url link (elastic#54831)
  Fixes bugs with full screen filters (elastic#54792)
  [ML] Fix decoding in the URL state  (elastic#54915)
  Remove redundant `x-pack/typings`. (elastic#55042)
  [SIEM][Detection Engine] Adds critical missing status route to prepackaged rules
  Generate legacy vars when rendering all applications (elastic#54768)
  ...

# Conflicts:
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
pgayvallet added a commit that referenced this pull request Jan 17, 2020
@pgayvallet
Deprecate chrome.navlinks.update and add documentation (#54893) (#5…
6a30fca 
…5168)

* add migration example on application status updater

* update example with proper licensing plugin usage

* fix line width
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
@pgayvallet @jkelastic
Deprecate chrome.navlinks.update and add documentation (elastic#54893)
ed8067c 
* add migration example on application status updater

* update example with proper licensing plugin usage

* fix line width
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 20, 2020
@gmmorris
Merge remote-tracking branch 'upstream/master'
edb0145 
* upstream/master: (83 commits)
  [Reporting] Fix map tiles not loading by using Chrome's Remote Protocol (elastic#55137)
  [Data Plugin] combine autocomplete provider and suggestions provider (elastic#54451)
  resolves elastic#53038 - remove references to specific license levels (elastic#53858)
  highlighting rules should still know about url parts when in sql state (elastic#55200)
  [Metric] convert mocha tests to jest (elastic#54054)
  [skip-ci] Update vector styling docs for 7.6 UI changes and new features (elastic#55087)
  Fix enable API to schedule task after alert is updated (elastic#55095)
  chore(NA): add 7.6 branch to the list of backport branches (elastic#54998)
  Convert tests to jest in vis_type_timeseries/public & common folders (elastic#55023)
  [ML] Accessibility fix for structural markup on table rows (elastic#55075)
  [Mappings editor] include/exclude fields only support custom options (elastic#54949)
  [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069)
  Deprecate `chrome.navlinks.update` and add documentation (elastic#54893)
  [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045)
  [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864)
  [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015)
  [SIEM] Adds support for apm-* to the network map (elastic#54876)
  [Reporting] Define shims of legacy dependencies (elastic#54082)
  Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076)
  Upgraded EUI to 18.2.1 (elastic#55090)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mshustov mshustov mshustov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pgayvallet @elasticmachine @kibanamachine @mshustov