Fix Snapshots Policies Alignment Issue in IE11 #54866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ied and tested on all 3 browsers.
cuff-links
added
release_note:skip
Contributor
|
@elasticmachine merge upstream |
Contributor
|
user doesn't have permission to update head repository |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
user doesn't have permission to update head repository |
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
@cuff-links thanks for fixing this! I had one suggestion related to your change.
.../plugins/snapshot_restore/public/app/sections/home/policy_list/policy_table/policy_table.tsx
Show resolved
Hide resolved
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
alisonelizabeth
approved these changes
Jan 16, 2020
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this @cuff-links!
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 17, 2020
…t-of-legacy * 'master' of github.com:elastic/kibana: (142 commits) [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069) Deprecate `chrome.navlinks.update` and add documentation (elastic#54893) [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045) [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864) [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015) [SIEM] Adds support for apm-* to the network map (elastic#54876) [Reporting] Define shims of legacy dependencies (elastic#54082) Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076) Upgraded EUI to 18.2.1 (elastic#55090) [Maps] Support styles on agg fields with _of_ in name (elastic#54965) Remove xpack_main requirement, it's no longer in use (elastic#55060) Fix Snapshots Policies Alignment Issue in IE11 (elastic#54866) first rule cuts (elastic#54990) [DOCS] Adds geocentroid note to coordinate map (elastic#54389) [Canvas] Fixes the Copy Post Url link (elastic#54831) Fixes bugs with full screen filters (elastic#54792) [ML] Fix decoding in the URL state (elastic#54915) Remove redundant `x-pack/typings`. (elastic#55042) [SIEM][Detection Engine] Adds critical missing status route to prepackaged rules Generate legacy vars when rendering all applications (elastic#54768) ... # Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
* Removed flex group because it's causing alignment issues on IE. Verified and tested on all 3 browsers. * Restored <EuiFlexItem> but added grow=false to properly align icons.
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Feb 19, 2020
* Removed flex group because it's causing alignment issues on IE. Verified and tested on all 3 browsers. * Restored <EuiFlexItem> but added grow=false to properly align icons.
This was referenced Feb 19, 2020
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Feb 19, 2020
* Removed flex group because it's causing alignment issues on IE. Verified and tested on all 3 browsers. * Restored <EuiFlexItem> but added grow=false to properly align icons.
cuff-links
pushed a commit
to cuff-links/kibana
that referenced
this pull request
Feb 19, 2020
* Removed flex group because it's causing alignment issues on IE. Verified and tested on all 3 browsers. * Restored <EuiFlexItem> but added grow=false to properly align icons.
cuff-links
pushed a commit
that referenced
this pull request
Feb 21, 2020
cuff-links
pushed a commit
that referenced
this pull request
Feb 25, 2020
* Removed flex group because it's causing alignment issues on IE. Verified and tested on all 3 browsers. * Restored <EuiFlexItem> but added grow=false to properly align icons. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
cuff-links
pushed a commit
that referenced
this pull request
Feb 27, 2020
* Removed flex group because it's causing alignment issues on IE. Verified and tested on all 3 browsers. * Restored <EuiFlexItem> but added grow=false to properly align icons. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49621 Removed flex group because it's causing alignment issues on IE. Verified and tested on all 3 browsers. Screenshot is of IE.