Skip to content

Do not remount applications between page navigations #53851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2019
Merged

Do not remount applications between page navigations #53851

merged 2 commits into from
Dec 30, 2019

Conversation

@joshdover
Copy link
Contributor

@joshdover joshdover commented Dec 30, 2019

Summary

Fixes #53835

  • Ensures that apps are not unmounted / mounted when navigating between pages in the same application.
  • Fixes syntax error in CSS for Kibana logo in loading spinner

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@joshdover joshdover added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Dec 30, 2019
@joshdover joshdover requested a review from a team as a code owner December 30, 2019 18:19
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 30, 2019

Pinging @elastic/kibana-platform (Team:Platform)

@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 30, 2019

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

eliperelman
eliperelman approved these changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@joshdover joshdover merged commit 884fba2 into elastic:master Dec 30, 2019
@joshdover joshdover deleted the np/fix-remount branch December 30, 2019 20:49
@joshdover joshdover mentioned this pull request Dec 30, 2019
Merged
@mshustov mshustov mentioned this pull request Dec 31, 2019
Closed
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 2, 2020
@gmmorris
Merge branch 'master' into alerting/zombie-tasks
6223180 
* master:
  Bump year in NOTICE.txt
  Add kibanamachine support to Github PR comments (elastic#53852)
  Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333)
  Skip failing test suite
  [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799)
  Do not remount applications between page navigations (elastic#53851)
  [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129)
  [Canvas] Migrate usage collector to NP plugin (elastic#53303)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 2, 2020
@gmmorris
Merge branch 'master' into alerting/created_at-and-updated_at
fe1902e 
* master:
  Bump year in NOTICE.txt
  Add kibanamachine support to Github PR comments (elastic#53852)
  Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333)
  Skip failing test suite
  [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799)
  Do not remount applications between page navigations (elastic#53851)
  [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129)
  [Canvas] Migrate usage collector to NP plugin (elastic#53303)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 2, 2020
@gmmorris
Merge branch 'master' into alerting/client-types
fa3e74f 
* master:
  Bump year in NOTICE.txt
  Add kibanamachine support to Github PR comments (elastic#53852)
  Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333)
  Skip failing test suite
  [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799)
  Do not remount applications between page navigations (elastic#53851)
  [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129)
  [Canvas] Migrate usage collector to NP plugin (elastic#53303)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 2, 2020
@gmmorris
Merge branch 'master' into task-manager/schema-config
4246b94 
* master:
  Fix suggested value for time_zone in range query (elastic#53841)
  Clean up generic hooks, use react-use instead (elastic#53822)
  Bump year in NOTICE.txt
  Add kibanamachine support to Github PR comments (elastic#53852)
  Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333)
  Skip failing test suite
  [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799)
  Do not remount applications between page navigations (elastic#53851)
  [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129)
  [Canvas] Migrate usage collector to NP plugin (elastic#53303)
mshustov pushed a commit that referenced this pull request Jan 8, 2020
@joshdover @elasticmachine @mshustov
Do not remount applications between page navigations (#53851) (#53855)
7374f79 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 8, 2020
@joshdover @jkelastic
Do not remount applications between page navigations (elastic#53851)
7d878f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eliperelman eliperelman eliperelman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backported Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] NP apps are always unmounted when back button is pressed

5 participants

@joshdover @elasticmachine @kibanamachine @eliperelman @mshustov