Skip to content

[Chore] Clean up generic hooks, use react-use instead #53822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 2, 2020
Merged

[Chore] Clean up generic hooks, use react-use instead #53822

merged 4 commits into from
Jan 2, 2020

Conversation

@Dosant
Copy link
Contributor

@Dosant Dosant commented Dec 27, 2019 •
edited
Loading

Summary

As we recently added react-use as a dependency, makes sense to clean up those generic hooks from Kibana repo.

Dev Docs

Removed custom hooks from kibana_react:

  • useObservable
  • useUnmount
  • useShallowCompareEffect

react-use should be used instead

import useObservable from 'react-use/lib/useObservable'

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@Dosant Dosant changed the title Remove generic hook, use react-use instead [Chore] Remove generic hook, use react-use instead Dec 27, 2019
@Dosant Dosant changed the title [Chore] Remove generic hook, use react-use instead [Chore] Clean up generic hooks, use react-use instead Dec 27, 2019
@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 27, 2019

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant marked this pull request as ready for review December 27, 2019 14:50
@Dosant Dosant requested review from a team as code owners December 27, 2019 14:50
@Dosant Dosant requested a review from streamich December 27, 2019 14:50
@Dosant Dosant self-assigned this Dec 27, 2019
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 27, 2019

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant added the release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. label Dec 27, 2019
streamich
streamich approved these changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@Dosant
Copy link
Contributor Author

Dosant commented Dec 28, 2019

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 28, 2019

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant
Copy link
Contributor Author

Dosant commented Dec 30, 2019

@elasticmachine merge upstream

@afgomez afgomez self-requested a review December 30, 2019 10:10
afgomez
afgomez approved these changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra changes LGTM

walterra
walterra approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

@Dosant
Copy link
Contributor Author

Dosant commented Jan 2, 2020

@elasticmachine merge upstream

lizozom
lizozom approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 2, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dgieselaar
dgieselaar approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM

@Dosant Dosant merged commit dcb8cca into elastic:master Jan 2, 2020
@Dosant Dosant deleted the dev/remove-generic-hooks branch January 2, 2020 11:04
@Dosant Dosant mentioned this pull request Jan 2, 2020
Merged
Dosant added a commit to Dosant/kibana that referenced this pull request Jan 2, 2020
@Dosant
Clean up generic hooks, use react-use instead (elastic#53822)
f7cdcdf 
As we recently added react-use as a dependency, makes sense to clean up those generic hooks from Kibana repo.

Removed custom hooks from kibana_react and other places:
useObservable
useUnmount
useShallowCompareEffect

react-use should be used instead:
import useObservable from 'react-use/lib/useObservable'
# Conflicts:
#	src/plugins/kibana_react/public/index.ts
#	x-pack/legacy/plugins/apm/public/context/LicenseContext/index.tsx
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 2, 2020
@gmmorris
Merge branch 'master' into task-manager/schema-config
4246b94 
* master:
  Fix suggested value for time_zone in range query (elastic#53841)
  Clean up generic hooks, use react-use instead (elastic#53822)
  Bump year in NOTICE.txt
  Add kibanamachine support to Github PR comments (elastic#53852)
  Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333)
  Skip failing test suite
  [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799)
  Do not remount applications between page navigations (elastic#53851)
  [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129)
  [Canvas] Migrate usage collector to NP plugin (elastic#53303)
Dosant added a commit that referenced this pull request Jan 3, 2020
@Dosant
[7.x] Clean up generic hooks, use react-use instead (#53822) (#53884)
c3f1d97 
* Clean up generic hooks, use react-use instead (#53822)

As we recently added react-use as a dependency, makes sense to clean up those generic hooks from Kibana repo.

Removed custom hooks from kibana_react and other places:
useObservable
useUnmount
useShallowCompareEffect

react-use should be used instead:
import useObservable from 'react-use/lib/useObservable'
# Conflicts:
#	src/plugins/kibana_react/public/index.ts
#	x-pack/legacy/plugins/apm/public/context/LicenseContext/index.tsx

* fix merge
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 3, 2020
@gmmorris
Merge branch 'master' into alerting/zombie-tasks
cb652c8 
* master:
  Rename `/api/security/oidc` to `/api/security/oidc/callback`. (elastic#53886)
  Updating transitive dependencies to use handlebars@4.5.3 (elastic#53899)
  [Reporting/Tests] consolidate functional test configs (elastic#52671)
  [Reporting] Correct the docvalue_fields params in the search query Download CSV from Dashboard Panel (elastic#52833)
  [Test/Newsfeed] Re-enable test and add news item to be filtered (elastic#53905)
  cleanup server-log action (elastic#53326)
  [Uptime] Delete uptime eslint rule skip (elastic#50912)
  [skip-ci] Expression Lifecycle Docs (elastic#51494)
  [Endpoint] add react router to endpoint app (elastic#53808)
  [SIEM][Detection Engine] Silence 409 errors on signal creation (elastic#53859)
  [Maps] get max_result_window and max_inner_result_window from index settings (elastic#53500)
  [ML] New Platform server shim: update analytics routes to use new platform router (elastic#53521)
  fixes typo on engine detection page (elastic#53877)
  [Maps] push mapbox value extraction from VectorStyle and into DynamicStyleProperty (elastic#53806)
  Fix suggested value for time_zone in range query (elastic#53841)
  Clean up generic hooks, use react-use instead (elastic#53822)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 3, 2020
@gmmorris
Merge branch 'alerting/created_at-and-updated_at' of github.com:gmmor…
dbd61a7 
…ris/kibana into alerting/created_at-and-updated_at

* 'alerting/created_at-and-updated_at' of github.com:gmmorris/kibana:
  Rename `/api/security/oidc` to `/api/security/oidc/callback`. (elastic#53886)
  Updating transitive dependencies to use handlebars@4.5.3 (elastic#53899)
  [Reporting/Tests] consolidate functional test configs (elastic#52671)
  [Reporting] Correct the docvalue_fields params in the search query Download CSV from Dashboard Panel (elastic#52833)
  [Test/Newsfeed] Re-enable test and add news item to be filtered (elastic#53905)
  cleanup server-log action (elastic#53326)
  [Uptime] Delete uptime eslint rule skip (elastic#50912)
  [skip-ci] Expression Lifecycle Docs (elastic#51494)
  [Endpoint] add react router to endpoint app (elastic#53808)
  [SIEM][Detection Engine] Silence 409 errors on signal creation (elastic#53859)
  [Maps] get max_result_window and max_inner_result_window from index settings (elastic#53500)
  [ML] New Platform server shim: update analytics routes to use new platform router (elastic#53521)
  fixes typo on engine detection page (elastic#53877)
  [Maps] push mapbox value extraction from VectorStyle and into DynamicStyleProperty (elastic#53806)
  Fix suggested value for time_zone in range query (elastic#53841)
  Clean up generic hooks, use react-use instead (elastic#53822)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 3, 2020
@gmmorris
Merge branch 'alerting/created_at-and-updated_at' into alerting/clien…
b04189e 
…t-types

* alerting/created_at-and-updated_at:
  updatedAt should equal createdAt on creation
  Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data (elastic#53794)
  moved Task Manager server code under "server" directory (elastic#53777)
  Rename `/api/security/oidc` to `/api/security/oidc/callback`. (elastic#53886)
  Updating transitive dependencies to use handlebars@4.5.3 (elastic#53899)
  [Reporting/Tests] consolidate functional test configs (elastic#52671)
  [Reporting] Correct the docvalue_fields params in the search query Download CSV from Dashboard Panel (elastic#52833)
  [Test/Newsfeed] Re-enable test and add news item to be filtered (elastic#53905)
  cleanup server-log action (elastic#53326)
  [Uptime] Delete uptime eslint rule skip (elastic#50912)
  [skip-ci] Expression Lifecycle Docs (elastic#51494)
  [Endpoint] add react router to endpoint app (elastic#53808)
  [SIEM][Detection Engine] Silence 409 errors on signal creation (elastic#53859)
  [Maps] get max_result_window and max_inner_result_window from index settings (elastic#53500)
  [ML] New Platform server shim: update analytics routes to use new platform router (elastic#53521)
  fixes typo on engine detection page (elastic#53877)
  [Maps] push mapbox value extraction from VectorStyle and into DynamicStyleProperty (elastic#53806)
  Fix suggested value for time_zone in range query (elastic#53841)
  Clean up generic hooks, use react-use instead (elastic#53822)
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 8, 2020
@Dosant @jkelastic
Clean up generic hooks, use react-use instead (elastic#53822)
e653aaa 
As we recently added react-use as a dependency, makes sense to clean up those generic hooks from Kibana repo.

Removed custom hooks from kibana_react and other places:
useObservable
useUnmount
useShallowCompareEffect

react-use should be used instead:
import useObservable from 'react-use/lib/useObservable'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

+3 more reviewers

@afgomez afgomez afgomez approved these changes

@lizozom lizozom lizozom approved these changes

@streamich streamich streamich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Dosant Dosant

Labels

chore release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. review v7.6.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Dosant @kibanamachine @elasticmachine @afgomez @walterra @dgieselaar @lizozom @streamich