Skip to content

[7.x] [Logs + Metrics UI] Add missing headers in Logs & metrics (#52405) #52728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2019
Merged

[7.x] [Logs + Metrics UI] Add missing headers in Logs & metrics (#52405) #52728

merged 1 commit into from
Dec 11, 2019

Conversation

@afgomez
Copy link
Contributor

@afgomez afgomez commented Dec 11, 2019

Backports the following commits to 7.x:

@elasticmachine
[Logs + Metrics UI] Add missing headers in Logs & metrics (elastic#52405
f264eec 
)

* Fix broken aria references

`EuiDescribedFormGroup` needs an actual header in its `title` for it to
make a correct `aria-labelledby`.

* Fix `aria-labelledby` references in settings page


Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@afgomez afgomez added the backport This PR is a backport of another PR label Dec 11, 2019
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 11, 2019

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit d6eb7c0 into elastic:7.x Dec 11, 2019
@afgomez afgomez deleted the backport/7.x/pr-52405 branch December 11, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@afgomez @elasticmachine