Skip to content

Commit d6eb7c0

Browse files
Alejandro Fernándezelasticmachine
andauthored
[7.x] [Logs + Metrics UI] Add missing headers in Logs & metric… (#52728)
* Fix broken aria references `EuiDescribedFormGroup` needs an actual header in its `title` for it to make a correct `aria-labelledby`. * Fix `aria-labelledby` references in settings page Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
1 parent b0dcd86 commit d6eb7c0

File tree

5 files changed

+58
-38
lines changed

5 files changed

+58
-38
lines changed

x-pack/legacy/plugins/infra/public/components/source_configuration/fields_configuration_panel.tsx

Lines changed: 30 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,12 @@ export const FieldsConfigurationPanel = ({
5050
<EuiDescribedFormGroup
5151
idAria="timestampField"
5252
title={
53-
<FormattedMessage
54-
id="xpack.infra.sourceConfiguration.timestampFieldLabel"
55-
defaultMessage="Timestamp"
56-
/>
53+
<h4>
54+
<FormattedMessage
55+
id="xpack.infra.sourceConfiguration.timestampFieldLabel"
56+
defaultMessage="Timestamp"
57+
/>
58+
</h4>
5759
}
5860
description={
5961
<FormattedMessage
@@ -95,10 +97,12 @@ export const FieldsConfigurationPanel = ({
9597
<EuiDescribedFormGroup
9698
idAria="tiebreakerField"
9799
title={
98-
<FormattedMessage
99-
id="xpack.infra.sourceConfiguration.tiebreakerFieldLabel"
100-
defaultMessage="Tiebreaker"
101-
/>
100+
<h4>
101+
<FormattedMessage
102+
id="xpack.infra.sourceConfiguration.tiebreakerFieldLabel"
103+
defaultMessage="Tiebreaker"
104+
/>
105+
</h4>
102106
}
103107
description={
104108
<FormattedMessage
@@ -140,10 +144,12 @@ export const FieldsConfigurationPanel = ({
140144
<EuiDescribedFormGroup
141145
idAria="containerField"
142146
title={
143-
<FormattedMessage
144-
id="xpack.infra.sourceConfiguration.containerFieldLabel"
145-
defaultMessage="Container ID"
146-
/>
147+
<h4>
148+
<FormattedMessage
149+
id="xpack.infra.sourceConfiguration.containerFieldLabel"
150+
defaultMessage="Container ID"
151+
/>
152+
</h4>
147153
}
148154
description={
149155
<FormattedMessage
@@ -185,10 +191,12 @@ export const FieldsConfigurationPanel = ({
185191
<EuiDescribedFormGroup
186192
idAria="hostNameField"
187193
title={
188-
<FormattedMessage
189-
id="xpack.infra.sourceConfiguration.hostNameFieldLabel"
190-
defaultMessage="Host name"
191-
/>
194+
<h4>
195+
<FormattedMessage
196+
id="xpack.infra.sourceConfiguration.hostNameFieldLabel"
197+
defaultMessage="Host name"
198+
/>
199+
</h4>
192200
}
193201
description={
194202
<FormattedMessage
@@ -230,10 +238,12 @@ export const FieldsConfigurationPanel = ({
230238
<EuiDescribedFormGroup
231239
idAria="podField"
232240
title={
233-
<FormattedMessage
234-
id="xpack.infra.sourceConfiguration.podFieldLabel"
235-
defaultMessage="Pod ID"
236-
/>
241+
<h4>
242+
<FormattedMessage
243+
id="xpack.infra.sourceConfiguration.podFieldLabel"
244+
defaultMessage="Pod ID"
245+
/>
246+
</h4>
237247
}
238248
description={
239249
<FormattedMessage

x-pack/legacy/plugins/infra/public/components/source_configuration/indices_configuration_panel.tsx

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,14 @@ export const IndicesConfigurationPanel = ({
4242
</EuiTitle>
4343
<EuiSpacer size="m" />
4444
<EuiDescribedFormGroup
45-
idAria="matricIndices"
45+
idAria="metricIndices"
4646
title={
47-
<FormattedMessage
48-
id="xpack.infra.sourceConfiguration.metricIndicesTitle"
49-
defaultMessage="Metric indices"
50-
/>
47+
<h4>
48+
<FormattedMessage
49+
id="xpack.infra.sourceConfiguration.metricIndicesTitle"
50+
defaultMessage="Metric indices"
51+
/>
52+
</h4>
5153
}
5254
description={
5355
<FormattedMessage
@@ -90,10 +92,12 @@ export const IndicesConfigurationPanel = ({
9092
<EuiDescribedFormGroup
9193
idAria="logIndices"
9294
title={
93-
<FormattedMessage
94-
id="xpack.infra.sourceConfiguration.logIndicesTitle"
95-
defaultMessage="Log indices"
96-
/>
95+
<h4>
96+
<FormattedMessage
97+
id="xpack.infra.sourceConfiguration.logIndicesTitle"
98+
defaultMessage="Log indices"
99+
/>
100+
</h4>
97101
}
98102
description={
99103
<FormattedMessage

x-pack/legacy/plugins/infra/public/components/source_configuration/name_configuration_panel.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,9 @@ export const NameConfigurationPanel = ({
4141
<EuiDescribedFormGroup
4242
idAria="name"
4343
title={
44-
<FormattedMessage id="xpack.infra.sourceConfiguration.nameLabel" defaultMessage="Name" />
44+
<h4>
45+
<FormattedMessage id="xpack.infra.sourceConfiguration.nameLabel" defaultMessage="Name" />
46+
</h4>
4547
}
4648
description={
4749
<FormattedMessage

x-pack/legacy/plugins/infra/public/pages/logs/analysis/setup/initial_configuration_step/analysis_setup_indices_form.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,12 @@ export const AnalysisSetupIndicesForm: React.FunctionComponent<{
6262
<EuiDescribedFormGroup
6363
idAria="indices"
6464
title={
65-
<FormattedMessage
66-
id="xpack.infra.analysisSetup.indicesSelectionTitle"
67-
defaultMessage="Choose indices"
68-
/>
65+
<h3>
66+
<FormattedMessage
67+
id="xpack.infra.analysisSetup.indicesSelectionTitle"
68+
defaultMessage="Choose indices"
69+
/>
70+
</h3>
6971
}
7072
description={
7173
<FormattedMessage

x-pack/legacy/plugins/infra/public/pages/logs/analysis/setup/initial_configuration_step/analysis_setup_timerange_form.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,12 @@ export const AnalysisSetupTimerangeForm: React.FunctionComponent<{
6363
<EuiDescribedFormGroup
6464
idAria="timeRange"
6565
title={
66-
<FormattedMessage
67-
id="xpack.infra.analysisSetup.timeRangeTitle"
68-
defaultMessage="Choose a time range"
69-
/>
66+
<h3>
67+
<FormattedMessage
68+
id="xpack.infra.analysisSetup.timeRangeTitle"
69+
defaultMessage="Choose a time range"
70+
/>
71+
</h3>
7072
}
7173
description={
7274
<FormattedMessage

0 commit comments

Comments
 (0)