Update hapi related packages #48026

renovate · 2019-10-11T20:31:56Z

This PR contains the following updates:

Package	Type	Update	Change
@hapi/wreck	dependencies	minor	`^15.0.1` -> `^15.1.0`
@types/boom	devDependencies	minor	`^7.2.0` -> `^7.3.0`
@types/boom	devDependencies	minor	`7.2.1` -> `7.3.0`
@types/hapi	devDependencies	major	`^17.0.18` -> `^18.0.2`
@types/hapi-auth-cookie	devDependencies	major	`^9.1.0` -> `^10.0.0`
@types/joi	devDependencies	major	`^13.4.2` -> `^14.3.3`
apollo-server-hapi	dependencies	major	`^1.3.6` -> `^2.9.6`
boom	dependencies	minor	`^7.2.0` -> `^7.3.0`
good-squeeze	dependencies	major	`2.1.0` -> `5.1.0`
h2o2	dependencies	minor	`^8.1.2` -> `^8.2.0`
hapi (source)	devDependencies	major	`^17.5.3` -> `^18.1.0`
hapi (source)	dependencies	major	`^17.5.3` -> `^18.1.0`
hapi-auth-cookie	dependencies	major	`^9.0.0` -> `^10.0.0`
hoek	dependencies	major	`^5.0.4` -> `^6.1.3`
inert	dependencies	patch	`^5.1.0` -> `^5.1.3`
joi	dependencies	major	`^13.5.2` -> `^14.3.1`
joi	peerDependencies	major	`^13.5.2` -> `^14.3.1`

Release Notes

hapijs/wreck

`v15.1.0`

Compare Source

`v15.0.2`

Compare Source

apollographql/apollo-server

apollo-server-express: Add direct dependency on express to allow for usage of express.Router for getMiddleware functionality (from #2435). Previously, unlike other server integration packages, apollo-server-express did not directly need express as a dependency since it only relied on express for TypeScript typings. Issue #3238 PR #3239
apollo-server-lambda: Add @types/aws-lambda as a direct dependency to apollo-server-express to allow usage of its typings without needing to separately install it. Issue #2351 PR #3242

`v2.9.2`

Compare Source

apollo-server-koa: Drop support for Node.js v6 within the Apollo Server Koa integration in order to update koa-bodyparser dependency from v3.0.0 to v4.2.1. PR #TODO Issue #3050 PR #3229
apollo-server-express: Use explicit return type for new getMiddleware method, in an effort to resolve Issue #3222 PR #3230

`v2.9.1`

Compare Source

apollo-server-core: Make formatError available to subscriptions in the same spirit as the existing formatResponse. PR #2942
apollo-engine-reporting: The behavior of the engine.maxAttempts parameter previously did not match its documentation. It is documented as being the max number of attempts including the initial attempt, but until this release it was actually the number of retries excluding the initial attempt. The behavior has been changed to match the documentation (and the literal reading of the option name). PR #3218
apollo-engine-reporting: When sending the report fails with a server-side 5xx error, include the full error from the server in the logs. PR #3218
apollo-server-core: Fix regression which prevented the resizing of the schema panel in GraphQL Playground. PR #3224 and upstream

`v2.9.0`

Compare Source

apollo-server-express, apollo-server-koa: A new getMiddleware method has been introduced, which accepts the same parameters as applyMiddleware with the exception of the app property. This allows implementors to obtain the middleware directly and "use" it within an existing app. In the near-term, this should ease some of the pain points with the previous technique. Longer-term, we are exploring what we consider to be a much more natural approach by introducing an "HTTP transport" in Apollo Server 3.x. See this proposal issue for more information. PR #2435
@apollo/federation: buildFederatedSchema's typeDefs parameter now accepts arrays of DocumentNodes (i.e. type definitions wrapped in gql) and resolvers to make the migration from a single service into a federated service easier for teams previously utilizing this pattern. PR #3188

`v2.8.2`

Compare Source

apollo-server-koa: Update dependency koa to v2.8.1. PR #3175
apollo-server-express: Update types exported by the ASE package. PR #3173 PR #3172

`v2.8.1`

Compare Source

apollo-engine-reporting: Fix reporting errors which have non-array path fields (eg, non-GraphQLError errors). PR #3112
apollo-engine-reporting: Add missing apollo-server-caching dependency. PR #3054
apollo-server-hapi: Revert switch from accept and boom which took place in v2.8.0. PR #3089
@apollo/gateway: Change the setInterval timer, which is used to continuously check for updates to a federated graph from the Apollo Graph Manager, to be an unref'd timer. Without this change, the server wouldn't terminate properly once polling had started since the event-loop would continue to have unprocessed events on it. PR #3105
Switch to using community @types/graphql-upload types.
apollo-server-fastify: Change the typing of the HTTP response from OutgoingMessage to ServerResponse. Commit
apollo-server-hapi: Pass the raw request and response objects to graphql-uploads processRequest method to align on the same TypeScript types. Commit

`v2.8.0`

Compare Source

@apollo/federation: Add support for "value types", which are type definitions which live on multiple services' types, inputs, unions or interfaces. These common types must be identical by name, kind and field across all services. PR #3063
apollo-server-express: Use the Express send method, rather than calling net.Socket.prototype.end. PR #2842
apollo-server-hapi: Update internal dependencies to use scoped packages @hapi/accept and @hapi/boom, in place of accept and boom respectively. PR #3089

`v2.7.2`

Compare Source

apollo-engine-reporting: Fix reporting errors from backend. (The support for federated metrics introduced in v2.7.0 did not properly handle GraphQL errors from the backend; all users of federated metrics should upgrade to this version.) PR #3056 Issue #3052
apollo-engine-reporting: Clean up SIGINT and SIGTERM handlers when EngineReportingAgent is stopped; fixes 'Possible EventEmitter memory leak detected' log. PR #3090

`v2.7.1`

Compare Source

apollo-engine-reporting: If an error is thrown by a custom variable transform function passed into the reporting option sendVariableValues: { transform: ... }, all variable values will be replaced with the string [PREDICATE_FUNCTION_ERROR].
apollo-server-express: Typing fix for the connection property, which was missing from the ExpressContext interface. PR #2959
@apollo/gateway: Ensure execution of correct document within multi-operation documents by including the operationName in the cache key used when caching query plans used in federated execution. PR #3084

`v2.7.0`

Compare Source

apollo-engine-reporting: Behavior change: By default, send no GraphQL variable values to Apollo's servers instead of sending all variable values. Adding the new EngineReportingOption sendVariableValues to send some or all variable values, possibly after transforming them. This replaces the privateVariables option, which is now deprecated. PR #2931

To maintain the previous behavior of transmitting all GraphQL variable values, unfiltered, to Apollo Engine, configure engine.sendVariableValues as follows:
```
engine: {
  sendVariableValues: { all: true }
}
```
apollo-engine-reporting: Behavior change: By default, send no GraphQL request headers and values to Apollo's servers instead of sending all. Adding the new EngineReportingOption sendHeaders to send some or all header values. This replaces the privateHeaders option, which is now deprecated. PR #2931

To maintain the previous behavior of transmitting all GraphQL request headers and values, configure engine.sendHeaders as following:
```
engine: {
  sendHeaders: { all: true }
}
```
apollo-engine-reporting: Behavior change: If the error returned from the engine.rewriteError hook has an extensions property, that property will be used instead of the original error's extensions. Document that changes to most other GraphQLError fields by engine.rewriteError are ignored. PR #2932
apollo-engine-reporting: Behavior change: The engine.maskErrorDetails option, deprecated by engine.rewriteError in v2.5.0, now behaves a bit more like the new option: while all error messages will be redacted, they will still show up on the appropriate nodes in a trace. PR #2932
apollo-server-core, @apollo/gateway: Introduced managed federation support. For more information on managed federation, see the blog post or jump to the documentation for managed federation.
@apollo/gateway@0.7.1: Don't print a warning about an unspecified "graph variant" (previously, and in many ways still, known as "schema tag") every few seconds. We do highly recommend specifying one when using the Apollo Platform features though! PR #3043
graphql-playground: Update to resolve incorrect background color on tabs when using the light theme. PR #2989 Issue #2979
graphql-playground: Fix "Query Planner" and "Tracing" panels which were off the edge of the viewport.
apollo-server-plugin-base: Fix GraphQLRequestListener type definitions to allow return void. PR #2368

`v2.6.9`

Compare Source

`v2.6.8`

Compare Source

`v2.6.7`

Compare Source

apollo-server-core: Guard against undefined property access in isDirectiveDefined which resulted in "Cannot read property 'some' of undefined" error. PR #2924 Issue #2921

`v2.6.6`

Compare Source

apollo-server-core: Avoid duplicate cacheControl directives being added via isDirectiveDefined, re-landing the implementation reverted in v2.6.1 which first surfaced in v2.6.0. PR #2762 Reversion PR #2754 Original PR #2428
apollo-server-testing: Add TypeScript types for apollo-server-testing client. PR #2871
apollo-server-plugin-response-cache: Fix undefined property access attempt which occurred when an incomplete operation was received. PR #2792 Issue #2745

`v2.6.5`

Compare Source

apollo-engine-reporting: Simplify the technique for capturing operationName. PR #2899
apollo-server-core: Fix regression in 2.6.0 which caused engine: false not to disable Engine when the ENGINE_API_KEY environment variable was set. PR #2850
@apollo/federation: Introduced a README.md. PR #2883
@apollo/gateway: Introduced a README.md. PR #2883

`v2.6.4`

Compare Source

@apollo/gateway: Pass context through to the graphql command in LocalGraphQLDataSource's process method. PR #2821
@apollo/gateway: Fix gateway not sending needed variables for subqueries not at the root level. PR #2867
@apollo/federation: Allow matching enums/scalars in separate services and validate that enums have matching values. PR #2829.
@apollo/federation: Strip @external fields from interface extensions. PR #2848
@apollo/federation: Add support for list type keys in federation. PR #2841
@apollo/federation: Deduplicate variable definitions for sub-queries. PR #2840

`v2.6.3`

Compare Source

apollo-engine-reporting: Set forbiddenOperation and registeredOperation later in the request lifecycle. PR #2828
apollo-server-core: Add queryHash to GraphQLExecutor for federation. PR #2822
@apollo/federation: Preserve descriptions from SDL of federated services. PR #2830

`v2.6.2`

Compare Source

apollo-engine-reporting-protobuf: Update protobuf to include forbiddenOperations and registeredOperations. PR #2768
apollo-server-core: Add forbiddenOperation and registeredOperation to GraphQLRequestMetrics type. PR #2768
apollo-engine-reporting: Set forbiddenOperation and registeredOperation on trace if the field is true on requestContext.metrics. PR #2768
apollo-server-lambda: Remove Object.fromEntries usage. PR #2787

`v2.6.1`

Compare Source

Revert: Don't add cacheControl directive if one has already been defined. Presently, although the TypeScript don't suggest it, passing a String as typeDefs to ApolloServer is supported and this would be a breaking change for non-TypeScript users. PR #2428

`v2.6.0`

Compare Source

apollo-server-core: Introduce new didEncounterErrors life-cycle hook which has access to unformatted errors property on the requestContext, which is the first positional parameter that this new request life-cycle receives. PR #2719
apollo-server-core: Allow request pipeline life-cycle hooks (i.e. plugins) to modify the response's http.status code (an integer) in the event of an error. When combined with the new didEncounterErrors life-cycle hook (see above), this will allow modifying the HTTP status code in the event of an error. PR #2714
apollo-server-lambda: Set callbackWaitsForEmptyEventLoop to false for OPTIONS requests to return as soon as the callback is triggered instead of waiting for the event loop to empty. PR #2638
apollo-server: Support onHealthCheck in the ApolloServer constructor in the same way as cors is supported. This contrasts with the -express, -hapi, etc. variations which accept this parameter via their applyMiddleware methods and will remain as-is. PR #2672
core: Expose SHA-512 hex hash digest of the Engine API key to plugins, when available, as engine.apiKeyHash. PR #2685 PR #2736
apollo-datasource-rest: If another Content-type is already set on the response, don't overwrite it with application/json, allowing the user's initial Content-type to prevail. PR #2520
Don't add cacheControl directive if one has already been defined. PR #2428
apollo-cache-control: Do not respond with Cache-control headers if the HTTP response contains errors. PR #2715
apollo-server-core: Skip loading util.promisify polyfill in Node.js engines >= 8.0 PR #2278
apollo-server-core: Lazy load subscriptions-transport-ws in core PR #2278
apollo-server-cache-redis: BREAKING FOR USERS OF apollo-server-cache-redis (This is a package that must be updated separately but shares the same CHANGELOG.md with Apollo Server itself.) A new major version of this package has been published and updated to support Redis Standalone, Cluster and Sentinel modes. This is a breaking change since it is now based on ioredis instead of node_redis. Although this update is compatible with the most common uses of apollo-server-cache-redis, please check the options supported by ioredis while updating to this version. The constructor options are passed directly from RedisCache to the new Redis adapter. The pre-1.0 versions should continue to work with Apollo Server without modification. PR #1770

`v2.5.1`

Compare Source

Upgrade GraphQL Playground to the latest upstream release. This release also includes a new "Query Plan" panel for displaying the query planning results when running the Apollo Gateway.

`v2.5.0`

Compare Source

New

New plugin package apollo-server-plugin-response-cache implementing a full query response cache based on apollo-cache-control hints. The implementation added a few hooks and context fields; see the PR for details. There is a slight change to cacheControl object: previously, cacheControl.stripFormattedExtensions defaulted to false if you did not provide a cacheControl option object, but defaulted to true if you provided (eg) cacheControl: {defaultMaxAge: 10}. Now stripFormattedExtensions defaults to false unless explicitly provided as true, or if you use the legacy boolean cacheControl: true. For more information, read the documentation. PR #2437
Add rewriteError option to EngineReportingOptions (i.e. the engine property of the ApolloServer constructor). When defined as a function, it will receive an err property as its first argument which can be used to manipulate (e.g. redaction) an error prior to sending it to Apollo Engine by modifying, e.g., its message property. The error can also be suppressed from reporting entirely by returning an explicit null value. For more information, read the documentation and the EngineReportingOptions API reference. maskErrorDetails is now deprecated. PR #1639
apollo-server-azure-functions: Support @azure/functions to enable Apollo Server Typescript development in Azure Functions. PR #2487
Allow GraphQLRequestListener callbacks in plugins to depend on this. PR #2470
apollo-server-testing: Add variables and operationName to Query and Mutation types. PR #2307 Issue #2172

Bug fixes

Add cache-control: no-cache header to both PersistedQueryNotSupportedError and PersistedQueryNotFoundError responses as these should never be cached. PR #2452
apollo-datasource-rest: Don't attempt to parse "204 No Content" responses as JSON. PR #2446
apollo-server-express: Fix Playground URL when Apollo Server is mounted inside of another Express app by utilizing req.originalUrl. PR #2451
apollo-datasource-rest: Correctly allow a TTL value of 0 to represent "not-cacheable". PR #2588
apollo-datasource-rest: Fix Invalid argument in IE11, when this.headers is undefined. PR #2607

`v2.4.8`

Compare Source

No functional changes in this version. The patch version has been bumped to fix the README.md displayed on the npm package for apollo-server as a result of a broken publish. Apologies for the additional noise!

`v2.4.7`

Compare Source

Fix typings which incorrectly included cors as part of the constructor options for apollo-server-express (it should be defined via applyMiddleware) but, conversely, inadvertently omitted the perfectly valid cors option from the apollo-server constructor (where applyMiddleware is not used/available). PR #2373 Issue #1882

`v2.4.6`

Compare Source

Allow Node.js-like runtimes to identify as Node.js as well. PR #2357 Issue #2356

`v2.4.4`

Compare Source

Fix typing for ContextFunction incorrectly requiring the context object the function produces to match the parameters of the function PR #2350

`v2.4.3`

Compare Source

apollo-server-lambda: Fix typings which triggered "Module has no default export" errors. PR #2230
apollo-server-koa: Support OPTIONS requests PR #2288
Add req and res typings to the ContextFunction argument for apollo-server and apollo-server-express. Update ContextFunction return type to allow returning a value syncronously. PR #2330
Type the formatError function to accept an GraphQLError as an argument and return a GraphQLFormattedError PR #2343

`v2.4.2`

Compare Source

apollo-server-fastify is now on Apollo Server and lives within the apollo-server repository. This is being introduced in a patch version, however it's a major version bump from the last time apollo-server-fastify was published under 1.0.2. PR #1971
Move apollo-graphql package to the apollo-tooling repository PR #2316

`v2.4.1`

Compare Source

Fix inaccurate total duration in apollo-tracing PR #2298
Avoid importing entire crypto dependency tree if not in Node.js. PR #2304
Allow passing parseOptions to ApolloServerBase constructor. PR #2289
Rename azureFunctions.d.ts to azureFunctions.ts. PR #2287
Require apollo-engine-reporting only if EngineReportingAgent used. PR #2305

`v2.4.0`

Compare Source

Implement an in-memory cache store to save parsed and validated documents and provide performance benefits for repeat executions of the same document. PR #2111 (>=2.4.0-alpha.0)
Fix: Serialize arrays as JSON on fetch in RESTDataSource. PR #2219
Fix: The privateHeaders configuration for apollo-engine-reporting now allows headers to be specified using any case and lower-cases them prior to comparison. PR #2276
Fix broken apollo-server-azure-functions TypeScript definitions. PR #2287

`v2.3.3`

Compare Source

apollo-server (only): Stop double-invocation of serverWillStart life-cycle event. (More specific integrations - e.g. Express, Koa, Hapi, etc. - were unaffected.) PR #2239
Avoid traversing graphql-upload module tree in run-time environments which aren't Node.js. PR #2235

`v2.3.2`

Compare Source

Switch from json-stable-stringify to fast-json-stable-stringify. PR #2065
Fix cache hints of maxAge: 0 to mean "uncachable". #2197
Apply defaultMaxAge to scalar fields on the root object. #2210
Don't write to the persisted query cache until execution will begin. PR #2227
apollo-server-azure-functions: Added Azure Functions documentation and deployment examples PR #2131,
Issue #2092

`v2.3.1`

Compare Source

Provide types for graphql-upload in a location where they can be accessed by TypeScript consumers of apollo-server packages. ccf935f9 Issue #2092

`v2.3.0`

Compare Source

BREAKING FOR NODE.JS <= 8.5.0 ONLY: To continue using Apollo Server 2.x in versions of Node.js prior to v8.5.0, file uploads must be disabled by setting uploads: false on the ApolloServer constructor options. Without explicitly disabling file-uploads, the server will throw at launch (with instructions and a link to our documentation).

This early deprecation is due to changes in the third-party graphql-upload package which Apollo Server utilizes to implement out-of-the-box file upload functionality. While, in general, Apollo Server 2.x aims to support all Node.js versions which were under an LTS policy at the time of its release, we felt this required an exception. By throw-ing when uploads is not explicitly set to false, we aim to make it clear immediately (rather than surprisingly) that this deprecation has taken effect.

While Node.js 6.x is covered by a Long Term Support agreement by the Node.js Foundation until April 2019, there are substantial performance (e.g. V8 improvements) and language changes (e.g. "modern" ECMAScript support) offered by newer Node.js engines (e.g. 8.x, 10.x). We encourage all users of Apollo Server to update to newer LTS versions of Node.js prior to the "end-of-life" dates for their current server version.

We intend to drop support for Node.js 6.x in the next major version of Apollo Server.

For more information, see PR #2054 and our documentation.

`v2.2.7`

Compare Source

apollo-engine-reporting: When multiple instances of apollo-engine-reporting are loaded (an uncommon edge case), ensure that encodedTraces are handled only once rather than once per loaded instance. PR #2040

`v2.2.6`

Compare Source

apollo-server-micro: Set the Content-type to text/html for GraphQL Playground. PR #2026

`v2.2.5`

Compare Source

Follow-up on the update to graphql-playground-html in previous release by also bumping the minor version of the graphql-playground-react dependency to 1.7.10 — which is the version requested from the from the CDN bundle by graphql-playground-html. PR #2037

`v2.2.4`

Compare Source

Fix GraphQL Playground documentation scrolling bug in Safari by updating to latest (rebased) fork of graphql-playground-html. PR #2037

`v2.2.3`

Compare Source

When generateClientInfo is not used to define the client name, client version and
client reference ID, Apollo Server will now default to the values present in the HTTP headers
of the request (apollographql-client-name, apollographql-client-reference-id and
apollographql-client-version respectively). As a last resort, when those headers are not set,
the query extensions' clientInfo values will be used. PR #1960

`v2.2.2`

Compare Source

Fixed TypeScript 2.2 compatibility via updated apollo-tooling dependency. Issue #1951 26d6c739
Throw a more specific error when asynchronous introspection query behavior is detected. PR #1955

`v2.2.1`

Compare Source

Added support for an array of modules on the ApolloServer constructor options. Each element of the modules can point to a module which exports typeDefs and resolvers. These modules can be used in lieu of, or in combination with, directly specifying schema or typeDefs/resolvers on the constructor options. This provides greater modularity and improved organization for logic which might be limited to a specific service. 8f6481e6.
Added resolveObject support to query execution. bb67584.
Fix broken apollo-server-cloud-functions in 2.2.0 caused by missing TypeScript project references which resulted in the package not being published to npm in compiled form. PR #1948

`v2.2.0`

Compare Source

New request pipeline, including support for plugins which can implement lifecycle hooks at various stages of a request. PR #1795.
Introduce new apollo-server-testing utilities. PR #1909
Fix mocks configuration to allow disabling of mocks by using mocks: false, even if mockEntireSchema is true. PR #1835
Update graphql-playground-html to 1.7.8. PR #1855
Bring back Azure functions support Issue #1752 PR #1753
Allow an optional function to resolve the rootValue, passing the DocumentNode AST to determine the value. PR #1555
Follow-up on the work in PR #1516 to also fix missing insertion cursor/caret when a custom GraphQL configuration is specified which doesn't specify its own cursorShape property. PR #1607
Azure functions support Issue #1752 PR #1753 PR #1948
Allow JSON parsing in RESTDataSource of Content Type application/hal+json. PR #185
Add support for a requestAgent configuration parameter within the engine configuration. This can be utilized when a proxy is necessary to transmit tracing and metrics data to Apollo Engine. It accepts either an http.Agent or https.Agent and behaves the same as the agent parameter to Node.js' http.request. PR #1879
Allow an optional parameter to the RESTDataSource constructor which takes a node-fetch-compatible fetch implementation that will be used for HTTP calls instead of the default fetch. PR #1807

`v2.1.0`

Compare Source

Updated the google-cloud-functions package to handle null paths PR #1674
Update link inside Authentication Docs PR #1682
Fix making sure all headers are getting reported to Engine properly when using privateHeaders PR #1689
(experimental, subject to change/removal) Provide ability to specify client info in traces #1631

`v2.0.7`

Compare Source

Fix #1581 apollo-server-micro top level error response #1619
Switch ApolloServerBase.schema from private access to protected access. #1610
Add toggle for including error messages in reports #1615
Fix apollo-server-cloud-functions tests #1611

`v2.0.6`

Compare Source

Update graphql-playground-html to 1.7.4 #1586
Add support for graphql-js v14 by augmenting typeDefs with the @cacheControl directive so SDL validation doesn't fail #1595
Add node-fetch extensions typing to RequestInit #1602

`v2.0.5`

Compare Source

Google Cloud Function support #1402 #1446
Switch to a fork of apollo-upload-server to fix missing core-js dependency. #1556

`v2.0.4`

apollo-server: Release due to failed build and install

`v2.0.3`

apollo-server: failed publish
pass payload into context function for subscriptions #1513
Add option to mock the entire schema(i.e. sets preserveResolvers) PR #1546

`v2.0.2`

Release with Lerna 3 due
Hapi: Allow additional route options to be passed to Hapi.js plugin. PR #1384
express, koa: remove next after playground #1436
Hapi: Pass the response toolkit to the context function. #1407
update apollo-engine-reporting-protobuf to non-beta #1429
playground would use its own settings as default #1516
Lambda: Look in event.path first when picking endpoint for GraphQL Playground #1527
Fix to allow enabling GraphQL Playground in production with custom config #1495

`v2.0.1`

This version failed to publish fully/correctly and should not be used.

`v2.0.0`

Fix and Export Extension and Playground Types #1360
Pin internal dependencies #1361

`v1.4.0`

Compare Source

[Issue #626] Integrate apollo-fastify plugin. PR #1013
add hapi 16 next() invocation PR #743
Add skipValidation option PR #839
apollo-server-module-graphiql: adds an option to the constructor to disable url rewriting when editing a query PR #1047
Upgrade subscription-transport-ws to 0.9.9 for Graphiql

hapijs/boom

`v7.3.0`

Compare Source

`v7.2.2`

Compare Source

`v7.2.1`

Compare Source

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

kobelb

Security changes LGTM

walterra

ML changes LGTM

joshdover · 2019-10-14T18:31:07Z

src/core/server/http/router/response_adapter.ts

    error.output.payload.message = getErrorMessage(payload);
-    error.output.payload.attributes = getErrorAttributes(payload);
+    // Boom.output.payload is type limited to the default properties
+    (error.output.payload as any).attributes = getErrorAttributes(payload);


This seems wrong? At least looking at @types/hapi__boom, I see an attributes property? https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/hapi__boom/index.d.ts#L87

Hapijs declares d.ts file in the repo. Those types diverge from ones in DefinitelyTyped. Let's delete all @types/hapi__* to avoid confusion?

Attributes don't look like as public API anymore. Shall we create a separate issue per code owner teams to migrate fromattributes to data usage? https://github.com/hapijs/boom/blob/master/lib/index.d.ts#L14

I don't think the payload is removed from the public API, the API.md file still reads the same:

payload - the formatted object used as the response payload (stringified). Can be directly manipulated but any changes will be lost if reformat() is called. Any content allowed and by default includes the following content...

There's just no affordance for this in the types, which is probably for the best as you'd need some custom gate function to detect the type most likely, so I'm tempted to lead it as (err.output.payload as any)...

Annoying, but ok this seems fine since these packages are all over the place, seems like the best we can do right now.

attributes are not just payload. Boom adds them to WWW-Authenticate header https://github.com/hapijs/boom/blob/master/lib/index.js#L168-L202

probably we should update hapi typings. they do recommend to extend output payload https://github.com/hapijs/boom/blob/master/API.md#faq

Oh... I totally assumed attributes was referring to saved object attributes, and didn't realize it was a part of Boom at all 😬

src/core/server/saved_objects/export/get_sorted_objects_for_export.ts

src/core/server/saved_objects/export/inject_nested_depdendencies.ts

src/core/server/saved_objects/import/validate_references.ts

src/core/server/saved_objects/service/lib/errors.ts

dgieselaar

APM changes LGTM

mshustov

updated several failed tests for platform team, there are more 😞

package.json

mshustov · 2019-10-18T15:22:11Z

src/core/server/http/router/response_adapter.ts

    error.output.payload.message = getErrorMessage(payload);
-    error.output.payload.attributes = getErrorAttributes(payload);
+    // Boom.output.payload is type limited to the default properties
+    (error.output.payload as any).attributes = getErrorAttributes(payload);


Hapijs declares d.ts file in the repo. Those types diverge from ones in DefinitelyTyped. Let's delete all @types/hapi__* to avoid confusion?

Attributes don't look like as public API anymore. Shall we create a separate issue per code owner teams to migrate fromattributes to data usage? https://github.com/hapijs/boom/blob/master/lib/index.d.ts#L14

src/core/server/elasticsearch/errors.ts

src/core/server/http/cookie_session_storage.ts

elasticmachine · 2019-10-29T16:40:25Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: bc75473

elasticmachine · 2019-10-30T00:29:38Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: a25788a

elasticmachine · 2019-10-31T03:52:56Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 7f6ac13

elasticmachine · 2019-11-12T19:07:14Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 3f0aafa

elasticmachine · 2019-11-13T23:09:32Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 44f1276

joshdover · 2019-11-18T17:08:52Z

@spalger Do you know if it would be possible to update @elastic/good out of band from the rest of these upgrades to solve #43513?

elasticmachine · 2019-11-20T22:58:04Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 68d0f04b201060a104c1d44c8715b3497be2227d

elasticmachine · 2019-11-20T23:57:25Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: ae5c3d3

elasticmachine · 2019-11-21T18:28:12Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 8886dc2

elasticmachine · 2019-12-05T20:58:51Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 35362ff

spalger · 2019-12-05T22:58:02Z

I've got to start this over, renovate keeps taking control of the PR again...

azasypkin · 2019-12-27T09:32:59Z

@spalger are we still planning to upgrade Hapi any time soon (e.g. for 7.6.0)? We have a number of worrisome transitive dependencies that we hoped to update through update of the Hapi itself.

mshustov · 2020-01-06T12:02:36Z

also blocks a bug fix for #43513

renovate bot requested a review from a team as a code owner October 11, 2019 20:31

renovate bot added release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates v7.5.0 v8.0.0 labels Oct 11, 2019