SIGHUP does not reload logging configuration

[flash1293]

Kibana version: 7.3

Elasticsearch version: -

Server OS version: macOS 10.14.6

Browser version: -

Browser OS version: -

Original install method (e.g. download page, yum, from source, etc.): download page

Describe the bug:

Sending the SIGHUP signal to the Kibana process should reload the logging configuration and start logging to the new location. The logging configuration is not reloaded on macOS, but Kibana monitoring reloads properly.

Steps to reproduce:

1. Configure Kibana (no other settings):

logging.dest: /path/to/kibana.log
pid.file: /path/to/kibana.pid

2. Start Kibana via ./bin/kibana
3. Observe logs flowing into kibana.log
4. Move log file to kibana.old and observe logs still flowing into same file (as expected)
5. Send sighup by kill -HUP $(cat kibana.pid)
6. The following message is logged:

{"type":"log","@timestamp":"2019-08-19T04:33:57Z","tags":["info","monitoring","kibana-monitoring"],"pid":42073,"message":"Re-initializing Kibana Monitoring due to SIGHUP"}

7. Logs continue to flow into kibana.old

Expected behavior:

It should log to kibana.log again and log Reloading logging configuration due to SIGHUP. because of src/core/server/bootstrap.ts:91

This test should make sure it's happening: https://github.com/elastic/kibana/blob/master/src/cli/serve/integration_tests/reload_logging_config.test.js

Not sure why it doesn't fail.

[elasticmachine]

Pinging @elastic/kibana-platform

[spalger]

Closed by elastic/good#3

[mshustov]

master still uses the old version of @elastic/good. Looks like we should wait for #46604

[joshdover]

PR we're waiting on now is #48026

[mshustov]

waiting for #54168