[Maps] implement references for saved objects #31745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis |
mikecote
reviewed
Feb 21, 2019
Contributor
mikecote
left a comment
mikecote
left a comment
There was a problem hiding this comment.
Pulled down and ran locally, the only thing I noticed is the sample data doesn't go through the migrations (x-pack/plugins/maps/server/sample_data). The data files seem to be missing "migrationVersion":{}, but otherwise everything else looks good 👍
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
…ferences to ensure injectReferences is really working in SavedGisMap
Contributor
💚 Build Succeeded |
thomasneirynck
approved these changes
Feb 22, 2019
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 25, 2019
* [Maps] implement references for saved objects * add source to ref name, check that source type is ES_SEARCH or ES_GEO_GRID * extract out common find reference into a function * add migration version to sample data objects * joins are on layer descriptor and not source descriptor * update one es_archive saved object to have layerListJSON stored in references to ensure injectReferences is really working in SavedGisMap * update sample data saved objects to include applied migration * add API test to verify migration is applied when imported saved object
nreese
added a commit
that referenced
this pull request
Feb 26, 2019
* [Maps] implement references for saved objects * add source to ref name, check that source type is ES_SEARCH or ES_GEO_GRID * extract out common find reference into a function * add migration version to sample data objects * joins are on layer descriptor and not source descriptor * update one es_archive saved object to have layerListJSON stored in references to ensure injectReferences is really working in SavedGisMap * update sample data saved objects to include applied migration * add API test to verify migration is applied when imported saved object
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to extract/inject saved object references for
mapsaved objectsBelow is a screen shot from map listing page that shows that the saved objects correctly have references populated