Update embeddables metadata to support multiple index patterns #31538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
lizozom
reviewed
Feb 20, 2019
src/legacy/core_plugins/kibana/public/visualize/embeddable/visualize_embeddable_factory.ts
Show resolved
Hide resolved
src/legacy/core_plugins/kibana/public/discover/embeddable/search_embeddable.ts
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/kibana/public/dashboard/dashboard_state_manager.js
Outdated
Show resolved
Hide resolved
| if (indexPattern) { | ||
| this.panelIndexPatternMapping[panelId] = indexPattern; | ||
| const embeddableMetadata = getEmbeddableMetadata(store.getState(), panelId); | ||
| if (embeddableMetadata.indexPatterns) { |
Contributor
There was a problem hiding this comment.
Could getEmbeddableMetadata return null (even though this wasn't handled in the previous version)?
Contributor
Author
There was a problem hiding this comment.
No, metadata is defaulted to {} if nothing is provided.
https://github.com/elastic/kibana/blob/master/src/legacy/ui/public/embeddable/embeddable.ts#L52
Contributor
💔 Build Failed |
Contributor
Author
|
@lizozom Looks like TS linter does not like |
Contributor
💚 Build Succeeded |
lukasolson
reviewed
Feb 21, 2019
src/legacy/core_plugins/kibana/public/dashboard/dashboard_state.test.js
Outdated
Show resolved
Hide resolved
…WithIndexPatterns
lukasolson
approved these changes
Feb 21, 2019
Contributor
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 22, 2019
…ic#31538) * Update embeddables metadata to support multiple index patterns * ts lint errors * another try at ts lint errors * fix dashboard_state tests * use lodash compact to remove undefined * revert _.compact to make TS linter happy * rename simulateNewEmbeddableWithIndexPattern => simulateNewEmbeddableWithIndexPatterns
nreese
added a commit
that referenced
this pull request
Feb 22, 2019
… (#31820) * Update embeddables metadata to support multiple index patterns * ts lint errors * another try at ts lint errors * fix dashboard_state tests * use lodash compact to remove undefined * revert _.compact to make TS linter happy * rename simulateNewEmbeddableWithIndexPattern => simulateNewEmbeddableWithIndexPatterns
timroes
added
the
release_note:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
EmbeddableMetadatato allow an embeddable to support multiple index patterns. The Maps application is working on a newEmbeddableimplementation. A map embeddable could include 0 to many index patterns