Skip to content

Normalize resulting paths to unix paths after glob usage #236044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2025
Merged

Normalize resulting paths to unix paths after glob usage #236044

merged 2 commits into from
Sep 29, 2025
+23 −24

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Sep 23, 2025 •
edited by kibanamachine
Loading

Summary

Fixes #236004

After #233481 the resulting glob paths are yielded as windows paths, but probably processed as unix paths (since globby always returned paths with unix separators).

This PR applies a normalization on resulting paths.

@delanni delanni requested a review from a team as a code owner September 23, 2025 08:10
@delanni delanni added the release_note:skip Skip the PR/issue when compiling release notes label Sep 23, 2025
@delanni delanni requested review from a team as code owners September 23, 2025 08:10
@delanni delanni added the backport:version Backport to applied version labels label Sep 23, 2025
@delanni delanni requested a review from a team as a code owner September 23, 2025 08:10
dej611
dej611 approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

@pmuellr pmuellr mentioned this pull request Sep 23, 2025
Open
3 tasks
@delanni
Copy link
Contributor Author

delanni commented Sep 24, 2025

@elastic/kibana-core @elastic/kibana-management @elastic/security-defend-workflows @elastic/security-generative-ai - please check this, it's a relevant bugfix for windows

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@delanni delanni enabled auto-merge (squash) September 25, 2025 14:11
@pmuellr
Copy link
Member

pmuellr commented Sep 25, 2025

Could someone try running a Windows build of Kibana for this PR, to make sure it starts without error? I need this for a puppeteer/chrome update, which I can't do if the Windows build of Kibana won't start (the current status). I'd like to ensure this fix will allow the Windows build to start successfully.

No hurry ... AFK for the next few days.

@delanni
Copy link
Contributor Author

delanni commented Sep 29, 2025

Merging this, as it seems it's not making the situation worse for Unix paths.

@delanni delanni disabled auto-merge September 29, 2025 08:42
@delanni delanni merged commit 1cac4d2 into elastic:main Sep 29, 2025
11 of 12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/18091112263

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.19:
- [ci] ingest scout test events for internal config (#236263)
- Allow xpack.spaces.defaultSolution to be configured via docker (#236570)
❌ 9.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 236044

Questions ?

Please refer to the Backport tool documentation

niros1 pushed a commit that referenced this pull request Sep 30, 2025
@delanni @niros1
Normalize resulting paths to unix paths after glob usage (#236044)
370ee45 
## Summary
Fixes #236004

After #233481 the resulting glob
paths are yielded as windows paths, but probably processed as unix paths
(since `globby` always returned paths with unix separators).

This PR applies a normalization on resulting paths.
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 30, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 236044 locally
cc: @delanni

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 236044 locally
cc: @delanni

@delanni delanni mentioned this pull request Oct 1, 2025
Merged
delanni added a commit to delanni/kibana that referenced this pull request Oct 1, 2025
@delanni
Normalize resulting paths to unix paths after glob usage (elastic#236044
10d7aa8 
)

## Summary
Fixes elastic#236004

After elastic#233481 the resulting glob
paths are yielded as windows paths, but probably processed as unix paths
(since `globby` always returned paths with unix separators).

This PR applies a normalization on resulting paths.

(cherry picked from commit 1cac4d2)

# Conflicts:
#	x-pack/solutions/security/plugins/elastic_assistant/server/lib/langchain/content_loaders/defend_insights_loader.ts
delanni added a commit to delanni/kibana that referenced this pull request Oct 1, 2025
@delanni
Normalize resulting paths to unix paths after glob usage (elastic#236044
e2ff59f 
)

## Summary
Fixes elastic#236004

After elastic#233481 the resulting glob
paths are yielded as windows paths, but probably processed as unix paths
(since `globby` always returned paths with unix separators).

This PR applies a normalization on resulting paths.

(cherry picked from commit 1cac4d2)

# Conflicts:
#	x-pack/solutions/security/plugins/elastic_assistant/server/lib/langchain/content_loaders/defend_insights_loader.ts
@delanni delanni mentioned this pull request Oct 1, 2025
Open
@delanni
Copy link
Contributor Author

delanni commented Oct 1, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.1
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@delanni delanni deleted the fix-paths-after-glob branch October 1, 2025 10:56
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

delanni added a commit to delanni/kibana that referenced this pull request Oct 2, 2025
@delanni
Normalize resulting paths to unix paths after glob usage (elastic#236044
46caec5 
)

## Summary
Fixes elastic#236004

After elastic#233481 the resulting glob
paths are yielded as windows paths, but probably processed as unix paths
(since `globby` always returned paths with unix separators).

This PR applies a normalization on resulting paths.

(cherry picked from commit 1cac4d2)

# Conflicts:
#	x-pack/solutions/security/plugins/elastic_assistant/server/lib/langchain/content_loaders/defend_insights_loader.ts
delanni added a commit that referenced this pull request Oct 2, 2025
@delanni
[9.1] Normalize resulting paths to unix paths after glob usage (#236044…
71805ad 
…) (#237101)

# Backport

This will backport the following commits from `main` to `9.1`:
- [Normalize resulting paths to unix paths after glob usage
(#236044)](#236044)

<!--- Backport version: 10.0.2 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2025-09-29T08:42:25Z","message":"Normalize
resulting paths to unix paths after glob usage (#236044)\n\n##
Summary\nFixes https://github.com/elastic/kibana/issues/236004\n\nAfter
#233481 the resulting glob\npaths
are yielded as windows paths, but probably processed as unix
paths\n(since `globby` always returned paths with unix
separators).\n\nThis PR applies a normalization on resulting
paths.","sha":"1cac4d2b739423bbfb2c8d93cc60a02a456707f4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","backport:version","v9.2.0","v8.19.5","v9.1.5"],"title":"Normalize
resulting paths to unix paths after glob
usage","number":236044,"url":"https://github.com/elastic/kibana/pull/236044","mergeCommit":{"message":"Normalize
resulting paths to unix paths after glob usage (#236044)\n\n##
Summary\nFixes https://github.com/elastic/kibana/issues/236004\n\nAfter
#233481 the resulting glob\npaths
are yielded as windows paths, but probably processed as unix
paths\n(since `globby` always returned paths with unix
separators).\n\nThis PR applies a normalization on resulting
paths.","sha":"1cac4d2b739423bbfb2c8d93cc60a02a456707f4"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/236044","number":236044,"mergeCommit":{"message":"Normalize
resulting paths to unix paths after glob usage (#236044)\n\n##
Summary\nFixes https://github.com/elastic/kibana/issues/236004\n\nAfter
#233481 the resulting glob\npaths
are yielded as windows paths, but probably processed as unix
paths\n(since `globby` always returned paths with unix
separators).\n\nThis PR applies a normalization on resulting
paths.","sha":"1cac4d2b739423bbfb2c8d93cc60a02a456707f4"}},{"branch":"8.19","label":"v8.19.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

@mistic mistic added v9.1.6 and removed v9.1.5 labels Oct 6, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @delanni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

@kapral18 kapral18 kapral18 approved these changes

@joeypoon joeypoon Awaiting requested review from joeypoon joeypoon is a code owner automatically assigned from elastic/security-defend-workflows

@gergoabraham gergoabraham Awaiting requested review from gergoabraham gergoabraham is a code owner automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.19.5 v9.1.6 v9.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

native glob issues on Windows
7 participants
@delanni @elasticmachine @pmuellr @kibanamachine @dej611 @kapral18 @mistic