Replaced globby with native glob #233481
Merged
Replaced globby with native glob #233481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elena-shostak
added
release_note:skip
|
Pinging @elastic/kibana-security (Team:Security) |
legrego
reviewed
Aug 29, 2025
markov00
approved these changes
Sep 1, 2025
KodeRad
pushed a commit
to KodeRad/kibana
that referenced
this pull request
Sep 15, 2025
## Summary Replaced `globby` with native glob. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) __Related: https://github.com/elastic/kibana/issues/233193__ --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
elena-shostak
removed
backport missing
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
elena-shostak
added
v8.19.4
v9.1.4
and removed
v8.19.5
backport missing
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
removed
the
backport missing
This was referenced Sep 19, 2025
1 task
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
## Summary Replaced `globby` with native glob. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) __Related: https://github.com/elastic/kibana/issues/233193__ --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
niros1
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Summary Replaced `globby` with native glob. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) __Related: https://github.com/elastic/kibana/issues/233193__ --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
delanni
added a commit
to delanni/kibana
that referenced
this pull request
Oct 1, 2025
) ## Summary Fixes elastic#236004 After elastic#233481 the resulting glob paths are yielded as windows paths, but probably processed as unix paths (since `globby` always returned paths with unix separators). This PR applies a normalization on resulting paths. (cherry picked from commit 1cac4d2) # Conflicts: # x-pack/solutions/security/plugins/elastic_assistant/server/lib/langchain/content_loaders/defend_insights_loader.ts
delanni
added a commit
to delanni/kibana
that referenced
this pull request
Oct 1, 2025
) ## Summary Fixes elastic#236004 After elastic#233481 the resulting glob paths are yielded as windows paths, but probably processed as unix paths (since `globby` always returned paths with unix separators). This PR applies a normalization on resulting paths. (cherry picked from commit 1cac4d2) # Conflicts: # x-pack/solutions/security/plugins/elastic_assistant/server/lib/langchain/content_loaders/defend_insights_loader.ts
delanni
added a commit
to delanni/kibana
that referenced
this pull request
Oct 2, 2025
) ## Summary Fixes elastic#236004 After elastic#233481 the resulting glob paths are yielded as windows paths, but probably processed as unix paths (since `globby` always returned paths with unix separators). This PR applies a normalization on resulting paths. (cherry picked from commit 1cac4d2) # Conflicts: # x-pack/solutions/security/plugins/elastic_assistant/server/lib/langchain/content_loaders/defend_insights_loader.ts
delanni
added a commit
that referenced
this pull request
Oct 2, 2025
…) (#237101) # Backport This will backport the following commits from `main` to `9.1`: - [Normalize resulting paths to unix paths after glob usage (#236044)](#236044) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alex Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2025-09-29T08:42:25Z","message":"Normalize resulting paths to unix paths after glob usage (#236044)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/236004\n\nAfter #233481 the resulting glob\npaths are yielded as windows paths, but probably processed as unix paths\n(since `globby` always returned paths with unix separators).\n\nThis PR applies a normalization on resulting paths.","sha":"1cac4d2b739423bbfb2c8d93cc60a02a456707f4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","backport:version","v9.2.0","v8.19.5","v9.1.5"],"title":"Normalize resulting paths to unix paths after glob usage","number":236044,"url":"https://github.com/elastic/kibana/pull/236044","mergeCommit":{"message":"Normalize resulting paths to unix paths after glob usage (#236044)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/236004\n\nAfter #233481 the resulting glob\npaths are yielded as windows paths, but probably processed as unix paths\n(since `globby` always returned paths with unix separators).\n\nThis PR applies a normalization on resulting paths.","sha":"1cac4d2b739423bbfb2c8d93cc60a02a456707f4"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/236044","number":236044,"mergeCommit":{"message":"Normalize resulting paths to unix paths after glob usage (#236044)\n\n## Summary\nFixes https://github.com/elastic/kibana/issues/236004\n\nAfter #233481 the resulting glob\npaths are yielded as windows paths, but probably processed as unix paths\n(since `globby` always returned paths with unix separators).\n\nThis PR applies a normalization on resulting paths.","sha":"1cac4d2b739423bbfb2c8d93cc60a02a456707f4"}},{"branch":"8.19","label":"v8.19.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaced
globbywith native glob.Checklist
release_note:*label is applied per the guidelinesRelated: #233193