Skip to content

[Response Ops][Alerting] Grouping ad hoc run metrics under alerting metrics #233875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 22, 2025
Merged

[Response Ops][Alerting] Grouping ad hoc run metrics under alerting metrics #233875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1276f8c
Grouping ad hoc runs under alerting metrics
ymao1 Sep 3, 2025
2d9d699
Merge branch 'main' into backfill-metrics
elasticmachine Sep 18, 2025
5daa718
Merge branch 'main' into backfill-metrics
elasticmachine Sep 19, 2025
eb52dd8
Merge branch 'main' into backfill-metrics
elasticmachine Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions x-pack/platform/plugins/shared/task_manager/server/metrics/lib/get_task_type_group.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ describe('getTaskTypeGroup', () => {
expect(getTaskTypeGroup('actions:def')).toEqual('actions');
});

test('should correctly group ad hoc runs under alerting', () => {
expect(getTaskTypeGroup('ad_hoc_run-backfill')).toEqual('alerting');
});

test('should return undefined if no match', () => {
expect(getTaskTypeGroup('alerting-abc')).toBeUndefined();
expect(getTaskTypeGroup('fooalertingbar')).toBeUndefined();
Expand Down
9 changes: 8 additions & 1 deletion x-pack/platform/plugins/shared/task_manager/server/metrics/lib/get_task_type_group.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,16 @@
* 2.0.
*/

const taskTypeGrouping = new Set<string>(['alerting:', 'actions:']);
const ALERT_GROUP = 'alerting';
const ACTIONS_GROUP = 'actions';
const taskTypeGrouping = new Set<string>([`${ALERT_GROUP}:`, `${ACTIONS_GROUP}:`]);

export function getTaskTypeGroup(taskType: string): string | undefined {
// we want to group ad hoc runs under alerting
if (taskType === 'ad_hoc_run-backfill') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using BACKFILL_TASK_TYPE const from the alerting plugin could be better.

return ALERT_GROUP;
}

for (const group of taskTypeGrouping) {
if (taskType.startsWith(group)) {
return group.replace(':', '');
Expand Down