[Response Ops][Alerting] Grouping ad hoc run metrics under alerting metrics #233875
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
ymao1
changed the title
ymao1
added
Feature:Alerting
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
ersin-erdal
reviewed
Sep 19, 2025
|
|
||
| export function getTaskTypeGroup(taskType: string): string | undefined { | ||
| // we want to group ad hoc runs under alerting | ||
| if (taskType === 'ad_hoc_run-backfill') { |
There was a problem hiding this comment.
Using BACKFILL_TASK_TYPE const from the alerting plugin could be better.
ersin-erdal
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
LGTM
Tested locally and observed the expected results.
"alerting":{"success":1,"not_timed_out":1,"total":1,"total_errors":0,"rescheduled_failures":0,"user_errors":0,"framework_errors":0},"ad_hoc_run-backfill":{"success":1,"not_timed_out":1,"total":1,"total_errors":0,"rescheduled_failures":0,"user_errors":0,"framework_errors":0}
Just left a nit.
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
cc @ymao1 |
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
…etrics (elastic#233875) Towards elastic/response-ops-team#297 ## Summary Updates the grouping for task manager per task type metrics to categorize `ad_hoc_run-backfill` task types under the `alerting` grouping. ## To Verify 1. Start ES and Kibana 2. Create a detection rule 3. Manually schedule a backfill for the detection rule 4. Navigate to the task manager metrics endpoint(https://localhost:5601/api/task_manager/metrics?reset=false) and verify that the success counter for `alerting` (under `metrics.task_run.value.by_type.alerting`) is incremented, as well as the success counter for `ad_hoc_run-backfill` (under `metrics.task_run.value.by_type.ad_hoc_run-backfill`). (The counters reset every 30 seconds so you will have to look at this endpoint quickly after scheduling the backfill). Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
niros1
pushed a commit
that referenced
this pull request
Sep 30, 2025
…etrics (#233875) Towards elastic/response-ops-team#297 ## Summary Updates the grouping for task manager per task type metrics to categorize `ad_hoc_run-backfill` task types under the `alerting` grouping. ## To Verify 1. Start ES and Kibana 2. Create a detection rule 3. Manually schedule a backfill for the detection rule 4. Navigate to the task manager metrics endpoint(https://localhost:5601/api/task_manager/metrics?reset=false) and verify that the success counter for `alerting` (under `metrics.task_run.value.by_type.alerting`) is incremented, as well as the success counter for `ad_hoc_run-backfill` (under `metrics.task_run.value.by_type.ad_hoc_run-backfill`). (The counters reset every 30 seconds so you will have to look at this endpoint quickly after scheduling the backfill). Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/elastic/response-ops-team/issues/297
Summary
Updates the grouping for task manager per task type metrics to categorize
ad_hoc_run-backfilltask types under thealertinggrouping.To Verify
alerting(undermetrics.task_run.value.by_type.alerting) is incremented, as well as the success counter forad_hoc_run-backfill(undermetrics.task_run.value.by_type.ad_hoc_run-backfill). (The counters reset every 30 seconds so you will have to look at this endpoint quickly after scheduling the backfill).