Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [SIEM migrations] ES|QL editor: Broken suggestions menu (#11535) (#210603) #210751

Merged
merged 1 commit into from
Feb 12, 2025
Merged

[8.x] [SIEM migrations] ES|QL editor: Broken suggestions menu (#11535) (#210603) #210751

merged 1 commit into from
Feb 12, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@e40pud
[SIEM migrations] ES|QL editor: Broken suggestions menu (elastic#11535)…
90b6054 
… (elastic#210603)

## Summary

These changes fix the issue with the shifted suggestion menu of the
ES|QL editor integrated inside the flyout.

This is just a workaround and we will need to remove this once the issue
is fixed by EUI team. Here is the ticket to track:
elastic/eui#8269

**More details regarding the fix**:
Slack conversation: [internal
link](https://elastic.slack.com/archives/C7QC1JV6F/p1736501365531779)

### Screenshots

**Before the fix**

<img width="1653" alt="Screenshot 2025-02-11 at 15 51 42"
src="https://github.com/user-attachments/assets/4925a706-0c31-4730-b37f-acf3bbd0447c"
/>

**After the fix**

<img width="1651" alt="Screenshot 2025-02-11 at 15 52 19"
src="https://github.com/user-attachments/assets/475d45d2-cb42-4a46-ae5c-6e8cef874b40"
/>

(cherry picked from commit 652385c)
@kibanamachine kibanamachine enabled auto-merge (squash) February 12, 2025 09:10
@kibanamachine kibanamachine mentioned this pull request Feb 12, 2025
Merged
@kibanamachine kibanamachine merged commit 8a638ee into elastic:8.x Feb 12, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 18.7MB 18.7MB +87.0B

cc @e40pud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@e40pud e40pud

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @elasticmachine @e40pud