-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[babel] tweak babel options for performance and debugging #11535
Conversation
1a7fe50
to
f6ea8ad
Compare
jenkins, test this |
Nice. Before:
After:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment. Tested with x-pack, things are functioning.
package.json
Outdated
@@ -98,14 +98,16 @@ | |||
"babel-jest": "19.0.0", | |||
"babel-loader": "6.2.10", | |||
"babel-plugin-add-module-exports": "0.2.1", | |||
"babel-plugin-syntax-dynamic-import": "^6.18.0", | |||
"babel-plugin-transform-async-generator-functions": "^6.24.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these be locked to the patch version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sorry, I've been using yarn which doesn't do this because of yarn.lock
acfb7e0
to
14c91a7
Compare
package.json
Outdated
"babel-plugin-transform-async-generator-functions": "6.24.1", | ||
"babel-plugin-transform-class-properties": "6.24.1", | ||
"babel-plugin-transform-object-rest-spread": "6.23.0", | ||
"babel-plugin-transform-unicode-property-regex": "2.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is babel-plugin-transform-unicode-property-regex
and babel-plugin-syntax-dynamic-import
used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was originally basing the list of plugins off of babel#master, rather than the released versions
EDIT: Bah, I was checking in |
) * [babel] tweak babel options for performance and debugging * [babel] remove babel-plugin-transform-export-extensions * [npm] lock new deps to the patch version * [npm] remove unused deps (cherry picked from commit 36ecf13)
) * [babel] tweak babel options for performance and debugging * [babel] remove babel-plugin-transform-export-extensions * [npm] lock new deps to the patch version * [npm] remove unused deps (cherry picked from commit 36ecf13)
…0603) ## Summary These changes fix the issue with the shifted suggestion menu of the ES|QL editor integrated inside the flyout. This is just a workaround and we will need to remove this once the issue is fixed by EUI team. Here is the ticket to track: elastic/eui#8269 **More details regarding the fix**: Slack conversation: [internal link](https://elastic.slack.com/archives/C7QC1JV6F/p1736501365531779) ### Screenshots **Before the fix** <img width="1653" alt="Screenshot 2025-02-11 at 15 51 42" src="https://github.com/user-attachments/assets/4925a706-0c31-4730-b37f-acf3bbd0447c" /> **After the fix** <img width="1651" alt="Screenshot 2025-02-11 at 15 52 19" src="https://github.com/user-attachments/assets/475d45d2-cb42-4a46-ae5c-6e8cef874b40" />
… (elastic#210603) ## Summary These changes fix the issue with the shifted suggestion menu of the ES|QL editor integrated inside the flyout. This is just a workaround and we will need to remove this once the issue is fixed by EUI team. Here is the ticket to track: elastic/eui#8269 **More details regarding the fix**: Slack conversation: [internal link](https://elastic.slack.com/archives/C7QC1JV6F/p1736501365531779) ### Screenshots **Before the fix** <img width="1653" alt="Screenshot 2025-02-11 at 15 51 42" src="https://github.com/user-attachments/assets/4925a706-0c31-4730-b37f-acf3bbd0447c" /> **After the fix** <img width="1651" alt="Screenshot 2025-02-11 at 15 52 19" src="https://github.com/user-attachments/assets/475d45d2-cb42-4a46-ae5c-6e8cef874b40" /> (cherry picked from commit 652385c)
… (elastic#210603) ## Summary These changes fix the issue with the shifted suggestion menu of the ES|QL editor integrated inside the flyout. This is just a workaround and we will need to remove this once the issue is fixed by EUI team. Here is the ticket to track: elastic/eui#8269 **More details regarding the fix**: Slack conversation: [internal link](https://elastic.slack.com/archives/C7QC1JV6F/p1736501365531779) ### Screenshots **Before the fix** <img width="1653" alt="Screenshot 2025-02-11 at 15 51 42" src="https://github.com/user-attachments/assets/4925a706-0c31-4730-b37f-acf3bbd0447c" /> **After the fix** <img width="1651" alt="Screenshot 2025-02-11 at 15 52 19" src="https://github.com/user-attachments/assets/475d45d2-cb42-4a46-ae5c-6e8cef874b40" /> (cherry picked from commit 652385c)
… (elastic#210603) ## Summary These changes fix the issue with the shifted suggestion menu of the ES|QL editor integrated inside the flyout. This is just a workaround and we will need to remove this once the issue is fixed by EUI team. Here is the ticket to track: elastic/eui#8269 **More details regarding the fix**: Slack conversation: [internal link](https://elastic.slack.com/archives/C7QC1JV6F/p1736501365531779) ### Screenshots **Before the fix** <img width="1653" alt="Screenshot 2025-02-11 at 15 51 42" src="https://github.com/user-attachments/assets/4925a706-0c31-4730-b37f-acf3bbd0447c" /> **After the fix** <img width="1651" alt="Screenshot 2025-02-11 at 15 52 19" src="https://github.com/user-attachments/assets/475d45d2-cb42-4a46-ae5c-6e8cef874b40" /> (cherry picked from commit 652385c)
#210603) (#210751) # Backport This will backport the following commits from `main` to `8.x`: - [[SIEM migrations] ES|QL editor: Broken suggestions menu (#11535) (#210603)](#210603) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2025-02-12T09:04:40Z","message":"[SIEM migrations] ES|QL editor: Broken suggestions menu (#11535) (#210603)\n\n## Summary\r\n\r\nThese changes fix the issue with the shifted suggestion menu of the\r\nES|QL editor integrated inside the flyout.\r\n\r\nThis is just a workaround and we will need to remove this once the issue\r\nis fixed by EUI team. Here is the ticket to track:\r\nhttps://github.com/elastic/eui/issues/8269\r\n\r\n**More details regarding the fix**:\r\nSlack conversation: [internal\r\nlink](https://elastic.slack.com/archives/C7QC1JV6F/p1736501365531779)\r\n\r\n### Screenshots\r\n\r\n**Before the fix**\r\n\r\n<img width=\"1653\" alt=\"Screenshot 2025-02-11 at 15 51 42\"\r\nsrc=\"https://github.com/user-attachments/assets/4925a706-0c31-4730-b37f-acf3bbd0447c\"\r\n/>\r\n\r\n**After the fix**\r\n\r\n<img width=\"1651\" alt=\"Screenshot 2025-02-11 at 15 52 19\"\r\nsrc=\"https://github.com/user-attachments/assets/475d45d2-cb42-4a46-ae5c-6e8cef874b40\"\r\n/>","sha":"652385cf80903e0bd08e5c006896817fad36399d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[SIEM migrations] ES|QL editor: Broken suggestions menu (#11535)","number":210603,"url":"https://github.com/elastic/kibana/pull/210603","mergeCommit":{"message":"[SIEM migrations] ES|QL editor: Broken suggestions menu (#11535) (#210603)\n\n## Summary\r\n\r\nThese changes fix the issue with the shifted suggestion menu of the\r\nES|QL editor integrated inside the flyout.\r\n\r\nThis is just a workaround and we will need to remove this once the issue\r\nis fixed by EUI team. Here is the ticket to track:\r\nhttps://github.com/elastic/eui/issues/8269\r\n\r\n**More details regarding the fix**:\r\nSlack conversation: [internal\r\nlink](https://elastic.slack.com/archives/C7QC1JV6F/p1736501365531779)\r\n\r\n### Screenshots\r\n\r\n**Before the fix**\r\n\r\n<img width=\"1653\" alt=\"Screenshot 2025-02-11 at 15 51 42\"\r\nsrc=\"https://github.com/user-attachments/assets/4925a706-0c31-4730-b37f-acf3bbd0447c\"\r\n/>\r\n\r\n**After the fix**\r\n\r\n<img width=\"1651\" alt=\"Screenshot 2025-02-11 at 15 52 19\"\r\nsrc=\"https://github.com/user-attachments/assets/475d45d2-cb42-4a46-ae5c-6e8cef874b40\"\r\n/>","sha":"652385cf80903e0bd08e5c006896817fad36399d"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210603","number":210603,"mergeCommit":{"message":"[SIEM migrations] ES|QL editor: Broken suggestions menu (#11535) (#210603)\n\n## Summary\r\n\r\nThese changes fix the issue with the shifted suggestion menu of the\r\nES|QL editor integrated inside the flyout.\r\n\r\nThis is just a workaround and we will need to remove this once the issue\r\nis fixed by EUI team. Here is the ticket to track:\r\nhttps://github.com/elastic/eui/issues/8269\r\n\r\n**More details regarding the fix**:\r\nSlack conversation: [internal\r\nlink](https://elastic.slack.com/archives/C7QC1JV6F/p1736501365531779)\r\n\r\n### Screenshots\r\n\r\n**Before the fix**\r\n\r\n<img width=\"1653\" alt=\"Screenshot 2025-02-11 at 15 51 42\"\r\nsrc=\"https://github.com/user-attachments/assets/4925a706-0c31-4730-b37f-acf3bbd0447c\"\r\n/>\r\n\r\n**After the fix**\r\n\r\n<img width=\"1651\" alt=\"Screenshot 2025-02-11 at 15 52 19\"\r\nsrc=\"https://github.com/user-attachments/assets/475d45d2-cb42-4a46-ae5c-6e8cef874b40\"\r\n/>","sha":"652385cf80903e0bd08e5c006896817fad36399d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
#210603) (#210752) # Backport This will backport the following commits from `main` to `9.0`: - [[SIEM migrations] ES|QL editor: Broken suggestions menu (#11535) (#210603)](#210603) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2025-02-12T09:04:40Z","message":"[SIEM migrations] ES|QL editor: Broken suggestions menu (#11535) (#210603)\n\n## Summary\r\n\r\nThese changes fix the issue with the shifted suggestion menu of the\r\nES|QL editor integrated inside the flyout.\r\n\r\nThis is just a workaround and we will need to remove this once the issue\r\nis fixed by EUI team. Here is the ticket to track:\r\nhttps://github.com/elastic/eui/issues/8269\r\n\r\n**More details regarding the fix**:\r\nSlack conversation: [internal\r\nlink](https://elastic.slack.com/archives/C7QC1JV6F/p1736501365531779)\r\n\r\n### Screenshots\r\n\r\n**Before the fix**\r\n\r\n<img width=\"1653\" alt=\"Screenshot 2025-02-11 at 15 51 42\"\r\nsrc=\"https://github.com/user-attachments/assets/4925a706-0c31-4730-b37f-acf3bbd0447c\"\r\n/>\r\n\r\n**After the fix**\r\n\r\n<img width=\"1651\" alt=\"Screenshot 2025-02-11 at 15 52 19\"\r\nsrc=\"https://github.com/user-attachments/assets/475d45d2-cb42-4a46-ae5c-6e8cef874b40\"\r\n/>","sha":"652385cf80903e0bd08e5c006896817fad36399d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[SIEM migrations] ES|QL editor: Broken suggestions menu (#11535)","number":210603,"url":"https://github.com/elastic/kibana/pull/210603","mergeCommit":{"message":"[SIEM migrations] ES|QL editor: Broken suggestions menu (#11535) (#210603)\n\n## Summary\r\n\r\nThese changes fix the issue with the shifted suggestion menu of the\r\nES|QL editor integrated inside the flyout.\r\n\r\nThis is just a workaround and we will need to remove this once the issue\r\nis fixed by EUI team. Here is the ticket to track:\r\nhttps://github.com/elastic/eui/issues/8269\r\n\r\n**More details regarding the fix**:\r\nSlack conversation: [internal\r\nlink](https://elastic.slack.com/archives/C7QC1JV6F/p1736501365531779)\r\n\r\n### Screenshots\r\n\r\n**Before the fix**\r\n\r\n<img width=\"1653\" alt=\"Screenshot 2025-02-11 at 15 51 42\"\r\nsrc=\"https://github.com/user-attachments/assets/4925a706-0c31-4730-b37f-acf3bbd0447c\"\r\n/>\r\n\r\n**After the fix**\r\n\r\n<img width=\"1651\" alt=\"Screenshot 2025-02-11 at 15 52 19\"\r\nsrc=\"https://github.com/user-attachments/assets/475d45d2-cb42-4a46-ae5c-6e8cef874b40\"\r\n/>","sha":"652385cf80903e0bd08e5c006896817fad36399d"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210603","number":210603,"mergeCommit":{"message":"[SIEM migrations] ES|QL editor: Broken suggestions menu (#11535) (#210603)\n\n## Summary\r\n\r\nThese changes fix the issue with the shifted suggestion menu of the\r\nES|QL editor integrated inside the flyout.\r\n\r\nThis is just a workaround and we will need to remove this once the issue\r\nis fixed by EUI team. Here is the ticket to track:\r\nhttps://github.com/elastic/eui/issues/8269\r\n\r\n**More details regarding the fix**:\r\nSlack conversation: [internal\r\nlink](https://elastic.slack.com/archives/C7QC1JV6F/p1736501365531779)\r\n\r\n### Screenshots\r\n\r\n**Before the fix**\r\n\r\n<img width=\"1653\" alt=\"Screenshot 2025-02-11 at 15 51 42\"\r\nsrc=\"https://github.com/user-attachments/assets/4925a706-0c31-4730-b37f-acf3bbd0447c\"\r\n/>\r\n\r\n**After the fix**\r\n\r\n<img width=\"1651\" alt=\"Screenshot 2025-02-11 at 15 52 19\"\r\nsrc=\"https://github.com/user-attachments/assets/475d45d2-cb42-4a46-ae5c-6e8cef874b40\"\r\n/>","sha":"652385cf80903e0bd08e5c006896817fad36399d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
… (#210603) (#210750) # Backport This will backport the following commits from `main` to `8.18`: - [[SIEM migrations] ES|QL editor: Broken suggestions menu (#11535) (#210603)](#210603) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"ievgen.sorokopud@elastic.co"},"sourceCommit":{"committedDate":"2025-02-12T09:04:40Z","message":"[SIEM migrations] ES|QL editor: Broken suggestions menu (#11535) (#210603)\n\n## Summary\r\n\r\nThese changes fix the issue with the shifted suggestion menu of the\r\nES|QL editor integrated inside the flyout.\r\n\r\nThis is just a workaround and we will need to remove this once the issue\r\nis fixed by EUI team. Here is the ticket to track:\r\nhttps://github.com/elastic/eui/issues/8269\r\n\r\n**More details regarding the fix**:\r\nSlack conversation: [internal\r\nlink](https://elastic.slack.com/archives/C7QC1JV6F/p1736501365531779)\r\n\r\n### Screenshots\r\n\r\n**Before the fix**\r\n\r\n<img width=\"1653\" alt=\"Screenshot 2025-02-11 at 15 51 42\"\r\nsrc=\"https://github.com/user-attachments/assets/4925a706-0c31-4730-b37f-acf3bbd0447c\"\r\n/>\r\n\r\n**After the fix**\r\n\r\n<img width=\"1651\" alt=\"Screenshot 2025-02-11 at 15 52 19\"\r\nsrc=\"https://github.com/user-attachments/assets/475d45d2-cb42-4a46-ae5c-6e8cef874b40\"\r\n/>","sha":"652385cf80903e0bd08e5c006896817fad36399d","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[SIEM migrations] ES|QL editor: Broken suggestions menu (#11535)","number":210603,"url":"https://github.com/elastic/kibana/pull/210603","mergeCommit":{"message":"[SIEM migrations] ES|QL editor: Broken suggestions menu (#11535) (#210603)\n\n## Summary\r\n\r\nThese changes fix the issue with the shifted suggestion menu of the\r\nES|QL editor integrated inside the flyout.\r\n\r\nThis is just a workaround and we will need to remove this once the issue\r\nis fixed by EUI team. Here is the ticket to track:\r\nhttps://github.com/elastic/eui/issues/8269\r\n\r\n**More details regarding the fix**:\r\nSlack conversation: [internal\r\nlink](https://elastic.slack.com/archives/C7QC1JV6F/p1736501365531779)\r\n\r\n### Screenshots\r\n\r\n**Before the fix**\r\n\r\n<img width=\"1653\" alt=\"Screenshot 2025-02-11 at 15 51 42\"\r\nsrc=\"https://github.com/user-attachments/assets/4925a706-0c31-4730-b37f-acf3bbd0447c\"\r\n/>\r\n\r\n**After the fix**\r\n\r\n<img width=\"1651\" alt=\"Screenshot 2025-02-11 at 15 52 19\"\r\nsrc=\"https://github.com/user-attachments/assets/475d45d2-cb42-4a46-ae5c-6e8cef874b40\"\r\n/>","sha":"652385cf80903e0bd08e5c006896817fad36399d"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/210603","number":210603,"mergeCommit":{"message":"[SIEM migrations] ES|QL editor: Broken suggestions menu (#11535) (#210603)\n\n## Summary\r\n\r\nThese changes fix the issue with the shifted suggestion menu of the\r\nES|QL editor integrated inside the flyout.\r\n\r\nThis is just a workaround and we will need to remove this once the issue\r\nis fixed by EUI team. Here is the ticket to track:\r\nhttps://github.com/elastic/eui/issues/8269\r\n\r\n**More details regarding the fix**:\r\nSlack conversation: [internal\r\nlink](https://elastic.slack.com/archives/C7QC1JV6F/p1736501365531779)\r\n\r\n### Screenshots\r\n\r\n**Before the fix**\r\n\r\n<img width=\"1653\" alt=\"Screenshot 2025-02-11 at 15 51 42\"\r\nsrc=\"https://github.com/user-attachments/assets/4925a706-0c31-4730-b37f-acf3bbd0447c\"\r\n/>\r\n\r\n**After the fix**\r\n\r\n<img width=\"1651\" alt=\"Screenshot 2025-02-11 at 15 52 19\"\r\nsrc=\"https://github.com/user-attachments/assets/475d45d2-cb42-4a46-ae5c-6e8cef874b40\"\r\n/>","sha":"652385cf80903e0bd08e5c006896817fad36399d"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <ievgen.sorokopud@elastic.co>
Closes #9472
babel-preset-env
'suseBuiltIns
option which trims the core-js polyfills to just those necessary for the current node versionbabel-plugin-transform-class-properties