-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] [Synthetics] Fix flaky tests for alerting default !! (#203220) #203232
Merged
kibanamachine
merged 1 commit into
elastic:8.x
from
kibanamachine:backport/8.x/pr-203220
Dec 6, 2024
Merged
[8.x] [Synthetics] Fix flaky tests for alerting default !! (#203220) #203232
kibanamachine
merged 1 commit into
elastic:8.x
from
kibanamachine:backport/8.x/pr-203220
Dec 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Fix flaky tests for alerting default, removed unecessary code. I tested locally 30 times and it has been fixed now. (cherry picked from commit dc77e8c)
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]
Historycc @shahzad31 |
kibanamachine
added a commit
that referenced
this pull request
Feb 11, 2025
…#210570) # Backport This will backport the following commits from `main` to `8.17`: - [[Synthetics] Fix flaky tests for alerting default !! (#203220)](#203220) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-12-06T11:54:07Z","message":"[Synthetics] Fix flaky tests for alerting default !! (#203220)\n\n## Summary\r\n\r\nFix flaky tests for alerting default, removed unecessary code.\r\n\r\nI tested locally 30 times and it has been fixed now.","sha":"dc77e8c149abc7a0bc2d9d3c65db0533ce45e4ff","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.18.0","v9.1.0","v8.17.3"],"title":"[Synthetics] Fix flaky tests for alerting default !!","number":203220,"url":"https://github.com/elastic/kibana/pull/203220","mergeCommit":{"message":"[Synthetics] Fix flaky tests for alerting default !! (#203220)\n\n## Summary\r\n\r\nFix flaky tests for alerting default, removed unecessary code.\r\n\r\nI tested locally 30 times and it has been fixed now.","sha":"dc77e8c149abc7a0bc2d9d3c65db0533ce45e4ff"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203220","number":203220,"mergeCommit":{"message":"[Synthetics] Fix flaky tests for alerting default !! (#203220)\n\n## Summary\r\n\r\nFix flaky tests for alerting default, removed unecessary code.\r\n\r\nI tested locally 30 times and it has been fixed now.","sha":"dc77e8c149abc7a0bc2d9d3c65db0533ce45e4ff"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/203232","number":203232,"state":"MERGED","mergeCommit":{"sha":"9cdf4d21a2adf8cf14abad6f18375e993942dabc","message":"[8.x] [Synthetics] Fix flaky tests for alerting default !! (#203220) (#203232)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Synthetics] Fix flaky tests for alerting default !!\n(#203220)](https://github.com/elastic/kibana/pull/203220)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT\n[{\"author\":{\"name\":\"Shahzad\",\"email\":\"shahzad31comp@gmail.com\"},\"sourceCommit\":{\"committedDate\":\"2024-12-06T11:54:07Z\",\"message\":\"[Synthetics]\nFix flaky tests for alerting default !! (#203220)\\n\\n##\nSummary\\r\\n\\r\\nFix flaky tests for alerting default, removed unecessary\ncode.\\r\\n\\r\\nI tested locally 30 times and it has been fixed\nnow.\",\"sha\":\"dc77e8c149abc7a0bc2d9d3c65db0533ce45e4ff\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-management\"],\"title\":\"[Synthetics]\nFix flaky tests for alerting default\n!!\",\"number\":203220,\"url\":\"https://github.com/elastic/kibana/pull/203220\",\"mergeCommit\":{\"message\":\"[Synthetics]\nFix flaky tests for alerting default !! (#203220)\\n\\n##\nSummary\\r\\n\\r\\nFix flaky tests for alerting default, removed unecessary\ncode.\\r\\n\\r\\nI tested locally 30 times and it has been fixed\nnow.\",\"sha\":\"dc77e8c149abc7a0bc2d9d3c65db0533ce45e4ff\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/203220\",\"number\":203220,\"mergeCommit\":{\"message\":\"[Synthetics]\nFix flaky tests for alerting default !! (#203220)\\n\\n##\nSummary\\r\\n\\r\\nFix flaky tests for alerting default, removed unecessary\ncode.\\r\\n\\r\\nI tested locally 30 times and it has been fixed\nnow.\",\"sha\":\"dc77e8c149abc7a0bc2d9d3c65db0533ce45e4ff\"}}]}] BACKPORT-->\n\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>"}},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
ci:project-deploy-observability
Create an Observability project
Team:obs-ux-management
Observability Management User Experience Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
main
to8.x
:Questions ?
Please refer to the Backport tool documentation