Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Fix flaky tests for alerting default !! #203220

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Dec 6, 2024

Summary

Fix flaky tests for alerting default, removed unecessary code.

I tested locally 30 times and it has been fixed now.

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

@shahzad31 shahzad31 marked this pull request as ready for review December 6, 2024 11:42
@shahzad31 shahzad31 requested a review from a team as a code owner December 6, 2024 11:42
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Dec 6, 2024
Copy link
Contributor

@fkanout fkanout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest running this PR against the Flaky Test Runner. If it's not already the case.

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Dec 6, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

github-actions bot commented Dec 6, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 merged commit dc77e8c into elastic:main Dec 6, 2024
17 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12198339080

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 6, 2024
## Summary

Fix flaky tests for alerting default, removed unecessary code.

I tested locally 30 times and it has been fixed now.

(cherry picked from commit dc77e8c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 6, 2024
…203232)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics] Fix flaky tests for alerting default !!
(#203220)](#203220)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-12-06T11:54:07Z","message":"[Synthetics]
Fix flaky tests for alerting default !! (#203220)\n\n##
Summary\r\n\r\nFix flaky tests for alerting default, removed unecessary
code.\r\n\r\nI tested locally 30 times and it has been fixed
now.","sha":"dc77e8c149abc7a0bc2d9d3c65db0533ce45e4ff","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics]
Fix flaky tests for alerting default
!!","number":203220,"url":"https://github.com/elastic/kibana/pull/203220","mergeCommit":{"message":"[Synthetics]
Fix flaky tests for alerting default !! (#203220)\n\n##
Summary\r\n\r\nFix flaky tests for alerting default, removed unecessary
code.\r\n\r\nI tested locally 30 times and it has been fixed
now.","sha":"dc77e8c149abc7a0bc2d9d3c65db0533ce45e4ff"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203220","number":203220,"mergeCommit":{"message":"[Synthetics]
Fix flaky tests for alerting default !! (#203220)\n\n##
Summary\r\n\r\nFix flaky tests for alerting default, removed unecessary
code.\r\n\r\nI tested locally 30 times and it has been fixed
now.","sha":"dc77e8c149abc7a0bc2d9d3c65db0533ce45e4ff"}}]}] BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
@shahzad31 shahzad31 deleted the alerting-default-flaky branch December 6, 2024 14:05
markov00 pushed a commit to markov00/kibana that referenced this pull request Dec 7, 2024
## Summary

Fix flaky tests for alerting default, removed unecessary code.

I tested locally 30 times and it has been fixed now.
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
## Summary

Fix flaky tests for alerting default, removed unecessary code.

I tested locally 30 times and it has been fixed now.
SoniaSanzV pushed a commit to SoniaSanzV/kibana that referenced this pull request Dec 9, 2024
## Summary

Fix flaky tests for alerting default, removed unecessary code.

I tested locally 30 times and it has been fixed now.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
## Summary

Fix flaky tests for alerting default, removed unecessary code.

I tested locally 30 times and it has been fixed now.
Samiul-TheSoccerFan pushed a commit to Samiul-TheSoccerFan/kibana that referenced this pull request Dec 10, 2024
## Summary

Fix flaky tests for alerting default, removed unecessary code.

I tested locally 30 times and it has been fixed now.
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this pull request Dec 11, 2024
## Summary

Fix flaky tests for alerting default, removed unecessary code.

I tested locally 30 times and it has been fixed now.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

Fix flaky tests for alerting default, removed unecessary code.

I tested locally 30 times and it has been fixed now.
@shahzad31 shahzad31 added backport:version Backport to applied version labels and removed backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Feb 11, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 9.0

https://github.com/elastic/kibana/actions/runs/13263513682

@shahzad31 shahzad31 added v8.17.3 backport:version Backport to applied version labels and removed backport:version Backport to applied version labels labels Feb 11, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.18, 9.0

https://github.com/elastic/kibana/actions/runs/13263533102

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.18 Backport failed because of merge conflicts
9.0 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 203220

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2025
## Summary

Fix flaky tests for alerting default, removed unecessary code.

I tested locally 30 times and it has been fixed now.

(cherry picked from commit dc77e8c)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.17
8.18 Backport failed because of merge conflicts
9.0 Backport failed because of merge conflicts

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 203220

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 11, 2025
…#210570)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Synthetics] Fix flaky tests for alerting default !!
(#203220)](#203220)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-12-06T11:54:07Z","message":"[Synthetics]
Fix flaky tests for alerting default !! (#203220)\n\n##
Summary\r\n\r\nFix flaky tests for alerting default, removed unecessary
code.\r\n\r\nI tested locally 30 times and it has been fixed
now.","sha":"dc77e8c149abc7a0bc2d9d3c65db0533ce45e4ff","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.18.0","v9.1.0","v8.17.3"],"title":"[Synthetics]
Fix flaky tests for alerting default
!!","number":203220,"url":"https://github.com/elastic/kibana/pull/203220","mergeCommit":{"message":"[Synthetics]
Fix flaky tests for alerting default !! (#203220)\n\n##
Summary\r\n\r\nFix flaky tests for alerting default, removed unecessary
code.\r\n\r\nI tested locally 30 times and it has been fixed
now.","sha":"dc77e8c149abc7a0bc2d9d3c65db0533ce45e4ff"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203220","number":203220,"mergeCommit":{"message":"[Synthetics]
Fix flaky tests for alerting default !! (#203220)\n\n##
Summary\r\n\r\nFix flaky tests for alerting default, removed unecessary
code.\r\n\r\nI tested locally 30 times and it has been fixed
now.","sha":"dc77e8c149abc7a0bc2d9d3c65db0533ce45e4ff"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/203232","number":203232,"state":"MERGED","mergeCommit":{"sha":"9cdf4d21a2adf8cf14abad6f18375e993942dabc","message":"[8.x]
[Synthetics] Fix flaky tests for alerting default !! (#203220)
(#203232)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.x`:\n- [[Synthetics] Fix flaky tests for alerting default
!!\n(#203220)](https://github.com/elastic/kibana/pull/203220)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT\n[{\"author\":{\"name\":\"Shahzad\",\"email\":\"shahzad31comp@gmail.com\"},\"sourceCommit\":{\"committedDate\":\"2024-12-06T11:54:07Z\",\"message\":\"[Synthetics]\nFix
flaky tests for alerting default !!
(#203220)\\n\\n##\nSummary\\r\\n\\r\\nFix flaky tests for alerting
default, removed unecessary\ncode.\\r\\n\\r\\nI tested locally 30 times
and it has been
fixed\nnow.\",\"sha\":\"dc77e8c149abc7a0bc2d9d3c65db0533ce45e4ff\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-management\"],\"title\":\"[Synthetics]\nFix
flaky tests for alerting
default\n!!\",\"number\":203220,\"url\":\"https://github.com/elastic/kibana/pull/203220\",\"mergeCommit\":{\"message\":\"[Synthetics]\nFix
flaky tests for alerting default !!
(#203220)\\n\\n##\nSummary\\r\\n\\r\\nFix flaky tests for alerting
default, removed unecessary\ncode.\\r\\n\\r\\nI tested locally 30 times
and it has been
fixed\nnow.\",\"sha\":\"dc77e8c149abc7a0bc2d9d3c65db0533ce45e4ff\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/203220\",\"number\":203220,\"mergeCommit\":{\"message\":\"[Synthetics]\nFix
flaky tests for alerting default !!
(#203220)\\n\\n##\nSummary\\r\\n\\r\\nFix flaky tests for alerting
default, removed unecessary\ncode.\\r\\n\\r\\nI tested locally 30 times
and it has been
fixed\nnow.\",\"sha\":\"dc77e8c149abc7a0bc2d9d3c65db0533ce45e4ff\"}}]}]
BACKPORT-->\n\nCo-authored-by: Shahzad
<shahzad31comp@gmail.com>"}},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.17.3 v8.18.0 v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants