Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Obs AI Assistant] Query remote indices by default #193462

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+1 −1
Open

[Obs AI Assistant] Query remote indices by default #193462

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32dbd41
[Obs AI Assistant] Query remote indices by default
dgieselaar Sep 19, 2024
59af58b
Merge branch 'main' into obs-ai-assistant-ccs-by-default
elasticmachine Oct 4, 2024
a4a2acf
Merge branch 'main' into obs-ai-assistant-ccs-by-default
elasticmachine Oct 9, 2024
02a43cc
Merge branch 'main' into obs-ai-assistant-ccs-by-default
elasticmachine Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ervability_solution/observability_ai_assistant/server/functions/get_dataset_info/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export function registerGetDatasetInfoFunction({

try {
const body = await esClient.asCurrentUser.indices.resolveIndex({
name: index === '' ? '*' : index.split(','),
name: index === '' ? ['*', '*:*'] : index.split(','),
Copy link
Contributor

@neptunian neptunian Sep 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this only query remote indices if index is not specified? Is that the goal or to always query remote clusters?

I'll mention we've had issues querying * remote clusters in the past with users wanting to specify which remote clusters because it can take a long time if there are many remotes. Perhaps we can have this as a setting at some point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this only query remote indices if index is not specified? Is that the goal or to always query remote clusters?

the former yes

I'll mention we've had issues querying * remote clusters in the past with users wanting to specify which remote clusters because it can take a long time if there are many remotes. Perhaps we can have this as a setting at some point.

This only lists the indices, and then the assistant can pick one for querying, so I think that's usually fine. Agreed a setting would be nice (but also a little wary of having too many settings).

expand_wildcards: 'open',
});
indices = [
Expand Down