-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Obs AI Assistant] Query remote indices by default #193462
base: main
Are you sure you want to change the base?
[Obs AI Assistant] Query remote indices by default #193462
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
@@ -48,7 +48,7 @@ export function registerGetDatasetInfoFunction({ | |||
|
|||
try { | |||
const body = await esClient.asCurrentUser.indices.resolveIndex({ | |||
name: index === '' ? '*' : index.split(','), | |||
name: index === '' ? ['*', '*:*'] : index.split(','), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this only query remote indices if index is not specified? Is that the goal or to always query remote clusters?
I'll mention we've had issues querying * remote clusters in the past with users wanting to specify which remote clusters because it can take a long time if there are many remotes. Perhaps we can have this as a setting at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this only query remote indices if index is not specified? Is that the goal or to always query remote clusters?
the former yes
I'll mention we've had issues querying * remote clusters in the past with users wanting to specify which remote clusters because it can take a long time if there are many remotes. Perhaps we can have this as a setting at some point.
This only lists the indices, and then the assistant can pick one for querying, so I think that's usually fine. Agreed a setting would be nice (but also a little wary of having too many settings).
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @dgieselaar |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
cc @dgieselaar |
Query
[ '*', '*:*' ]
by default when listing indices.