Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs AI Assistant] Query remote indices by default #193462

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dgieselaar
Copy link
Member

Query [ '*', '*:*' ] by default when listing indices.

@dgieselaar dgieselaar added release_note:skip Skip the PR/issue when compiling release notes v8.16.0 labels Sep 19, 2024
@dgieselaar dgieselaar self-assigned this Sep 19, 2024
@dgieselaar dgieselaar requested a review from a team as a code owner September 19, 2024 17:48
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@@ -48,7 +48,7 @@ export function registerGetDatasetInfoFunction({

try {
const body = await esClient.asCurrentUser.indices.resolveIndex({
name: index === '' ? '*' : index.split(','),
name: index === '' ? ['*', '*:*'] : index.split(','),
Copy link
Contributor

@neptunian neptunian Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this only query remote indices if index is not specified? Is that the goal or to always query remote clusters?

I'll mention we've had issues querying * remote clusters in the past with users wanting to specify which remote clusters because it can take a long time if there are many remotes. Perhaps we can have this as a setting at some point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this only query remote indices if index is not specified? Is that the goal or to always query remote clusters?

the former yes

I'll mention we've had issues querying * remote clusters in the past with users wanting to specify which remote clusters because it can take a long time if there are many remotes. Perhaps we can have this as a setting at some point.

This only lists the indices, and then the assistant can pick one for querying, so I think that's usually fine. Agreed a setting would be nice (but also a little wary of having too many settings).

@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

@dgieselaar dgieselaar added v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:current-major Backport to all previous minor branches labels Oct 4, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 4, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 59af58b
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193462-59af58bf17b1

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dgieselaar

@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

@dgieselaar dgieselaar enabled auto-merge (squash) October 9, 2024 16:18
@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 16, 2024

💔 Build Failed

  • Buildkite Build
  • Commit: 02a43cc
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193462-02a43cce32fd

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #48 / Entity Analytics - Entity Store @ess @skipInServerlessMKI Entity Store Engine APIs init should have installed the expected user resources
  • [job] [logs] FTR Configs #48 / Entity Analytics - Entity Store @ess @skipInServerlessMKI Entity Store Engine APIs init should have installed the expected user resources
  • [job] [logs] FTR Configs #84 / Entity Analytics - Risk Engine @ess @serverless @serverlessQA init_and_status_apis status api should disable / enable risk engine

Metrics [docs]

✅ unchanged

History

cc @dgieselaar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:current-major Backport to all previous minor branches backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants