[Secuity Solution][DQD] add historical results (Phase 1) #191898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapral18
changed the title
kapral18
added
8.16 candidate
v8.16.0
Team:Threat Hunting
kapral18
force-pushed
the
feat/DQD/185882-add-historical-tab
branch
from
f8fdfe6
to
9aaa871
Compare
kapral18
added
ci:cloud-deploy
kapral18
force-pushed
the
feat/DQD/185882-add-historical-tab
branch
6 times, most recently
from
cd06cc9
to
021edde
Compare
kapral18
force-pushed
the
feat/DQD/185882-add-historical-tab
branch
3 times, most recently
from
fa35ca9
to
68a7041
Compare
kapral18
force-pushed
the
feat/DQD/185882-add-historical-tab
branch
2 times, most recently
from
68f53da
to
c72f04d
Compare
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
kapral18
added
backport:prev-minor
- add historical results fetching logic with hooks/utils/contexts - add filtering by outcome - add filtering by date - add pagination - add error handling - add loading state - rename index properties into latest results - add total checks - add accordion component titles (result badge + check time + incompatible count) - refactor affected parts
- added `EuiEmptyPrompt` for no historical results scenario. - flattened translations - flattened tabs/ - removed unused `missing_timestamp_callout` component and related helpers. - Updated tests to reflect new file structure and imports.
- implement flyout base functionality of historical results showing incompatible and same family tabs - add index stats panel at the top - add check now to latest check redirect
- Introduced constants for HISTORY_TAB_ID and LATEST_CHECK_TAB_ID. - Lifted historical results hook and context up to accomodate calling fetch historical results from pattern level - Updated components to utilize new tab functionality for viewing historical results and latest checks. - Added 2 distinct non results empty prompt translations for when there is no results vs no results in given range - Most tests are broken with this commit, updated tests will come in next one
kapral18
force-pushed
the
feat/DQD/185882-add-historical-tab
branch
from
ae8043e
to
e282dde
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @kapral18 |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 11, 2024
) addresses elastic#185882 leverages changes introduced in elastic#188468 # Data Quality Dashboard Historical Results (Phase 1) This PR introduces new functionality to the Data Quality Dashboard History tab (new): - view last 30 days of check results by default: - filter by historical checks by outcome (PASS/FAIL/ALL) - paginate all results (10 per page by default) - each result can be viewed in individually and independently expandable/collapsible accordion panel (collapsed by default) - each result contains an extended index stats panel with (custom, ecs and all fields counts) - each result contains index properties tabs (incompatible and same family) - check now checks and redirects to latest check tab with latest check info - switching from initial historical tab to latest check tab triggers latest check - subsequent switching back and forth between already open history or latest check tabs doesn't trigger a check - legacy data (before release of this elastic#185025) is supported with degraded view (same family tab is disabled with warning tooltip), incompatible tab tables are statically rendered from markdown Latest checks list view (changes): - remove check index button icon from list view - add historical results button icon instead of check index button - historical results button icon directly opens history tab without going through latest check # UI Changes (before/after): ## ESS Changes ### Latest check expand icon - expand icon is replaced with check now icon (functionality is the same) - tooltip text is updated - this new icon is still opening the index check flyout tab (latest check tab)  ### Historical check icon **(NEW)** - inline check now functionality is removed - view history icon is added in its stead to open a flyout with history tab - tooltip text is updated  ### Flyout Header - "checked at" subheader is now shorter (milliseconds are removed) - Tabline with Latest check and History tabs is added **(NEW)**  ### History tab **(NEW)** - top left: filter by check outcome - top right: filter by date range - list of checks collapsed by default (individually separately controlled, multiple can be open at a time) - pagination (10,25,50). 10 by default  ### Individual check result view **(NEW)** - topline: extended index stats including new "custom", "ecs compliant" & "all fields". - incompatible fields and same family fields view (custom, ecs compliant and all fields view is unavailable in history tab)  ### Legacy check result view **(NEW)** - before this PR went to production elastic#185025 check result data contained information allowing to recreate detailed view of incompatible fields from markdown only (without same family fields) - we recreate incompatible field tables in degraded view from markdown - same family tab is permanently disabled with an explanation tooltip - action buttons still work as is for incompatible fields view - index stats panel is showing as for non-legacy result  ### No results  ### Loading view  ### Error view  ## Serverless Changes ### Empty checks result badge **(FIX)** - **previously empty pattern check result badge was marked as `PASS` which was incorrect. It was removed.**  ### Latest check expand icon - expand icon is replaced with check now icon (functionality is the same) - tooltip text is updated - this new icon is still opening the index check flyout tab (latest check tab)  ### Historical check icon **(NEW)** - inline check now functionality is removed - view history icon is added in its stead to open a flyout with history tab - tooltip text is updated  ### Flyout Header and Body Topline - "checked at" subheader is now shorter (milliseconds are removed) - Tabline with Latest check and History tabs is added **(NEW)** - **Index Stats Panel is now also showing here just like in latest check tab (but without phase label as ilm is not available in serverless)** **(NEW)**  ### History tab **(NEW)** - top left: filter by check outcome - top right: filter by date range - list of checks collapsed by default (individually separately controlled, multiple can be open at a time) - pagination (10,25,50). 10 by default  ### Individual check result view **(NEW)** - topline: extended index stats including new "custom", "ecs compliant" & "all fields" but **excluding ilm phase label section**. - incompatible fields and same family fields view (custom, ecs compliant and all fields view is unavailable in history tab)  ### Legacy check result view **(NEW)** - before this PR went to production elastic#185025 check result data contained information allowing to recreate detailed view of incompatible fields from markdown only (without same family fields) - we recreate incompatible field tables in degraded view from markdown - same family tab is permanently disabled with an explanation tooltip - action buttons still work as is for incompatible fields view - index stats panel is showing as for non-legacy result  ### No results  ### Loading view  ### Error view  (cherry picked from commit e5f7739)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 11, 2024
…) (#195962) # Backport This will backport the following commits from `main` to `8.x`: - [[Secuity Solution][DQD] add historical results (Phase 1) (#191898)](#191898) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Karen Grigoryan","email":"karen.grigoryan@elastic.co"},"sourceCommit":{"committedDate":"2024-10-11T16:14:11Z","message":"[Secuity Solution][DQD] add historical results (Phase 1) (#191898)\n\naddresses #185882 \r\n\r\nleverages changes introduced in\r\nhttps://github.com//pull/188468\r\n\r\n# Data Quality Dashboard Historical Results (Phase 1)\r\n\r\nThis PR introduces new functionality to the Data Quality Dashboard\r\n\r\nHistory tab (new):\r\n- view last 30 days of check results by default:\r\n- filter by historical checks by outcome (PASS/FAIL/ALL)\r\n- paginate all results (10 per page by default)\r\n- each result can be viewed in individually and independently\r\nexpandable/collapsible accordion panel (collapsed by default)\r\n- each result contains an extended index stats panel with (custom, ecs\r\nand all fields counts)\r\n- each result contains index properties tabs (incompatible and same\r\nfamily)\r\n- check now checks and redirects to latest check tab with latest check\r\ninfo\r\n- switching from initial historical tab to latest check tab triggers\r\nlatest check\r\n- subsequent switching back and forth between already open history or\r\nlatest check tabs doesn't trigger a check\r\n- legacy data (before release of this\r\nhttps://github.com//pull/185025) is supported with\r\ndegraded view (same family tab is disabled with warning tooltip),\r\nincompatible tab tables are statically rendered from markdown\r\n\r\nLatest checks list view (changes):\r\n- remove check index button icon from list view\r\n- add historical results button icon instead of check index button\r\n- historical results button icon directly opens history tab without\r\ngoing through latest check\r\n\r\n# UI Changes (before/after):\r\n\r\n## ESS Changes\r\n\r\n### Latest check expand icon\r\n- expand icon is replaced with check now icon (functionality is the\r\nsame)\r\n- tooltip text is updated\r\n- this new icon is still opening the index check flyout tab (latest\r\ncheck tab)\r\n\r\n\r\n\r\n### Historical check icon **(NEW)**\r\n- inline check now functionality is removed\r\n- view history icon is added in its stead to open a flyout with history\r\ntab\r\n- tooltip text is updated\r\n\r\n\r\n\r\n### Flyout Header\r\n- \"checked at\" subheader is now shorter (milliseconds are removed)\r\n- Tabline with Latest check and History tabs is added **(NEW)**\r\n\r\n\r\n\r\n### History tab **(NEW)**\r\n- top left: filter by check outcome\r\n- top right: filter by date range\r\n- list of checks collapsed by default (individually separately\r\ncontrolled, multiple can be open at a time)\r\n- pagination (10,25,50). 10 by default\r\n\r\n\r\n\r\n### Individual check result view **(NEW)**\r\n- topline: extended index stats including new \"custom\", \"ecs compliant\"\r\n& \"all fields\".\r\n- incompatible fields and same family fields view (custom, ecs compliant\r\nand all fields view is unavailable in history tab)\r\n\r\n\r\n\r\n### Legacy check result view **(NEW)**\r\n- before this PR went to production\r\nhttps://github.com//pull/185025 check result data\r\ncontained information allowing to recreate detailed view of incompatible\r\nfields from markdown only (without same family fields)\r\n- we recreate incompatible field tables in degraded view from markdown\r\n- same family tab is permanently disabled with an explanation tooltip\r\n- action buttons still work as is for incompatible fields view\r\n- index stats panel is showing as for non-legacy result\r\n\r\n\r\n\r\n### No results\r\n\r\n\r\n\r\n### Loading view\r\n\r\n\r\n\r\n### Error view\r\n\r\n\r\n\r\n## Serverless Changes\r\n### Empty checks result badge **(FIX)**\r\n- **previously empty pattern check result badge was marked as `PASS`\r\nwhich was incorrect. It was removed.**\r\n\r\n\r\n\r\n### Latest check expand icon\r\n- expand icon is replaced with check now icon (functionality is the\r\nsame)\r\n- tooltip text is updated\r\n- this new icon is still opening the index check flyout tab (latest\r\ncheck tab)\r\n\r\n\r\n\r\n### Historical check icon **(NEW)**\r\n- inline check now functionality is removed\r\n- view history icon is added in its stead to open a flyout with history\r\ntab\r\n- tooltip text is updated\r\n\r\n\r\n\r\n### Flyout Header and Body Topline\r\n- \"checked at\" subheader is now shorter (milliseconds are removed)\r\n- Tabline with Latest check and History tabs is added **(NEW)**\r\n- **Index Stats Panel is now also showing here just like in latest check\r\ntab (but without phase label as ilm is not available in serverless)**\r\n**(NEW)**\r\n\r\n\r\n\r\n### History tab **(NEW)**\r\n- top left: filter by check outcome\r\n- top right: filter by date range\r\n- list of checks collapsed by default (individually separately\r\ncontrolled, multiple can be open at a time)\r\n- pagination (10,25,50). 10 by default\r\n\r\n\r\n\r\n### Individual check result view **(NEW)**\r\n- topline: extended index stats including new \"custom\", \"ecs compliant\"\r\n& \"all fields\" but **excluding ilm phase label section**.\r\n- incompatible fields and same family fields view (custom, ecs compliant\r\nand all fields view is unavailable in history tab)\r\n\r\n\r\n\r\n### Legacy check result view **(NEW)**\r\n- before this PR went to production\r\nhttps://github.com//pull/185025 check result data\r\ncontained information allowing to recreate detailed view of incompatible\r\nfields from markdown only (without same family fields)\r\n- we recreate incompatible field tables in degraded view from markdown\r\n- same family tab is permanently disabled with an explanation tooltip\r\n- action buttons still work as is for incompatible fields view\r\n- index stats panel is showing as for non-legacy result\r\n\r\n\r\n\r\n### No results\r\n\r\n\r\n\r\n### Loading view\r\n\r\n\r\n\r\n### Error view\r\n\r\n","sha":"e5f7739b263902bd01aca9fa902be7cc5181e855","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["v9.0.0","Team:Threat Hunting","release_note:feature","Team:Threat Hunting:Explore","backport:prev-minor","ci:cloud-deploy","ci:cloud-redeploy","ci:cloud-persist-deployment","ci:build-serverless-image","ci:project-deploy-security","ci:project-persist-deployment","ci:project-redeploy","v8.16.0"],"title":"[Secuity Solution][DQD] add historical results (Phase 1) ","number":191898,"url":"https://github.com/elastic/kibana/pull/191898","mergeCommit":{"message":"[Secuity Solution][DQD] add historical results (Phase 1) (#191898)\n\naddresses #185882 \r\n\r\nleverages changes introduced in\r\nhttps://github.com//pull/188468\r\n\r\n# Data Quality Dashboard Historical Results (Phase 1)\r\n\r\nThis PR introduces new functionality to the Data Quality Dashboard\r\n\r\nHistory tab (new):\r\n- view last 30 days of check results by default:\r\n- filter by historical checks by outcome (PASS/FAIL/ALL)\r\n- paginate all results (10 per page by default)\r\n- each result can be viewed in individually and independently\r\nexpandable/collapsible accordion panel (collapsed by default)\r\n- each result contains an extended index stats panel with (custom, ecs\r\nand all fields counts)\r\n- each result contains index properties tabs (incompatible and same\r\nfamily)\r\n- check now checks and redirects to latest check tab with latest check\r\ninfo\r\n- switching from initial historical tab to latest check tab triggers\r\nlatest check\r\n- subsequent switching back and forth between already open history or\r\nlatest check tabs doesn't trigger a check\r\n- legacy data (before release of this\r\nhttps://github.com//pull/185025) is supported with\r\ndegraded view (same family tab is disabled with warning tooltip),\r\nincompatible tab tables are statically rendered from markdown\r\n\r\nLatest checks list view (changes):\r\n- remove check index button icon from list view\r\n- add historical results button icon instead of check index button\r\n- historical results button icon directly opens history tab without\r\ngoing through latest check\r\n\r\n# UI Changes (before/after):\r\n\r\n## ESS Changes\r\n\r\n### Latest check expand icon\r\n- expand icon is replaced with check now icon (functionality is the\r\nsame)\r\n- tooltip text is updated\r\n- this new icon is still opening the index check flyout tab (latest\r\ncheck tab)\r\n\r\n\r\n\r\n### Historical check icon **(NEW)**\r\n- inline check now functionality is removed\r\n- view history icon is added in its stead to open a flyout with history\r\ntab\r\n- tooltip text is updated\r\n\r\n\r\n\r\n### Flyout Header\r\n- \"checked at\" subheader is now shorter (milliseconds are removed)\r\n- Tabline with Latest check and History tabs is added **(NEW)**\r\n\r\n\r\n\r\n### History tab **(NEW)**\r\n- top left: filter by check outcome\r\n- top right: filter by date range\r\n- list of checks collapsed by default (individually separately\r\ncontrolled, multiple can be open at a time)\r\n- pagination (10,25,50). 10 by default\r\n\r\n\r\n\r\n### Individual check result view **(NEW)**\r\n- topline: extended index stats including new \"custom\", \"ecs compliant\"\r\n& \"all fields\".\r\n- incompatible fields and same family fields view (custom, ecs compliant\r\nand all fields view is unavailable in history tab)\r\n\r\n\r\n\r\n### Legacy check result view **(NEW)**\r\n- before this PR went to production\r\nhttps://github.com//pull/185025 check result data\r\ncontained information allowing to recreate detailed view of incompatible\r\nfields from markdown only (without same family fields)\r\n- we recreate incompatible field tables in degraded view from markdown\r\n- same family tab is permanently disabled with an explanation tooltip\r\n- action buttons still work as is for incompatible fields view\r\n- index stats panel is showing as for non-legacy result\r\n\r\n\r\n\r\n### No results\r\n\r\n\r\n\r\n### Loading view\r\n\r\n\r\n\r\n### Error view\r\n\r\n\r\n\r\n## Serverless Changes\r\n### Empty checks result badge **(FIX)**\r\n- **previously empty pattern check result badge was marked as `PASS`\r\nwhich was incorrect. It was removed.**\r\n\r\n\r\n\r\n### Latest check expand icon\r\n- expand icon is replaced with check now icon (functionality is the\r\nsame)\r\n- tooltip text is updated\r\n- this new icon is still opening the index check flyout tab (latest\r\ncheck tab)\r\n\r\n\r\n\r\n### Historical check icon **(NEW)**\r\n- inline check now functionality is removed\r\n- view history icon is added in its stead to open a flyout with history\r\ntab\r\n- tooltip text is updated\r\n\r\n\r\n\r\n### Flyout Header and Body Topline\r\n- \"checked at\" subheader is now shorter (milliseconds are removed)\r\n- Tabline with Latest check and History tabs is added **(NEW)**\r\n- **Index Stats Panel is now also showing here just like in latest check\r\ntab (but without phase label as ilm is not available in serverless)**\r\n**(NEW)**\r\n\r\n\r\n\r\n### History tab **(NEW)**\r\n- top left: filter by check outcome\r\n- top right: filter by date range\r\n- list of checks collapsed by default (individually separately\r\ncontrolled, multiple can be open at a time)\r\n- pagination (10,25,50). 10 by default\r\n\r\n\r\n\r\n### Individual check result view **(NEW)**\r\n- topline: extended index stats including new \"custom\", \"ecs compliant\"\r\n& \"all fields\" but **excluding ilm phase label section**.\r\n- incompatible fields and same family fields view (custom, ecs compliant\r\nand all fields view is unavailable in history tab)\r\n\r\n\r\n\r\n### Legacy check result view **(NEW)**\r\n- before this PR went to production\r\nhttps://github.com//pull/185025 check result data\r\ncontained information allowing to recreate detailed view of incompatible\r\nfields from markdown only (without same family fields)\r\n- we recreate incompatible field tables in degraded view from markdown\r\n- same family tab is permanently disabled with an explanation tooltip\r\n- action buttons still work as is for incompatible fields view\r\n- index stats panel is showing as for non-legacy result\r\n\r\n\r\n\r\n### No results\r\n\r\n\r\n\r\n### Loading view\r\n\r\n\r\n\r\n### Error view\r\n\r\n","sha":"e5f7739b263902bd01aca9fa902be7cc5181e855"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191898","number":191898,"mergeCommit":{"message":"[Secuity Solution][DQD] add historical results (Phase 1) (#191898)\n\naddresses #185882 \r\n\r\nleverages changes introduced in\r\nhttps://github.com//pull/188468\r\n\r\n# Data Quality Dashboard Historical Results (Phase 1)\r\n\r\nThis PR introduces new functionality to the Data Quality Dashboard\r\n\r\nHistory tab (new):\r\n- view last 30 days of check results by default:\r\n- filter by historical checks by outcome (PASS/FAIL/ALL)\r\n- paginate all results (10 per page by default)\r\n- each result can be viewed in individually and independently\r\nexpandable/collapsible accordion panel (collapsed by default)\r\n- each result contains an extended index stats panel with (custom, ecs\r\nand all fields counts)\r\n- each result contains index properties tabs (incompatible and same\r\nfamily)\r\n- check now checks and redirects to latest check tab with latest check\r\ninfo\r\n- switching from initial historical tab to latest check tab triggers\r\nlatest check\r\n- subsequent switching back and forth between already open history or\r\nlatest check tabs doesn't trigger a check\r\n- legacy data (before release of this\r\nhttps://github.com//pull/185025) is supported with\r\ndegraded view (same family tab is disabled with warning tooltip),\r\nincompatible tab tables are statically rendered from markdown\r\n\r\nLatest checks list view (changes):\r\n- remove check index button icon from list view\r\n- add historical results button icon instead of check index button\r\n- historical results button icon directly opens history tab without\r\ngoing through latest check\r\n\r\n# UI Changes (before/after):\r\n\r\n## ESS Changes\r\n\r\n### Latest check expand icon\r\n- expand icon is replaced with check now icon (functionality is the\r\nsame)\r\n- tooltip text is updated\r\n- this new icon is still opening the index check flyout tab (latest\r\ncheck tab)\r\n\r\n\r\n\r\n### Historical check icon **(NEW)**\r\n- inline check now functionality is removed\r\n- view history icon is added in its stead to open a flyout with history\r\ntab\r\n- tooltip text is updated\r\n\r\n\r\n\r\n### Flyout Header\r\n- \"checked at\" subheader is now shorter (milliseconds are removed)\r\n- Tabline with Latest check and History tabs is added **(NEW)**\r\n\r\n\r\n\r\n### History tab **(NEW)**\r\n- top left: filter by check outcome\r\n- top right: filter by date range\r\n- list of checks collapsed by default (individually separately\r\ncontrolled, multiple can be open at a time)\r\n- pagination (10,25,50). 10 by default\r\n\r\n\r\n\r\n### Individual check result view **(NEW)**\r\n- topline: extended index stats including new \"custom\", \"ecs compliant\"\r\n& \"all fields\".\r\n- incompatible fields and same family fields view (custom, ecs compliant\r\nand all fields view is unavailable in history tab)\r\n\r\n\r\n\r\n### Legacy check result view **(NEW)**\r\n- before this PR went to production\r\nhttps://github.com//pull/185025 check result data\r\ncontained information allowing to recreate detailed view of incompatible\r\nfields from markdown only (without same family fields)\r\n- we recreate incompatible field tables in degraded view from markdown\r\n- same family tab is permanently disabled with an explanation tooltip\r\n- action buttons still work as is for incompatible fields view\r\n- index stats panel is showing as for non-legacy result\r\n\r\n\r\n\r\n### No results\r\n\r\n\r\n\r\n### Loading view\r\n\r\n\r\n\r\n### Error view\r\n\r\n\r\n\r\n## Serverless Changes\r\n### Empty checks result badge **(FIX)**\r\n- **previously empty pattern check result badge was marked as `PASS`\r\nwhich was incorrect. It was removed.**\r\n\r\n\r\n\r\n### Latest check expand icon\r\n- expand icon is replaced with check now icon (functionality is the\r\nsame)\r\n- tooltip text is updated\r\n- this new icon is still opening the index check flyout tab (latest\r\ncheck tab)\r\n\r\n\r\n\r\n### Historical check icon **(NEW)**\r\n- inline check now functionality is removed\r\n- view history icon is added in its stead to open a flyout with history\r\ntab\r\n- tooltip text is updated\r\n\r\n\r\n\r\n### Flyout Header and Body Topline\r\n- \"checked at\" subheader is now shorter (milliseconds are removed)\r\n- Tabline with Latest check and History tabs is added **(NEW)**\r\n- **Index Stats Panel is now also showing here just like in latest check\r\ntab (but without phase label as ilm is not available in serverless)**\r\n**(NEW)**\r\n\r\n\r\n\r\n### History tab **(NEW)**\r\n- top left: filter by check outcome\r\n- top right: filter by date range\r\n- list of checks collapsed by default (individually separately\r\ncontrolled, multiple can be open at a time)\r\n- pagination (10,25,50). 10 by default\r\n\r\n\r\n\r\n### Individual check result view **(NEW)**\r\n- topline: extended index stats including new \"custom\", \"ecs compliant\"\r\n& \"all fields\" but **excluding ilm phase label section**.\r\n- incompatible fields and same family fields view (custom, ecs compliant\r\nand all fields view is unavailable in history tab)\r\n\r\n\r\n\r\n### Legacy check result view **(NEW)**\r\n- before this PR went to production\r\nhttps://github.com//pull/185025 check result data\r\ncontained information allowing to recreate detailed view of incompatible\r\nfields from markdown only (without same family fields)\r\n- we recreate incompatible field tables in degraded view from markdown\r\n- same family tab is permanently disabled with an explanation tooltip\r\n- action buttons still work as is for incompatible fields view\r\n- index stats panel is showing as for non-legacy result\r\n\r\n\r\n\r\n### No results\r\n\r\n\r\n\r\n### Loading view\r\n\r\n\r\n\r\n### Error view\r\n\r\n","sha":"e5f7739b263902bd01aca9fa902be7cc5181e855"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Karen Grigoryan <karen.grigoryan@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #185882
leverages changes introduced in #188468
Data Quality Dashboard Historical Results (Phase 1)
This PR introduces new functionality to the Data Quality Dashboard
History tab (new):
Latest checks list view (changes):
UI Changes (before/after):
ESS Changes
Latest check expand icon
Historical check icon (NEW)
Flyout Header
History tab (NEW)
Individual check result view (NEW)
Legacy check result view (NEW)
No results
Loading view
Error view
Serverless Changes
Empty checks result badge (FIX)
PASSwhich was incorrect. It was removed.Latest check expand icon
Historical check icon (NEW)
Flyout Header and Body Topline
History tab (NEW)
Individual check result view (NEW)
Legacy check result view (NEW)
No results
Loading view
Error view