Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][DQD][Tech Debt] Refactor lower level helpers #191245

Merged

Conversation

kapral18
Copy link
Contributor

addresses #190964

Fourth in the series of PRs to address general DQD tech debt

This one builds on previous 3 PRs

#190970
#190978
#191233

Gist of changes:

split lower level helpers into series of utils/* files
each utils/ file is named after common behavior it export or works with.
cleanup dead code

@kapral18 kapral18 self-assigned this Aug 24, 2024
@kapral18 kapral18 requested a review from a team as a code owner August 24, 2024 23:42
@kapral18 kapral18 added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore v8.16.0 labels Aug 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@kapral18 kapral18 marked this pull request as draft August 24, 2024 23:43
@kapral18 kapral18 force-pushed the improve/DQD/190964-tech-debt-cleanup-4 branch 3 times, most recently from 47518dc to 3491387 Compare August 26, 2024 10:27
@kapral18 kapral18 marked this pull request as ready for review August 26, 2024 10:28
@kapral18 kapral18 force-pushed the improve/DQD/190964-tech-debt-cleanup-4 branch 4 times, most recently from 19e1352 to 061171c Compare August 26, 2024 14:44
; Outdated Show resolved Hide resolved
@kapral18 kapral18 force-pushed the improve/DQD/190964-tech-debt-cleanup-4 branch from 061171c to 2d3ef5f Compare August 27, 2024 13:03
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5709 5724 +15

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 18.0MB 18.0MB +461.0B

History

  • 💛 Build #229812 was flaky 061171c6709ac9b787d123a7aee2c18b99052b89
  • 💚 Build #229759 succeeded 19e1352ada6848852fc470f036a84a07eb40ee4b
  • 💔 Build #229713 failed 34913874b67b5d9502aa477ef28aa4089dcc76b6
  • 💚 Build #229637 succeeded 71a98226db6a92f4634106fe3c72bffac667762b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kapral18

@kapral18 kapral18 requested a review from semd August 27, 2024 16:43
@kapral18 kapral18 merged commit 7f22ca5 into elastic:main Aug 28, 2024
38 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 28, 2024
@kapral18 kapral18 deleted the improve/DQD/190964-tech-debt-cleanup-4 branch August 28, 2024 08:12
kapral18 added a commit that referenced this pull request Aug 28, 2024
#191264)

addresses #190964

Fifth in the series of PRs to address general DQD tech debt

This one builds on previous 4 PRs

#190970
#190978
#191233
#191245

Gist of changes:

- split gigantic markdown helper file and colocate the parts where they
belong
- dedupe translations
- cleanup dead code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team technical debt Improvement of the software architecture and operational architecture v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants