-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][DQD][Tech Debt] Refactor lower level helpers #191245
Merged
kapral18
merged 5 commits into
elastic:main
from
kapral18:improve/DQD/190964-tech-debt-cleanup-4
Aug 28, 2024
Merged
[Security Solution][DQD][Tech Debt] Refactor lower level helpers #191245
kapral18
merged 5 commits into
elastic:main
from
kapral18:improve/DQD/190964-tech-debt-cleanup-4
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapral18
added
technical debt
Improvement of the software architecture and operational architecture
release_note:skip
Skip the PR/issue when compiling release notes
Team:Threat Hunting
Security Solution Threat Hunting Team
Team:Threat Hunting:Explore
v8.16.0
labels
Aug 24, 2024
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
kapral18
force-pushed
the
improve/DQD/190964-tech-debt-cleanup-4
branch
3 times, most recently
from
August 26, 2024 10:27
47518dc
to
3491387
Compare
kapral18
force-pushed
the
improve/DQD/190964-tech-debt-cleanup-4
branch
4 times, most recently
from
August 26, 2024 14:44
19e1352
to
061171c
Compare
semd
reviewed
Aug 27, 2024
kapral18
force-pushed
the
improve/DQD/190964-tech-debt-cleanup-4
branch
from
August 27, 2024 13:03
061171c
to
2d3ef5f
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @kapral18 |
semd
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Threat Hunting:Explore
Team:Threat Hunting
Security Solution Threat Hunting Team
technical debt
Improvement of the software architecture and operational architecture
v8.16.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #190964
Fourth in the series of PRs to address general DQD tech debt
This one builds on previous 3 PRs
#190970
#190978
#191233
Gist of changes:
split lower level helpers into series of utils/* files
each utils/ file is named after common behavior it export or works with.
cleanup dead code