Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][DQD][Tech Debt] Refactor top level helpers #191233

Merged

Conversation

kapral18
Copy link
Contributor

@kapral18 kapral18 commented Aug 23, 2024

addresses #190964

Third in the series of PRs to address general DQD tech debt

This one builds on previous 2 PRs

#190970
#190978

Gist of changes:

  • split top level helpers into series of utils/* files
  • each utils/ file is named after common behavior it export or works with.
  • cleanup dead code

@kapral18 kapral18 self-assigned this Aug 23, 2024
@kapral18 kapral18 requested a review from a team as a code owner August 23, 2024 23:03
@kapral18 kapral18 marked this pull request as draft August 23, 2024 23:03
@kapral18 kapral18 added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore v8.16.0 technical debt Improvement of the software architecture and operational architecture labels Aug 23, 2024
@kapral18 kapral18 marked this pull request as ready for review August 23, 2024 23:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@kapral18 kapral18 changed the title [Security Solution][DQD][Tech Debt] Refactor helpers [Security Solution][DQD][Tech Debt] Refactor helper Aug 23, 2024
@kapral18 kapral18 changed the title [Security Solution][DQD][Tech Debt] Refactor helper [Security Solution][DQD][Tech Debt] Refactor top level helpers Aug 23, 2024
@kapral18 kapral18 force-pushed the improve/DQD/190964-tech-debt-cleanup-3 branch from 5d6788f to 6e8555a Compare August 23, 2024 23:21
@kapral18 kapral18 force-pushed the improve/DQD/190964-tech-debt-cleanup-3 branch from 6e8555a to e834eb5 Compare August 26, 2024 10:42
@kapral18 kapral18 closed this Aug 26, 2024
@kapral18 kapral18 reopened this Aug 26, 2024
@kapral18 kapral18 force-pushed the improve/DQD/190964-tech-debt-cleanup-3 branch from e834eb5 to 6b3b423 Compare August 26, 2024 12:38
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Much better organized than before. Thanks Karen!
LGTM

@kapral18 kapral18 enabled auto-merge (squash) August 26, 2024 13:11
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #79 / Cloud Security Posture Test adding Cloud Security Posture Integrations CSPM AWS CIS_AWS Organization Manual Direct Access CIS_AWS Organization Manual Direct Access Workflow

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5676 5695 +19

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 18.0MB 18.0MB -2.1KB

History

  • 💚 Build #229723 succeeded e834eb57f0d23d6455be6e8d6ed687052f37260c
  • 💔 Build #229607 failed 6e8555aedacc944247877ebf1a243cddd3f09ed8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kapral18

@kapral18 kapral18 merged commit ad36040 into elastic:main Aug 26, 2024
37 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 26, 2024
@kapral18 kapral18 deleted the improve/DQD/190964-tech-debt-cleanup-3 branch August 26, 2024 14:45
kapral18 added a commit that referenced this pull request Aug 28, 2024
…1245)

addresses #190964

Fourth in the series of PRs to address general DQD tech debt

This one builds on previous 3 PRs

#190970
#190978
#191233

Gist of changes:

split lower level helpers into series of utils/* files
each utils/ file is named after common behavior it export or works with.
cleanup dead code
kapral18 added a commit that referenced this pull request Aug 28, 2024
#191264)

addresses #190964

Fifth in the series of PRs to address general DQD tech debt

This one builds on previous 4 PRs

#190970
#190978
#191233
#191245

Gist of changes:

- split gigantic markdown helper file and colocate the parts where they
belong
- dedupe translations
- cleanup dead code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team technical debt Improvement of the software architecture and operational architecture v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants