Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Display owner type in package details #171239

Merged
merged 4 commits into from
Nov 15, 2023
Merged

[Fleet] Display owner type in package details #171239

merged 4 commits into from
Nov 15, 2023

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Nov 14, 2023 •
edited
Loading

Summary

Resolve #167981
Depends on elastic/package-registry#1115

Display owner.type as Developed by in package. details

UI Changes

Note there is currently a bug on the details width #171224

Screenshot 2023-11-14 at 3 14 01 PM Screenshot 2023-11-14 at 3 14 24 PM

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 14, 2023
@nchaulet nchaulet self-assigned this Nov 14, 2023
@nchaulet nchaulet requested a review from a team as a code owner November 14, 2023 20:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

kpollich
kpollich reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.2MB 1.2MB +639.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 74a5fba into elastic:main Nov 15, 2023
30 checks passed
@nchaulet nchaulet deleted the feature-display-owner-type branch November 15, 2023 16:14
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 15, 2023
@logeekal logeekal mentioned this pull request Nov 16, 2023
Closed
jillguyonnet pushed a commit to jillguyonnet/kibana that referenced this pull request Nov 16, 2023
@nchaulet @jillguyonnet
[Fleet] Display owner type in package details (elastic#171239)
91be80e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

Assignees

@nchaulet nchaulet

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Display owner.type field from package manifest on integration overview page
6 participants
@nchaulet @elasticmachine @apmmachine @kibana-ci @kpollich @kibanamachine