[Security Solution] Expandable flyout - Update index field in analyzer preview #165398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christineweng
added
release_note:fix
Team:Threat Hunting:Investigations
PhilippeOberti
approved these changes
Aug 31, 2023
💔 Build FailedFailed CI Steps
Test FailuresMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 1, 2023
…r preview (elastic#165398) ## Summary This PR addresses a bug that when a rule is created using data view, analyzer preview is blank. This is due to a check on if index exists before rendering the analyzer preview. This PR updated the index field from `kibana.alert.rule.parameter.index` to 'kibana.alert.rule.indices`, the later is introduced in elastic#130929 and is available when a rule is created using either index patterns or data view. **How to reproduce the bug** - Refer to bug report elastic#164829 **How to test** - Create a rule using data view - Generate some alerts - Go to alerts page, expand a row in alerts table - Go to Visualization -> Analyzer preview, the analyzer preview tree should be present  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 88c04e5)
kibanamachine
added a commit
that referenced
this pull request
Sep 1, 2023
…analyzer preview (#165398) (#165508) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution] Expandable flyout - Update index field in analyzer preview (#165398)](#165398) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-09-01T17:45:26Z","message":"[Security Solution] Expandable flyout - Update index field in analyzer preview (#165398)\n\n## Summary\r\n\r\nThis PR addresses a bug that when a rule is created using data view,\r\nanalyzer preview is blank. This is due to a check on if index exists\r\nbefore rendering the analyzer preview. This PR updated the index field\r\nfrom `kibana.alert.rule.parameter.index` to 'kibana.alert.rule.indices`,\r\nthe later is introduced in https://github.com/elastic/kibana/pull/130929\r\nand is available when a rule is created using either index patterns or\r\ndata view.\r\n\r\n**How to reproduce the bug**\r\n- Refer to bug report https://github.com/elastic/kibana/issues/164829\r\n\r\n**How to test**\r\n- Create a rule using data view\r\n- Generate some alerts\r\n- Go to alerts page, expand a row in alerts table\r\n- Go to Visualization -> Analyzer preview, the analyzer preview tree\r\nshould be present\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"88c04e5c94f81c0c7b7ba4b965725a8878480bd9","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting:Investigations","v8.10.0","v8.11.0"],"number":165398,"url":"https://github.com/elastic/kibana/pull/165398","mergeCommit":{"message":"[Security Solution] Expandable flyout - Update index field in analyzer preview (#165398)\n\n## Summary\r\n\r\nThis PR addresses a bug that when a rule is created using data view,\r\nanalyzer preview is blank. This is due to a check on if index exists\r\nbefore rendering the analyzer preview. This PR updated the index field\r\nfrom `kibana.alert.rule.parameter.index` to 'kibana.alert.rule.indices`,\r\nthe later is introduced in https://github.com/elastic/kibana/pull/130929\r\nand is available when a rule is created using either index patterns or\r\ndata view.\r\n\r\n**How to reproduce the bug**\r\n- Refer to bug report https://github.com/elastic/kibana/issues/164829\r\n\r\n**How to test**\r\n- Create a rule using data view\r\n- Generate some alerts\r\n- Go to alerts page, expand a row in alerts table\r\n- Go to Visualization -> Analyzer preview, the analyzer preview tree\r\nshould be present\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"88c04e5c94f81c0c7b7ba4b965725a8878480bd9"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165398","number":165398,"mergeCommit":{"message":"[Security Solution] Expandable flyout - Update index field in analyzer preview (#165398)\n\n## Summary\r\n\r\nThis PR addresses a bug that when a rule is created using data view,\r\nanalyzer preview is blank. This is due to a check on if index exists\r\nbefore rendering the analyzer preview. This PR updated the index field\r\nfrom `kibana.alert.rule.parameter.index` to 'kibana.alert.rule.indices`,\r\nthe later is introduced in https://github.com/elastic/kibana/pull/130929\r\nand is available when a rule is created using either index patterns or\r\ndata view.\r\n\r\n**How to reproduce the bug**\r\n- Refer to bug report https://github.com/elastic/kibana/issues/164829\r\n\r\n**How to test**\r\n- Create a rule using data view\r\n- Generate some alerts\r\n- Go to alerts page, expand a row in alerts table\r\n- Go to Visualization -> Analyzer preview, the analyzer preview tree\r\nshould be present\r\n\r\n\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"88c04e5c94f81c0c7b7ba4b965725a8878480bd9"}}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
sphilipse
pushed a commit
to sphilipse/kibana
that referenced
this pull request
Sep 4, 2023
…r preview (elastic#165398) ## Summary This PR addresses a bug that when a rule is created using data view, analyzer preview is blank. This is due to a check on if index exists before rendering the analyzer preview. This PR updated the index field from `kibana.alert.rule.parameter.index` to 'kibana.alert.rule.indices`, the later is introduced in elastic#130929 and is available when a rule is created using either index patterns or data view. **How to reproduce the bug** - Refer to bug report elastic#164829 **How to test** - Create a rule using data view - Generate some alerts - Go to alerts page, expand a row in alerts table - Go to Visualization -> Analyzer preview, the analyzer preview tree should be present  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a bug that when a rule is created using data view, analyzer preview is blank. This is due to a check on if index exists before rendering the analyzer preview. This PR updated the index field from
kibana.alert.rule.parameter.indexto 'kibana.alert.rule.indices`, the later is introduced in #130929 and is available when a rule is created using either index patterns or data view.How to reproduce the bug
How to test
Checklist