Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Processes tab test change: Wait for page loading #165303

Merged
merged 1 commit into from
Sep 1, 2023
Merged

[Infra UI] Processes tab test change: Wait for page loading #165303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions x-pack/test/functional/apps/infra/node_details.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
describe('Processes Tab', () => {
before(async () => {
await pageObjects.assetDetails.clickProcessesTab();
await pageObjects.header.waitUntilLoadingHasFinished();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need to add the same thing for other tabs as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have it when initially loading the page - in theory, repeating this is not needed for most cases there is also a timeout so it shouldn't reach it. Here we are checking the content of an element that is still not available which results in having an empty string as value - I guess because we use getVisibleText ( the other tabs we check the elements directly and here we try to get the content of an element which is still not loaded)
I am not against having this in the other tabs but I don't see any failed tests in the other scenarios, maybe I am missing something or it's not an issue there 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got it, good point about getVisibleText, that's probably the difference with other tabs and we don't need to add wait for them 🙌

});

it('should render processes tab and with Total Value summary', async () => {
Expand Down